[dna-issues] [JBoss JIRA] Commented: (DNA-359) Session.refresh and Node.refresh Methods Not Supported

[Randall Hauch (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12462877#action_12462877 ] 

Randall Hauch commented on DNA-359:
-----------------------------------

Applied the second patch, which corrects how the nodes under the refreshed node are computed (to also take into account nodes that were removed from the subgraph).

I think we're still missing some information. Consider a node 'C' that is originally under node 'A', and during a session it is moved under node 'B'.  If 'A' is refreshed, then the current logic will refresh 'A' (by throwing out its local changes) so that it now contains 'C' again (or would if it is re-read, as the cache is filled lazily).  However, since 'B' has been changed in the session to contain 'C', that information is now out of date.  I haven't found where the spec specifically addresses this situation, but I'd expect we should throw an exception (maybe InvalidItemStateException, but probably RepositoryException for 'other problem').

> Session.refresh and Node.refresh Methods Not Supported
> ------------------------------------------------------
>
>                 Key: DNA-359
>                 URL: https://jira.jboss.org/jira/browse/DNA-359
>             Project: DNA
>          Issue Type: Bug
>          Components: JCR
>            Reporter: Brian Carothers
>            Priority: Minor
>         Attachments: DNA-359.patch, DNA-359_check_for_removed_nodes.patch
>
>
> Session.refresh and AbstractJcrNode.refresh methods are stubbed in.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira