[dna-issues] [JBoss JIRA] Commented: (DNA-541) Locking Implementation Does Not Support Timeouts

[Randall Hauch (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12498461#action_12498461 ] 

Randall Hauch commented on DNA-541:
-----------------------------------

I like the weak reference approach, since it's pretty simple.

1) I'm not sure. If you have time, it might be nice to complete this while you're thinking about it.
2) Rather than have the JcrRepository own the scheduler, how about if the JcrRepository exposed a package-level method to perform the cleanup operation.  The JcrEngine could have a single scheduler for all of its JcrRepository instances, configured with the desired interval, and that thread iterates through the JcrRepository instances and calls the cleanupLocks method. This way, the cleanup is performed in a separate thread on a schedule, but there's only one thread in the whole JcrEngine instance configurable through the JcrConfiguration, and yet the JcrRepository instances actually don't have to worry about when this should be called.  The JcrEngine could (eventually) have a public management method to perform the cleanup right then.


> Locking Implementation Does Not Support Timeouts
> ------------------------------------------------
>
>                 Key: DNA-541
>                 URL: https://jira.jboss.org/jira/browse/DNA-541
>             Project: DNA
>          Issue Type: Bug
>          Components: JCR
>            Reporter: Brian Carothers
>            Assignee: Brian Carothers
>             Fix For: 0.7
>
>         Attachments: DNA-541_admin_unlock.patch
>
>
> The locking implementation does not provide a means of expiring stale or old locks (other than having the original owner unlock them).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira