[dna-issues] [JBoss JIRA] Reopened: (DNA-608) RepositoryConnectionPool.ConnectionWrapper.close Closes the Underlying Connection

[Randall Hauch (JIRA)]

     [ https://jira.jboss.org/jira/browse/DNA-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Randall Hauch reopened DNA-608:
-------------------------------



I'm not sure I agree with one of the changes in the patch.  The ConnectionWrapper class formerly kept state that tracked whether it was closed and could no longer be used.  This meant that a component using the connection pool could not close the (wrapped) connection yet continue to use the connection.  With the current changes, it is possible for this to happen and for a connection to not have the correct close semantics.

> RepositoryConnectionPool.ConnectionWrapper.close Closes the Underlying Connection
> ---------------------------------------------------------------------------------
>
>                 Key: DNA-608
>                 URL: https://jira.jboss.org/jira/browse/DNA-608
>             Project: DNA
>          Issue Type: Bug
>          Components: Connectors, Graph
>    Affects Versions: 0.6
>            Reporter: Brian Carothers
>            Assignee: Brian Carothers
>             Fix For: 0.7
>
>         Attachments: DNA-608.patch
>
>
> The RepositoryConnectionPool.ConnectionWrapper.close method is calling close on the underlying connection and then returning it to the available pool.  However, after being closed, the underlying connection is no longer valid and cannot be used.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira