[dna-issues] [JBoss JIRA] Commented: (DNA-390) BatchRequestBuilder Property/Create Folding Behavior

[Brian Carothers (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12477532#action_12477532 ] 

Brian Carothers commented on DNA-390:
-------------------------------------

Now that DNA-379 allows values to be incrementally added or removed from existing properties, the fix to the folding behavior should also fold in UpdateValuesRequests with prior Set/UpdatePropertiesRequests and CreateNodeRequests.

> BatchRequestBuilder Property/Create Folding Behavior
> ----------------------------------------------------
>
>                 Key: DNA-390
>                 URL: https://jira.jboss.org/jira/browse/DNA-390
>             Project: DNA
>          Issue Type: Feature Request
>          Components: API, Graph
>    Affects Versions: 0.3
>            Reporter: Brian Carothers
>            Priority: Minor
>             Fix For: 0.6
>
>
> BatchRequestBuilder currently attempts to consolidate multiple set property and create calls for the same node into a single set property or create statement.  The consolidation process does not seem to respect SNS though.
> For example:
> 1. Create a node at /a/b
> 2. Set some properties on the node at location /a/b
> 3. Create another node at /a/b (same-name sibling)
> 4. Set some other properties on the node at location /a/b 
> The consolidation process sets the properties from step 4 onto the node created at step 1.  This overwrites the properties from step 2 where the property names are the same.
> There are a few workarounds in place right now.  One is to just consolidate the requests yourself prior to invoking the Graph API and adding commands to the batch.  It is possible that using the Path-based variants of the create node and set property commands would also work around this problem if the SNS indices were set correctly on the paths.  I've not tried this approach I think it would be fairly cumbersome and fragile as it would require the caller to track whether there are already any nodes with the same name at the same location and offset SNS indices accordingly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira