[dna-issues] [JBoss JIRA] Commented: (DNA-443) Java sequencer is not saving content correctly

[Randall Hauch (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12471323#action_12471323 ] 

Randall Hauch commented on DNA-443:
-----------------------------------

Actually, the batch 'create(...)' methods on the Graph.Batch class do indeed have the ability to create nodes if they are missing.  In fact, both the batch and non-batch works 
the same way:

   graph.create(path).ifAbsent()...   // or even .orUpdate()

or

   batch.create(path).ifAbsent()...

In fact, this style makes available several other methods than "ifAbsent()", such as "orUpdate()", "byAppending()", and "orReplace()".  These correspond to the different NodeConflictBehavior options.

I'll grant you that the "createIfMissing()" methods are not available in the batch mode.  Perhaps we should deprecate them, since the above methods are newer, more complete, and just as useful.  I think the only capability that the "createIfMissing()" methods have above the others is that they return an interface that has the "andReturn():Node" method, but I think all the non-batch "create()" methods could do this.

I will open an issue to resolve this discrepency in the Graph API, but I'm also going to reopen this issue for 0.6, since sequencers really should be operating in batch (in case there is an error in the middle of processing, and because a large batch with many operations will be significantly faster for most connectors than the same number of operations submitted individually).

> Java sequencer is not saving content correctly
> ----------------------------------------------
>
>                 Key: DNA-443
>                 URL: https://jira.jboss.org/jira/browse/DNA-443
>             Project: DNA
>          Issue Type: Bug
>          Components: Examples, Sequencers
>    Affects Versions: 0.4
>            Reporter: Randall Hauch
>            Assignee: Brian Carothers
>             Fix For: 0.6
>
>
> The Java sequencer doesn't appear to be sequencing the Java source code and saving it correctly.  The SequencingClientTest.shouldUploadAndSequenceJavaSourceFile() fails and has been temporarily ignored.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira