[dna-issues] [JBoss JIRA] Updated: (DNA-298) SVNRepositoryTest Fails on Windows

[Brian Carothers (JIRA)]

     [ https://jira.jboss.org/jira/browse/DNA-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Carothers updated DNA-298:
--------------------------------

    Attachment: DNA-298.patch


On Windows, the URIs constructed by the test will look something like this:  (Note the extra colon after the drive name)

file://localhost/C:/workspaces/jbossdna3-source/trunk/extensions/dna-connector-svn/target/copy_of%20dummy_svn_repos

So this line in SVNRepositorySource:

String usedProtocol = this.getSVNURL().substring(0, this.getSVNURL().lastIndexOf(":"));

Sets usedProtocol to this:

"file://localhost/C"

Instead of this:

"file"

Patch is attached that makes the tests pass on my Windows box.

> SVNRepositoryTest Fails on Windows
> ----------------------------------
>
>                 Key: DNA-298
>                 URL: https://jira.jboss.org/jira/browse/DNA-298
>             Project: DNA
>          Issue Type: Bug
>          Components: Connectors
>    Affects Versions: 0.4
>         Environment: JDK 1.6.0_012, Windows XP
>            Reporter: Brian Carothers
>            Priority: Minor
>         Attachments: DNA-298.patch
>
>
> Two tests in SVNRepositoryTest fail when running on Windows.  The tests are:
> shouldCreateFSRepositoryIfProtocolIsOfTypeFile
> shouldAllowMultipleConnectionsToBeOpenAtTheSameTime
> Both fail with (essentially) the same stack trace:
> org.jboss.dna.graph.connector.RepositorySourceException: Protocol is not supported by this connector or there is problem in the svn url
> 	at org.jboss.dna.connector.svn.SVNRepositorySource.getConnection(SVNRepositorySource.java:300)
> 	at org.jboss.dna.connector.svn.SVNRepositorySourceTest.shouldCreateFSRepositoryIfProtocolIsOfTypeFile(SVNRepositorySourceTest.java:240)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
> 	at org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
> 	at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
> 	at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
> 	at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
> 	at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
> 	at org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
> 	at org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
> 	at org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
> 	at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
> 	at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
> 	at org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
> 	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:45)
> 	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira