[dna-issues] [JBoss JIRA] Commented: (DNA-555) Requirement for extracting indexed content during parsing using TokenStream

[Randall Hauch (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12496198#action_12496198 ] 

Randall Hauch commented on DNA-555:
-----------------------------------

Patch looks pretty good, though I have a few minor nits:

1) The JavaDoc for TokenStream.nextPosition() was changed from "@throws NoSuchElementException if there is no next token" to "@throws NoSuchElementException if there is no previous token" - was this a copy/paste error?
2) The patch is adding the '.project' file under the 'target' directory, which is incorrect.  Make sure that does not get added.

> Requirement for extracting indexed content during parsing using TokenStream
> ---------------------------------------------------------------------------
>
>                 Key: DNA-555
>                 URL: https://jira.jboss.org/jira/browse/DNA-555
>             Project: DNA
>          Issue Type: Bug
>          Components: Common, Graph
>            Reporter: Barry LaFond
>         Attachments: dna.patch
>
>
> Complex DDL parsing requires additional Position information (Index In Content) as well as ability to extract designated segments of the token stream (original file character string)
> So...  a Position.getIndexInContent() method as well as appropriate constructor mods to handle an integer index variable.
> Also need a TokenStream.getContentBetween(position1, position2) to access the string segment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira