[dna-issues] [JBoss JIRA] Commented: (DNA-457) Add JSR-170 Locking Optional Feature

Tue Oct 20 11:31:05 EDT 2009

    [ https://jira.jboss.org/jira/browse/DNA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12490562#action_12490562 ] 

Randall Hauch commented on DNA-457:
-----------------------------------

I definitely like the changes to the graph layer, including the changes to the fluent graph API as well as the requests.

It may be good to elaborate a bit in the JavaDoc for the connector capabilities and what 'supports locking' actually means.  I think it's intuitive that if a connector "supports locking", it basically allows locks to be used on (at least some of) its content, and will either confirm or veto a lock requests.  But it may be a bit more ambiguous as to what it means to not support locking.  I'd guess this means that the connector is saying that locks will not be permitted on any of its content, and that if any lock requests do come down, they will be vetoed/rejected.  Is this correct?

And what will the behavior of our existing connectors be?  IMO, the JPA, in-memory, JBoss Cache, and Infinispan connectors should certainly support locking, but since they are really "storage" connectors (meaning that the underlying systems are 'owned' by DNA and are being accessed by DNA) they have no need to do anything special with the lock requests, other than approve them.  On the other hand, the file system connector should _not_ support locking (perhaps this can change when Java 7 enables interaction with native FS locks).  And the SVN connector is read-only right now and thus should also not support locks, though when the connector is changed to support writes, the connector could also be changed to support locking by integrating with native SVN locks.

Does this sound right?

Probably should update the Reference Guide, too.

> Add JSR-170 Locking Optional Feature
> ------------------------------------
>
>                 Key: DNA-457
>                 URL: https://jira.jboss.org/jira/browse/DNA-457
>             Project: DNA
>          Issue Type: Feature Request
>          Components: JCR
>    Affects Versions: 0.5
>            Reporter: Brian Carothers
>             Fix For: 1.0
>
>         Attachments: DNA-457_for_review.patch, DNA-457_for_review_2.patch, DNA-457_graph_locking_support.patch, DNA-457_WIP.patch
>
>
> JSR-170 defines several optional features.  The locking feature allows users to lock nodes (and, optionally, their descendants) until the session terminates or until they are programatically unlocked.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira