[dna-issues] [JBoss JIRA] Commented: (DNA-499) Wrap system access, context class loader access, and reflection with doPrivileged

[Vijay Kiran Duvvuri (JIRA)]

    [ https://jira.jboss.org/jira/browse/DNA-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12502340#action_12502340 ] 

Vijay Kiran Duvvuri commented on DNA-499:
-----------------------------------------

There was a discussion on this issue if we can create a Utility class with static methods, which can be used to reduce code clutter. But it seems to introduce a security hole according to http://java.sun.com/j2se/1.5.0/docs/guide/security/doprivileged.html 

So all the code need to be wrapped with AccessControl individually.

> Wrap system access, context class loader access, and reflection with doPrivileged
> ---------------------------------------------------------------------------------
>
>                 Key: DNA-499
>                 URL: https://jira.jboss.org/jira/browse/DNA-499
>             Project: DNA
>          Issue Type: Bug
>          Components: API, Common, Connectors, Examples, Federation, Graph, JCR, Maven Classloader, Sequencers
>    Affects Versions: 0.5
>            Reporter: Randall Hauch
>            Assignee: Vijay Kiran Duvvuri
>             Fix For: 1.0
>
>         Attachments: DNA-499.1.patch
>
>
> Several activities should make use of the Java SecurityManager to ensure the caller has the appropriate privileges to perform the activity.  These activities should be wrapped in a block such as the following:
> String lineSeparator = java.security.AccessController.doPrivileged(
>     new java.security.PrivilegedAction<String>() {
>         public String run() {
>             return System.getProperty("line.separator");
>         }
>     }
>  );
> obviously with the correct generic type for whatever is being returned from the run.  (Nice and concise, huh? Ugh.)
> We need to go through all of the (non-test) code and add this checking (if it is not already there) when the following types of activities are performed:
> - System.getProperty
> - System.setProperty
> - Thread.currentThread().getContextClassLoader()
> - All code executed via reflection

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira