[esb-issues] [JBoss JIRA] Updated: (JBESB-1272) CommandInterpreter.doTheJob does not make sense in error condition

[Mark Little (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBESB-1272?page=all ]

Mark Little updated JBESB-1272:
-------------------------------

    Description: 
		Message response = Helper.commandMessageTemplate();
		Body	body	= response.getBody();

		try
		{
			Object obj = getJbpmCommandService().execute(command);
			body.add(Constants.RETURN_CODE, Constants.RETCODE_OK);
			if (null!=obj)
				body.add(Constants.JBPM_RETURN_OBJECT, obj);
		}
		catch (JbpmException e)
		{
			body.add(Constants.RETURN_CODE, Constants.RETCODE_EXCEPTION);
			body.add(Constants.EXCEPTION, e);
            throw e;
		}
		
		return response;

Why does the catch clause modify the body when the message isn't going to be returned?

  was:
		Message response = Helper.commandMessageTemplate();
		Body	body	= response.getBody();

		try
		{
			Object obj = getJbpmCommandService().execute(command);
			body.add(Constants.RETURN_CODE, Constants.RETCODE_OK);
			if (null!=obj)
				body.add(Constants.JBPM_RETURN_OBJECT, obj);
		}
		catch (JbpmException e)
		{
			body.add(Constants.RETURN_CODE, Constants.RETCODE_EXCEPTION);
			body.add(Constants.EXCEPTION, e);
            throw e;
		}
		
		return response;

Why does the code modify the body when the message isn't going to be returned?


> CommandInterpreter.doTheJob does not make sense in error condition
> ------------------------------------------------------------------
>
>                 Key: JBESB-1272
>                 URL: http://jira.jboss.com/jira/browse/JBESB-1272
>             Project: JBoss ESB
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Process flow
>    Affects Versions: 4.2.1 IR2
>            Reporter: Mark Little
>             Fix For: 4.3
>
>
> 		Message response = Helper.commandMessageTemplate();
> 		Body	body	= response.getBody();
> 		try
> 		{
> 			Object obj = getJbpmCommandService().execute(command);
> 			body.add(Constants.RETURN_CODE, Constants.RETCODE_OK);
> 			if (null!=obj)
> 				body.add(Constants.JBPM_RETURN_OBJECT, obj);
> 		}
> 		catch (JbpmException e)
> 		{
> 			body.add(Constants.RETURN_CODE, Constants.RETCODE_EXCEPTION);
> 			body.add(Constants.EXCEPTION, e);
>             throw e;
> 		}
> 		
> 		return response;
> Why does the catch clause modify the body when the message isn't going to be returned?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira