[esb-issues] [JBoss JIRA] Commented: (JBESB-1918) Implementation of ScriptingAction is inefficient and incomplete

[Kevin Conner (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBESB-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12424743#action_12424743 ] 

Kevin Conner commented on JBESB-1918:
-------------------------------------

The following description is not correct and should be removed.

"Currently it is supposed that the file extension is language name, which is probably unintentional, and could lead to exception while processing the first message."

If the language is not explicitly specified then the extension is used to determine which language to use.  This extension can either be the language name *or* the recognised extension as specified within the Languages.properties file.

There should have been a check to see if the language was supported though, this is a valid comment.  There is already a check for a 'null' language.

> Implementation of ScriptingAction is inefficient and incomplete
> ---------------------------------------------------------------
>
>                 Key: JBESB-1918
>                 URL: https://jira.jboss.org/jira/browse/JBESB-1918
>             Project: JBoss ESB
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Rosetta
>    Affects Versions: 4.4
>            Reporter: Jiri Pechanec
>             Fix For: 4.4 CP2
>
>
> The ScriptingAction should be polished for beter perfromance and functionality as Groovy scripting action
>  - BSFManager should be created in intialize(), not process() method (credit goes to Kevin :-))
>  - The script reload should be supported
>  - Is it necessary to process BSF config file? Cannot we use getLangFromFilename method?
>  - It should be probably stated in the docs that for compiled scriping languages it is not guranteed that the compliation is done only once which can lead to performance degradation - native action can be preferred in such case
>  - If the language is not recognized (not in Map) during initialization an exception should be thrown. Currently it is supposed that the file extension is language name, which is probably unintentional, and could lead to exception while processing the first message.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira