[forge-commits] [forge/core] b1b4a4: Initial layout of a Faces scaffold provider

Vineet Reynolds Vineet.Reynolds at gmail.com
Fri Dec 20 12:04:42 EST 2013


  Branch: refs/heads/FORGE-808
  Home:   https://github.com/forge/core
  Commit: b1b4a41787df7200c9e9564261b3c3494f6e2625
      https://github.com/forge/core/commit/b1b4a41787df7200c9e9564261b3c3494f6e2625
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/addon/pom.xml
    A scaffold/faces/pom.xml
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/resources/META-INF/beans.xml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/pom.xml
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java
    M scaffold/tests/pom.xml
    R scaffold/tests/src/test/java/org/jboss/forge/addon/AbstractTestCase.java
    A scaffold/tests/src/test/java/org/jboss/forge/addon/ScaffoldAddonTest.java

  Log Message:
  -----------
  Initial layout of a Faces scaffold provider


  Commit: 04961050cf0371034b1533c6e684aae7e089ca45
      https://github.com/forge/core/commit/04961050cf0371034b1533c6e684aae7e089ca45
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/tests/src/test/java/org/jboss/forge/addon/ScaffoldAddonTest.java

  Log Message:
  -----------
  Corrected failing test for Addon detection.


  Commit: 63f82b9fa681868fb5f4ac31f65b0d4b73cf2e44
      https://github.com/forge/core/commit/63f82b9fa681868fb5f4ac31f65b0d4b73cf2e44
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/pom.xml
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesAccessStrategy.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesTemplateStrategy.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/TemplateStrategy.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/freemarker/FreemarkerTemplateProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/config/ForgeConfigReader.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/GeneratedValueInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/NotRequiredInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/RichfacesCalendarInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/ForgeInspectionResultConstants.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/ForgeInspector.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyle.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyleConfig.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/EntityWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/EntityWidgetBuilderConfig.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/HtmlSearchWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/QueryByExampleWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/RemoveEntityWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/SetPropertyActionListener.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetprocessor/UnsearchableWidgetProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/util/ScaffoldUtil.java
    A scaffold/faces/src/main/resources/scaffold/faces/BackingBean.jv
    A scaffold/faces/src/main/resources/scaffold/faces/ViewUtils.jv
    A scaffold/faces/src/main/resources/scaffold/faces/add.png
    A scaffold/faces/src/main/resources/scaffold/faces/bootstrap.css
    A scaffold/faces/src/main/resources/scaffold/faces/create.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/error.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/false.png
    A scaffold/faces/src/main/resources/scaffold/faces/favicon.ico
    A scaffold/faces/src/main/resources/scaffold/faces/forge-logo.png
    A scaffold/faces/src/main/resources/scaffold/faces/forge-style.css
    A scaffold/faces/src/main/resources/scaffold/faces/forge.taglib.xml
    A scaffold/faces/src/main/resources/scaffold/faces/index.html
    A scaffold/faces/src/main/resources/scaffold/faces/index.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/jboss-community.png
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-bean.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-entity.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-qbe.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-remove-entity.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-search.xml
    A scaffold/faces/src/main/resources/scaffold/faces/pageTemplate.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/paginator.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/remove.png
    A scaffold/faces/src/main/resources/scaffold/faces/search.png
    A scaffold/faces/src/main/resources/scaffold/faces/search.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/true.png
    A scaffold/faces/src/main/resources/scaffold/faces/view.xhtml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/AccessStrategy.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Implemented the Faces scaffold provider

Removed Seam Render since it was resulting in WELD-1453/SOLDER-339.
Switched the Seam Render templates to Freemarker.

Unported APIs/classes are currently not used/commented out with
TODOs.


  Commit: 5746091cf9a1adc582649ec85149096ba896ab0c
      https://github.com/forge/core/commit/5746091cf9a1adc582649ec85149096ba896ab0c
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Removed unnecessary method from ScaffoldProvider API.

The scaffold provider should not be indicating whether it supports
 overwrite or not.


  Commit: 0e4e0b5b06230124eccca4fc4d924bbaed7858f0
      https://github.com/forge/core/commit/0e4e0b5b06230124eccca4fc4d924bbaed7858f0
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Modified the ScaffoldProvider setup flow API.

ScaffoldProviders now return a List of UICommands that
are to be executed.


  Commit: c6dd09bb931d293f29a61829719628c72c6036cf
      https://github.com/forge/core/commit/c6dd09bb931d293f29a61829719628c72c6036cf
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java

  Log Message:
  -----------
  Added facet installation checks.

The Faces scaffold provider now verifies that the required facets
have been installed before setting up the Faces scaffold.


  Commit: 0810fd05de0d5eee74537fa124e0f92d411a20f1
      https://github.com/forge/core/commit/0810fd05de0d5eee74537fa124e0f92d411a20f1
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Fixed the setup process to create correct web.xml files.

Entries in web.xml files are now created correctly.


  Commit: fc0ecf0733d10451e8259dd90bcab2ff884ba28c
      https://github.com/forge/core/commit/fc0ecf0733d10451e8259dd90bcab2ff884ba28c
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java

  Log Message:
  -----------
  Refined the messages.


  Commit: 862b1d007404cc7932395a5334aed5e764b82df1
      https://github.com/forge/core/commit/862b1d007404cc7932395a5334aed5e764b82df1
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java

  Log Message:
  -----------
  Target directory should not be required. It is optional.

Use an empty string if the target directory is not specified.


  Commit: fb48405c0dad41f3d82e7360a748767edc446c74
      https://github.com/forge/core/commit/fb48405c0dad41f3d82e7360a748767edc446c74
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/api/src/main/java/org/jboss/forge/addon/scaffold/ui/ScaffoldGenerateCommand.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyle.java
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-bean.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-entity.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-qbe.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-remove-entity.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-search.xml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldGenerateCommandImpl.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ResourceCollection.java
    R scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldGenerationContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldSetupContext.java

  Log Message:
  -----------
  Committing first functional version of the Faces scaffold

Some bugs are not yet fixed though. CDI and EJB facets are not
installed.


  Commit: 7ce8a584cf51eeee20a56f5230f4eeb00fa7bdca
      https://github.com/forge/core/commit/7ce8a584cf51eeee20a56f5230f4eeb00fa7bdca
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/pom.xml

  Log Message:
  -----------
  Removed unwanted property for Seam Render version


  Commit: c7069a91f398da8be6a32c931494c3759a7d5fd2
      https://github.com/forge/core/commit/c7069a91f398da8be6a32c931494c3759a7d5fd2
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Expanded Facet subtype checks.

This is to bypass FORGE-1304 for now.


  Commit: a1b98a63b77aed8b345816efa0288a3ced670ac6
      https://github.com/forge/core/commit/a1b98a63b77aed8b345816efa0288a3ced670ac6
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/faces/src/main/resources/scaffold/faces/create.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/pageTemplate.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/search.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/view.xhtml

  Log Message:
  -----------
  Fixed Freemarker template issues

Locked the template to pageTemplate.xhtml. Corrected the escaping
of #{ and ${ expressions in the facelets.


  Commit: 98b2fd6905fbb90a1df96de68899ab64055ca6ed
      https://github.com/forge/core/commit/98b2fd6905fbb90a1df96de68899ab64055ca6ed
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Fixed CDI Facet detection logic


  Commit: a57751a92012172748c9c7a9dd77a1777b61cc25
      https://github.com/forge/core/commit/a57751a92012172748c9c7a9dd77a1777b61cc25
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesAccessStrategy.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Removed explicit subtype Facet detection logic

The explicit detection of Facets is no longer necessary, since the
bug in subflow display logic is actually in UI-Eclipse.


  Commit: 87fbd0e7bae75a90ce3550f1431979e5b9434fca
      https://github.com/forge/core/commit/87fbd0e7bae75a90ce3550f1431979e5b9434fca
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java
    A scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ExecuteGenerationCommand.java
    A scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ExecuteSetupCommand.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldGenerateCommandImpl.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldGenerationContext.java

  Log Message:
  -----------
  Refactored the scaffold generation into a new step

This now ensures that the scaffold generation is performed in the
final step instead of the first step.


  Commit: 1c93a3dc1d100efdf740d8e39d83492a738dbf8a
      https://github.com/forge/core/commit/1c93a3dc1d100efdf740d8e39d83492a738dbf8a
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/tests/src/test/java/org/jboss/forge/addon/ScaffoldAddonTest.java

  Log Message:
  -----------
  Remove unused imports.


  Commit: cf04e2a2af110ae19984a3aa21d287d4a0ff584c
      https://github.com/forge/core/commit/cf04e2a2af110ae19984a3aa21d287d4a0ff584c
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesTemplateStrategy.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldGenerationContext.java

  Log Message:
  -----------
  Allow custom Faces templates for the Faces scaffold


  Commit: d5596680d23150161d958176c2c5304ad2fc7089
      https://github.com/forge/core/commit/d5596680d23150161d958176c2c5304ad2fc7089
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java

  Log Message:
  -----------
  Use UIInput<FileResource> instead of UIInput<File>.


  Commit: a00111ca50fcd70d71417bead8378e0bcd6c927f
      https://github.com/forge/core/commit/a00111ca50fcd70d71417bead8378e0bcd6c927f
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-20 (Fri, 20 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java
    R scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ExecuteGenerationCommand.java
    A scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ExecuteGenerationStep.java
    R scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ExecuteSetupCommand.java
    A scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ExecuteSetupStep.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldGenerateCommandImpl.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java

  Log Message:
  -----------
  Changed the Generate and Setup commands to UIWizardSteps


Compare: https://github.com/forge/core/compare/204ecd9b1774...a00111ca50fc


More information about the forge-commits mailing list