[forge-commits] [forge/core] c8bb75: Fix ImportImpl's equals method

George Gastaldi gegastaldi at gmail.com
Tue Feb 5 16:33:34 EST 2013


  Branch: refs/heads/master
  Home:   https://github.com/forge/core
  Commit: c8bb758c658092ced26ab1cd78f87a153cf569ef
      https://github.com/forge/core/commit/c8bb758c658092ced26ab1cd78f87a153cf569ef
  Author: Ivan Ivanov <ivan.ivanov at sap.com>
  Date:   2013-02-05 (Tue, 05 Feb 2013)

  Changed paths:
    M parser-java/src/main/java/org/jboss/forge/parser/java/impl/ImportImpl.java
    A parser-java/src/test/java/org/jboss/forge/test/parser/java/ImportEqualityTest.java

  Log Message:
  -----------
  Fix ImportImpl's equals method
  * It follows the best practices for an equals method as defined in Effective Java
  * It addresses the concerns about comparing with other implementations of the Import interface


  Commit: bd0c4a142c86b8c90853729b6ff24ce48f2a87e1
      https://github.com/forge/core/commit/bd0c4a142c86b8c90853729b6ff24ce48f2a87e1
  Author: George Gastaldi <gegastaldi at gmail.com>
  Date:   2013-02-05 (Tue, 05 Feb 2013)

  Changed paths:
    M parser-java/src/main/java/org/jboss/forge/parser/java/impl/ImportImpl.java
    A parser-java/src/test/java/org/jboss/forge/test/parser/java/ImportEqualityTest.java

  Log Message:
  -----------
  Merge pull request #286 from ivannov/FORGE-150

Fix ImportImpl's equals method


Compare: https://github.com/forge/core/compare/1598ab61ccf6...bd0c4a142c86


More information about the forge-commits mailing list