[forge-commits] [forge/core] 345a0e: FORGE-1012 Set the console reader thread to a daem...

George Gastaldi gegastaldi at gmail.com
Wed Jul 17 11:20:18 EDT 2013


  Branch: refs/heads/master
  Home:   https://github.com/forge/core
  Commit: 345a0e87f143d444f7c6e8df8df4a2f3387cca75
      https://github.com/forge/core/commit/345a0e87f143d444f7c6e8df8df4a2f3387cca75
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-07-14 (Sun, 14 Jul 2013)

  Changed paths:
    M shell/src/main/java/org/jboss/forge/shell/IgnoreEofKeyListener.java
    M shell/src/main/java/org/jboss/forge/shell/buffers/ConsoleInputSession.java

  Log Message:
  -----------
  FORGE-1012 Set the console reader thread to a daemon.

This ensures that Forge terminates immediately upon exit without requiring another keystroke to unblock the blocked reader thread on System.in

Also modified the invocation of the exit command on Ctrl+D to issue a newline upon exit to ensure that the shell prompt appears in a new line.


  Commit: 27a7a77deb763fbc075f9c4743c5482cee866203
      https://github.com/forge/core/commit/27a7a77deb763fbc075f9c4743c5482cee866203
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-07-14 (Sun, 14 Jul 2013)

  Changed paths:
    M shell/src/main/java/org/jboss/forge/shell/buffers/ConsoleInputSession.java

  Log Message:
  -----------
  FORGE-942 Use Jansi for reading characters in Windows.

This is the default jline2 behavior. Reading is delegated to WindowsSupport.getByte on Windows instead of reading directly from System.in. This makes keystrokes like arrow keys available as events to the ConsoleReader, thus triggering the browsing of the Forge command history correctly.


  Commit: 4d643cff5f60071dca160d5c615fef3815c3c26c
      https://github.com/forge/core/commit/4d643cff5f60071dca160d5c615fef3815c3c26c
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-07-14 (Sun, 14 Jul 2013)

  Changed paths:
    M shell-api/src/main/java/org/jboss/forge/shell/util/PathspecParser.java
    M shell/src/main/java/org/jboss/forge/shell/completer/OptionValueResolverCompleter.java

  Log Message:
  -----------
  FORGE-554 Provide options for autocomplete relative to the typed paths.

The fix was to ensure that PathspecParser computed the options relative
to the supplied path instead of the drive root.

Also fixed a bug involving display and usage of forward slashes instead
of the OS file separators when displaying the paths or accepting them as
user input in Windows.


  Commit: 6cf263dd67f08744ba77e599bf2e31697d2c35d4
      https://github.com/forge/core/commit/6cf263dd67f08744ba77e599bf2e31697d2c35d4
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-07-17 (Wed, 17 Jul 2013)

  Changed paths:
    M shell/src/main/java/org/jboss/forge/shell/buffers/ConsoleInputSession.java

  Log Message:
  -----------
  Break out of reading from System.in on interrupt.


  Commit: 7f80a755e4b1e4c65f4a833aad459dcf9ac27913
      https://github.com/forge/core/commit/7f80a755e4b1e4c65f4a833aad459dcf9ac27913
  Author: George Gastaldi <gegastaldi at gmail.com>
  Date:   2013-07-17 (Wed, 17 Jul 2013)

  Changed paths:
    M shell-api/src/main/java/org/jboss/forge/shell/util/PathspecParser.java
    M shell/src/main/java/org/jboss/forge/shell/IgnoreEofKeyListener.java
    M shell/src/main/java/org/jboss/forge/shell/buffers/ConsoleInputSession.java
    M shell/src/main/java/org/jboss/forge/shell/completer/OptionValueResolverCompleter.java

  Log Message:
  -----------
  Merge pull request #332 from VineetReynolds/FORGE-1012

FORGE-1012, FORGE-942, FORGE-554 (Multiple bug fixes for Shell)


Compare: https://github.com/forge/core/compare/c4eb14662e85...7f80a755e4b1


More information about the forge-commits mailing list