[forge-dev] leaking classloaders?!

[Lincoln Baxter, III]

Or something else is accessing Forge 2 without properly configuring JBoss
Modules. Either way, I haven't seen this problem occur for us during
development since I created this workaround, but it is concerning... If
forge is the only plugin that brings in JBM, then maybe there is something
bad going on... again, it would surprise me.


On Fri, May 31, 2013 at 9:21 AM, Lincoln Baxter, III <
lincolnbaxter at gmail.com> wrote:

> I would be surprised if Forge is the cause of this issue. We take explicit
> steps to avoid this problem. The ModuleSpec you linked to does add the
> __redirected/ path, but that would only expose them to the Forge container.
> We use this version of JBoss Modules and a very simple workaround:
>
> Fix:
> https://github.com/forge/jboss-modules/commit/063fec233e2e45471365ef10742408eec1a984ff
> Usage:
> https://github.com/forge/jbosstools-forge/blob/master/plugins/org.jboss.tools.forge.core.ext/src/org/jboss/tools/forge/ext/core/ForgeCorePlugin.java#L43
>
>  So my guess is that something else is bringing up JBoss Modules other
> than Forge.
>
>
> On Fri, May 31, 2013 at 8:03 AM, Max Rydahl Andersen <manderse at redhat.com>wrote:
>
>> On Thu, May 30, 2013 at 07:57:12PM -0400, Lincoln Baxter, III wrote:
>> >Which version of Forge 2 is included in the version of JBoss Tools
>> >exhibiting the problem?
>>
>> what ever you guys gave us - you tell me ;)
>>
>> this is jbosstools Beta1 and if the branch is correct it contains:
>> 2.0.0.Alpha4
>>
>> So my guess is that it isn't fixed - or something else is loading jboss
>> modules in a broken fashion :(
>>
>> ill post on the forum.
>> /max
>>
>> >
>> >On Thu, May 30, 2013 at 6:32 PM, George Gastaldi <ggastald at redhat.com
>> >wrote:
>> >
>> >> Max,
>> >>
>> >> Probably https://issues.jboss.org/browse/MODULES-136 describes better
>> >> what's going on.
>> >> We have fixed this by forking JBM.
>> >> It should not happen in the latest available version 2.0.0.Alpha4
>> >>
>> >> Best Regards,
>> >>
>> >> George Gastaldi
>> >>
>> >> Em 30/05/2013, às 18:49, Max Rydahl Andersen <manderse at redhat.com>
>> >> escreveu:
>> >>
>> >> Heya,
>> >>
>> >> We just got this posted on jbosstools-dev at
>> >> https://community.jboss.org/message/820446#820446
>> >>
>> >> Problem of xmldocument factory builders being messed up.
>> >>
>> >> I've asked for more details but I went and looked in forge 2 code base
>> and
>> >> found this
>> >> at
>> >>
>> https://github.com/forge/core/blob/2.0/container/src/main/java/org/jboss/forge/furnace/modules/providers/AbstractModuleSpecProvider.java#L115
>> >>
>> >> systemPaths.add("__redirected");
>> >>
>> >> and in
>> >>
>> https://github.com/jbossas/jboss-modules/blob/master/src/main/java/__redirected/__DocumentBuilderFactory.java
>> >>
>> >> Meaning my best guess is that Forge 2 is somehow leaking jboss modules
>> >> isolation into eclipse osgi which just can't be allowed
>> >> since it breaks the platform.
>> >>
>> >> Any idea of what we can do to get this tracked down and fixed ASAP ?
>> >>
>> >> Please post on the forum post so Juergen can see it too.
>> >>
>> >> Thank you,
>> >> Max
>> >> _______________________________________________
>> >> forge-dev mailing list
>> >> forge-dev at lists.jboss.org
>> >> https://lists.jboss.org/mailman/listinfo/forge-dev
>> >>
>> >>
>> >> _______________________________________________
>> >> forge-dev mailing list
>> >> forge-dev at lists.jboss.org
>> >> https://lists.jboss.org/mailman/listinfo/forge-dev
>> >>
>> >
>> >
>> >
>> >--
>> >Lincoln Baxter, III
>> >http://ocpsoft.org
>> >"Simpler is better."
>>
>> >_______________________________________________
>> >forge-dev mailing list
>> >forge-dev at lists.jboss.org
>> >https://lists.jboss.org/mailman/listinfo/forge-dev
>>
>> _______________________________________________
>> forge-dev mailing list
>> forge-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/forge-dev
>>
>
>
>
> --
> Lincoln Baxter, III
> http://ocpsoft.org
> "Simpler is better."
>



-- 
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/forge-dev/attachments/20130531/d8987e2e/attachment-0001.html