[gatein-dev] GateIn parent pom

[Dimitri]

yes in gatein only for the packaging seems logical. 

Dimitri BAELI 
VP Quality -- eXo Platform

Le 18 févr. 2011 à 21:08, Thomas Heute <theute at redhat.com> a écrit :

> On 02/18/2011 03:07 PM, Dimitri wrote:
>> For repositories I let Arnaud give his feedback.
>> I would prefer to not put them and add a settings.xml.excerpt with the part to put in the real one.
>> 
>> One feedback bellow on packaging.
>> 
>> Dimitri BAELI
>> VP Quality -- eXo Platform
>> 
>> Le 18 févr. 2011 à 20:57, Julien Viet<julien at julienviet.com>  a écrit :
>> 
>>> On Feb 18, 2011, at 2:54 PM, Thomas Heute wrote:
>>> 
>>>> On 02/14/2011 09:03 PM, Thomas Heute wrote:
>>>>> To the Maven expert(s), i plan to do some update in our GateIn parent:
>>>>> 
>>>>>     - Upgrade org.codehaus.mojo:jboss-packaging-maven-plugin upgrade to
>>>>> 2.0-beta1 =>   2.1.1: Upgraditis + we were using a Beta. Not sure if we
>>>>> are ever using it.
>>>>>     - Remove repositories + pluginRepositories definitions, it's
>>>>> supposed to be a best practice, correct me if I'm wrong (But will
>>>>> require people to have those defined in their local installation)
>>>>> 
>>>>> Anything I missed/got wrong ?
>>>>> _______________________________________________
>>>>> gatein-dev mailing list
>>>>> gatein-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/gatein-dev
>>>> I actually removed the jboss-packaging-maven-plugin as we don't need it
>>>> in all components:
>>> what does the jboss-packaging-maven-plugin do ?
>>> 
>>>> I will remove repository declarations from the parent but may add it
>>>> back into gatein root pom.xml to make it easy for contributors (and also
>>>> easy to remove).
>>> arnaud is in vacation currently so he cannot give us his feedback :-\
>>> 
>>> personally I don't know what is good and what is bad, so my POV is neutral (as long as it works and it is easy to make it work).
>>> 
>>>> Next step would be to make sure all dependencies can be obtained from:
>>>> http://repository.jboss.org/nexus/content/groups/developer
>>>> 
>>>> Below is what I'm about to commit for the new parent to all GateIn
>>>> components and portal:
>>>> 
>>>> 
>>>> Index: pom.xml
>>>> ===================================================================
>>>> --- pom.xml    (revision 5914)
>>>> +++ pom.xml    (working copy)
>>>> @@ -14,7 +14,7 @@
>>>> 
>>>> <groupId>org.gatein</groupId>
>>>> <artifactId>gatein-parent</artifactId>
>>>> -<version>1.0.3-GA-SNAPSHOT</version>
>>>> +<version>1.1.0-GA-SNAPSHOT</version>
>>>> <packaging>pom</packaging>
>>>> 
>>>> <scm>
>>>> @@ -40,11 +40,13 @@
>>>> <!-- maven-enforcer-plugin -->
>>>> <maven.min.version>2.2.1</maven.min.version>
>>>> 
>>>> +<jdk.min.version>1.6</jdk.min.version>
>>>> +
>>>> <!-- maven-release-plugin -->
>>>> <autoVersionSubmodules>true</autoVersionSubmodules>
>>>> 
>>>> <!-- maven-release-plugin -->
>>>> -<arguments>-Prelease,pkg-tomcat,pkg-jbossas -DskipTests</arguments>
>>>> +<arguments>-Prelease -DskipTests</arguments>
>> Why the pkg targets are remove in the release d, it's done by default ?
> Ah, I forgot to ask about that one :)
> 1) I'm not sure what this really does
> 2) we have more packaging now (as5, as6, jetty), does this really belong here ? There is no pkg-* in the GateIn components, I guess the whole arguments thing should actually be removed from the parent and put into GateIn Portal pom.xml
>>>> <!-- cf http://jira.codehaus.org/browse/MRELEASE-3 -->
>>>> <preparationGoals>clean install</preparationGoals>
>>>> @@ -60,11 +62,6 @@
>>>> <!-- Plugins are sorted by shortname : clean, deploy, ... -->
>>>> <plugins>
>>>> <plugin>
>>>> -<groupId>org.codehaus.mojo</groupId>
>>>> -<artifactId>jboss-packaging-maven-plugin</artifactId>
>>>> -<version>2.0-beta-1</version>
>>>> -</plugin>
>>>> -<plugin>
>>>> <groupId>org.apache.maven.plugins</groupId>
>>>> <artifactId>maven-jar-plugin</artifactId>
>>>> <configuration>
>>>> @@ -167,43 +164,6 @@
>>>> </profiles>
>>>> 
>>>> <!-- **************** -->
>>>> -<!-- Repositiories    -->
>>>> -<!-- **************** -->
>>>> -<repositories>
>>>> -<repository>
>>>> -<id>jboss-public-repository-group</id>
>>>> -<name>JBoss Public Maven Repository Group</name>
>>>> -<url>https://repository.jboss.org/nexus/content/groups/public/</url>
>>>> -<layout>default</layout>
>>>> -<releases>
>>>> -<enabled>true</enabled>
>>>> -<updatePolicy>never</updatePolicy>
>>>> -</releases>
>>>> -<snapshots>
>>>> -<enabled>true</enabled>
>>>> -<updatePolicy>never</updatePolicy>
>>>> -</snapshots>
>>>> -</repository>
>>>> -</repositories>
>>>> -
>>>> -<pluginRepositories>
>>>> -<pluginRepository>
>>>> -<id>jboss-public-repository-group</id>
>>>> -<name>JBoss Public Maven Repository Group</name>
>>>> -<url>https://repository.jboss.org/nexus/content/groups/public/</url>
>>>> -<layout>default</layout>
>>>> -<releases>
>>>> -<enabled>true</enabled>
>>>> -<updatePolicy>never</updatePolicy>
>>>> -</releases>
>>>> -<snapshots>
>>>> -<enabled>true</enabled>
>>>> -<updatePolicy>never</updatePolicy>
>>>> -</snapshots>
>>>> -</pluginRepository>
>>>> -</pluginRepositories>
>>>> -
>>>> -<!-- **************** -->
>>>> <!-- Reporting        -->
>>>> <!-- **************** -->
>>>> 
>>>> 
>>>> _______________________________________________
>>>> gatein-dev mailing list
>>>> gatein-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/gatein-dev
>>> 
>>> _______________________________________________
>>> gatein-dev mailing list
>>> gatein-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/gatein-dev
>