[gatein-dev] Please review: GTNPORTAL-3263 "Restricted" page editor

Phuong Viet VU phuongvv at exoplatform.com
Mon Oct 14 07:46:40 EDT 2013


ok, I have some more comments:
1. I see that "root" user can do anything, even when we set "nobody" for
move*-application and move*-container. But the specification say that it
can prevent "root" user.

2. I can't DnD new App and Container to portal-layout (run gatein with
extension).
When I create page with "Add page" wizard, choose "Two columns" layout -->
Can't DnD new container to the Page, even there is
"HasMoveContainersPermissions" class

3. The feature only work if we create page from templates. But GateIn also
allow to create page with-out template:
by using "Page management" portlet, or when using navigation editor -->
create node --> create page. It create a page with-out template, and the
move* permission is null --> no way to DnD Apps and Container to the newly
created page. And we don't have UI support to set the move* permission



On Mon, Oct 14, 2013 at 4:28 PM, Peter Palaga <ppalaga at redhat.com> wrote:

> Thanks for the message, Phuong. I'll have a look what is the problem. -- PP
>
>
> On 2013-10-14 11:17, Phuong Viet VU wrote:
>
>> Hi, I'm trying "Restricted" page editor feature (build with tomcat7 -->
>> https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**3263.3<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
>> )
>> I tried GateIn without the extension
>> (https://github.com/ppalaga/**gatein-restricted-page-editor-**extension<https://github.com/ppalaga/gatein-restricted-page-editor-extension>)
>> -->
>> It should works the same as before this feature, right ?
>>
>> 1. After login as root, go to home page, edit portal layout --> I can't
>> DnD page-body to another place, it always stay in the same place
>> 2. Try to drop new Row container, and new application to the page, then
>> move them around --> Exception in the console
>> 143469 [http-bio-8080-exec-6] ERROR portal:UIPortalApplication - Error
>> during the processAction phase
>> java.lang.NullPointerException
>> at
>> org.exoplatform.portal.webui.**portal.**UIPortalComponentActionListene**
>> r$MoveChildActionListener.**prepareUiSource(**
>> UIPortalComponentActionListene**r.java:300)
>> at
>> org.exoplatform.portal.webui.**portal.**UIPortalComponentActionListene**
>> r$MoveChildActionListener.**execute(**UIPortalComponentActionListene**
>> r.java:239)
>> at org.exoplatform.webui.event.**Event.broadcast(Event.java:97)
>> at
>> org.exoplatform.webui.core.**lifecycle.Lifecycle.**
>> processAction(Lifecycle.java:**51)
>> at
>> org.exoplatform.webui.core.**UIComponent.processAction(**
>> UIComponent.java:119)
>> at
>> org.exoplatform.portal.webui.**workspace.**UIPortalApplicationLifecycle.*
>> *processAction(**UIPortalApplicationLifecycle.**java:73)
>> at
>> org.exoplatform.portal.webui.**workspace.**UIPortalApplicationLifecycle.*
>> *processAction(**UIPortalApplicationLifecycle.**java:36)
>>
>>
>>
>> On Fri, Oct 11, 2013 at 10:00 PM, Peter Palaga <ppalaga at redhat.com
>> <mailto:ppalaga at redhat.com>> wrote:
>>
>>     Thanks Trong.
>>
>>     Please note that there is a small update in
>>     https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-**3263.3<https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>: The new
>>     permissions are enforced also during deletions now.
>>
>>     Best,
>>
>>     Peter
>>
>>     On 2013-10-11 06:05, Trong Tran wrote:
>>      > Hi,
>>      >
>>      > We are going to take a look at this and will give you feedback on
>>     Monday
>>      >
>>      > Thanks,
>>      >
>>      >
>>      > On 10 October 2013 15:45, Peter Palaga <ppalaga at redhat.com
>>     <mailto:ppalaga at redhat.com>
>>      > <mailto:ppalaga at redhat.com <mailto:ppalaga at redhat.com>>> wrote:
>>      >
>>      >     Hi *,
>>      >
>>      >     it would be nice if someone from eXo could have a look at
>>     this. Please
>>      >     note that we cannot wait for long. We have decided to do a
>>     RH-internal
>>      >     cross-checking with Lucas and if there is no message from eXo
>>     after we
>>      >     are finished with the checks, I'll merge it without waiting
>>     for eXo.
>>      >
>>      >     Thanks,
>>      >
>>      >     Peter
>>      >
>>      >     On 2013-10-04 17:11, Peter Palaga wrote:
>>      >      > Hi *,
>>      >      >
>>      >      > It is quite an extensive patch. Could please somebody have
>>     a look
>>      >     at it?
>>      >      >
>>      >      > https://github.com/ppalaga/**gatein-portal/tree/GTNPORTAL-*
>> *3263.3 <https://github.com/ppalaga/gatein-portal/tree/GTNPORTAL-3263.3>
>>      >      >
>>      >      > It implements a requirement from a customer as described in
>>      >      >
>>      >      > https://community.jboss.org/**wiki/RestrictedPageEditor<https://community.jboss.org/wiki/RestrictedPageEditor>
>>      >      >
>>      >      > To see the behavior requested by the customer, you should
>>     build the
>>      >      > portal from my GTNPORTAL-3263.3 branch and run AS with this
>>      >     extension:
>>      >      >
>>      >      >
>>     https://github.com/ppalaga/**gatein-restricted-page-editor-**
>> extension<https://github.com/ppalaga/gatein-restricted-page-editor-extension>
>>      >      >
>>      >      > Thanks,
>>      >      >
>>      >      > Peter
>>      >      > ______________________________**_________________
>>      >      > gatein-dev mailing list
>>      >      > gatein-dev at lists.jboss.org
>>     <mailto:gatein-dev at lists.**jboss.org <gatein-dev at lists.jboss.org>>
>>     <mailto:gatein-dev at lists.**jboss.org <gatein-dev at lists.jboss.org><mailto:
>> gatein-dev at lists.**jboss.org <gatein-dev at lists.jboss.org>>>
>>
>>      >      > https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jboss.org/mailman/listinfo/gatein-dev>
>>      >      >
>>      >
>>      >     ______________________________**_________________
>>      >     gatein-dev mailing list
>>      > gatein-dev at lists.jboss.org <mailto:gatein-dev at lists.**jboss.org<gatein-dev at lists.jboss.org>
>> >
>>     <mailto:gatein-dev at lists.**jboss.org <gatein-dev at lists.jboss.org><mailto:
>> gatein-dev at lists.**jboss.org <gatein-dev at lists.jboss.org>>>
>>
>>      > https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jboss.org/mailman/listinfo/gatein-dev>
>>      >
>>      >
>>      >
>>     >
>>     > --
>>     > *Trong Tran*
>>     > /(+84) 983841909 | /trongtt at gmail.com <mailto:trongtt at gmail.com>
>>     <mailto:trongtt at gmail.com <mailto:trongtt at gmail.com>>
>>
>>     > Twitter:http://twitter.com/**trongtt//<http://twitter.com/trongtt//>
>>
>>     ______________________________**_________________
>>     gatein-dev mailing list
>>     gatein-dev at lists.jboss.org <mailto:gatein-dev at lists.**jboss.org<gatein-dev at lists.jboss.org>
>> >
>>     https://lists.jboss.org/**mailman/listinfo/gatein-dev<https://lists.jboss.org/mailman/listinfo/gatein-dev>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/gatein-dev/attachments/20131014/446c1f93/attachment.html 


More information about the gatein-dev mailing list