[Hawkular-commits] [hawkular/hawkular-alerts] fa42fc: Simplify Data subclasses
Jay Shaughnessy
jshaughn at redhat.com
Tue Feb 10 11:56:59 EST 2015
Branch: refs/heads/master
Home: https://github.com/hawkular/hawkular-alerts
Commit: fa42fc79c4ec60ff4de00232c5a96ed5993898f2
https://github.com/hawkular/hawkular-alerts/commit/fa42fc79c4ec60ff4de00232c5a96ed5993898f2
Author: Jay Shaughnessy <jshaughn at redhat.com>
Date: 2015-02-06 (Fri, 06 Feb 2015)
Changed paths:
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data/Availability.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data/Data.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data/NumericData.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data/StringData.java
M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/BasicAlertsServiceImpl.java
M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/DroolsRulesEngineImpl.java
M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/rules/RulesEngine.java
M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/RulesEngineTest.java
Log Message:
-----------
Simplify Data subclasses
- push 'value' field down to Data so it can provide full equals/hashcode impls
- make Data Comparable so we can easily order Data being fed into rules engine
- also allows us to protect against sending multiple datums for the same
dataId into one rules execution.
Update RulesEngine API to make explicit the addition of Data and non-data Facts.
- Non-data facts are inserted immediately into the session
- Data is accumulated and ordered, and held until the next rule firing.
- data facts are now inserted in time order, ascending
- added logic to limit a rules execution to only one Data Fact for the same
dataId (oldest first).
Commit: 2d185dcc464cecd30e5c1b0220a7a5550006f1fc
https://github.com/hawkular/hawkular-alerts/commit/2d185dcc464cecd30e5c1b0220a7a5550006f1fc
Author: Jay Shaughnessy <jshaughn at redhat.com>
Date: 2015-02-06 (Fri, 06 Feb 2015)
Changed paths:
M pom.xml
Log Message:
-----------
remove Java 1.6 maven compiler directives and defer to the hawkular parent
pom (which uses java 1.8)
Commit: b704bf61b2ffaf4eb9fee59bfdb2460cd4b0ac62
https://github.com/hawkular/hawkular-alerts/commit/b704bf61b2ffaf4eb9fee59bfdb2460cd4b0ac62
Author: Jay Shaughnessy <jshaughn at redhat.com>
Date: 2015-02-06 (Fri, 06 Feb 2015)
Changed paths:
M hawkular-alerts-engine/pom.xml
A hawkular-alerts-engine/src/test/resources/log4j.xml
M pom.xml
Log Message:
-----------
After a long investigation understood why debug logging was not happy
when we ran junit tests. Because we were outside of WFly jboss logging
could not find log4j, and so defaulted to jdk logging. To get the
log4j.xml to have any effect you need to be logging with log4j :) So,
added WFly bom to parent pom dep mgmt, and a separate test scope dep on
log4j to the engine module. This way the version of log4j is the same
no matter how we run things.
Commit: fb3e01bf1a53c413909dbf6fb518e7702f572155
https://github.com/hawkular/hawkular-alerts/commit/fb3e01bf1a53c413909dbf6fb518e7702f572155
Author: Jay Shaughnessy <jshaughn at redhat.com>
Date: 2015-02-06 (Fri, 06 Feb 2015)
Changed paths:
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/dampening/Dampening.java
Log Message:
-----------
Fix a problem where Alerts lost their satisfying evals when the dampening
was reset.
Commit: e31332167a3b01385ed747c8b9509584b6445a83
https://github.com/hawkular/hawkular-alerts/commit/e31332167a3b01385ed747c8b9509584b6445a83
Author: Jay Shaughnessy <jshaughn at redhat.com>
Date: 2015-02-09 (Mon, 09 Feb 2015)
Changed paths:
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdRangeCondition.java
Log Message:
-----------
Fix problem in ThresholdRangeCondition match evaluation.
Commit: 6d7c20bb189ee50fcf9576bb6582b7cd3fb0f4c2
https://github.com/hawkular/hawkular-alerts/commit/6d7c20bb189ee50fcf9576bb6582b7cd3fb0f4c2
Author: Jay Shaughnessy <jshaughn at redhat.com>
Date: 2015-02-09 (Mon, 09 Feb 2015)
Changed paths:
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/StringCondition.java
Log Message:
-----------
Fix problem with String pattern match with ignoreCase=true
Commit: 2124be7ab7b1a6d772d4f642d4339719d1d9d331
https://github.com/hawkular/hawkular-alerts/commit/2124be7ab7b1a6d772d4f642d4339719d1d9d331
Author: Jay Shaughnessy <jshaughn at redhat.com>
Date: 2015-02-09 (Mon, 09 Feb 2015)
Changed paths:
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/Alert.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/dampening/Dampening.java
M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/RulesEngineTest.java
Log Message:
-----------
- Add more robust and specific junit tests for the engine.
- Add some convenience factory methods for Dampening
- Rename Alert.evals to Alert.evalSets to be analogous to
trigger's condition sets. And just for overall clarity.
TBD: Unit tests for multi-condition triggers.
Commit: eba5627c73f68c27cca773a284a1d8e53fdfb7b8
https://github.com/hawkular/hawkular-alerts/commit/eba5627c73f68c27cca773a284a1d8e53fdfb7b8
Author: Jay Shaughnessy <jshaughn at redhat.com>
Date: 2015-02-10 (Tue, 10 Feb 2015)
Changed paths:
M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/RulesEngineTest.java
Log Message:
-----------
Add multi-condition rule test
Commit: 2e41d0c0f6ba3845f894a0b2a5176dab0f9a2273
https://github.com/hawkular/hawkular-alerts/commit/2e41d0c0f6ba3845f894a0b2a5176dab0f9a2273
Author: Jay Shaughnessy <jshaughn at redhat.com>
Date: 2015-02-10 (Tue, 10 Feb 2015)
Changed paths:
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/Alert.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/StringCondition.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdRangeCondition.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/dampening/Dampening.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data/Availability.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data/Data.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data/NumericData.java
M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data/StringData.java
M hawkular-alerts-engine/pom.xml
M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/BasicAlertsServiceImpl.java
M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/DroolsRulesEngineImpl.java
M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/rules/RulesEngine.java
M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/RulesEngineTest.java
A hawkular-alerts-engine/src/test/resources/log4j.xml
M pom.xml
Log Message:
-----------
Merge pull request #10 from hawkular/jshaughn/data-insert
Jshaughn/data insert
Compare: https://github.com/hawkular/hawkular-alerts/compare/79211a69bda7...2e41d0c0f6ba
More information about the hawkular-commits
mailing list