[Hawkular-commits] [hawkular/hawkular-alerts] 71027f: HWKALERTS-54 : Alerts spinning the logs with error...

[Lucas Ponce]

  Branch: refs/heads/master
  Home:   https://github.com/hawkular/hawkular-alerts
  Commit: 71027f306f43966b64758571d20471953f1810b7
      https://github.com/hawkular/hawkular-alerts/commit/71027f306f43966b64758571d20471953f1810b7
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2015-06-02 (Tue, 02 Jun 2015)

  Changed paths:
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/services/AlertsService.java
    M hawkular-alerts-bus/src/main/java/org/hawkular/alerts/bus/listener/AlertDataListener.java
    M hawkular-alerts-bus/src/main/java/org/hawkular/alerts/bus/listener/AvailDataListener.java
    M hawkular-alerts-bus/src/main/java/org/hawkular/alerts/bus/listener/MetricDataListener.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/StandaloneAlerts.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/AlertsEngineImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/DbAlertsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/DbDefinitionsServiceImpl.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/AlertsEngine.java
    M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/DbDefinitionsTest.java
    M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/DefinitionsTest.java
    M hawkular-alerts-rest/src/main/java/org/hawkular/alerts/rest/AlertsHandler.java

  Log Message:
  -----------
  HWKALERTS-54 : Alerts spinning the logs with errors

WIP: Refactor alerts service into two services/beans, a pooled bean that
handles typical client interactions and queries, and a singleton devoted to
executing the engine.
- Don't use a singleton for handling potentially frequent and concurrent
  alert fetches and other client requests.
- Isolate engine exection
- Better handle the "pendingData" list wrt concurrency and perf.

Question: Do we really need/want to expose the "reload" endpoints in AlertsHandler?


  Commit: 5139ed39b5d28e1f062972e0a6b8d12f8f73c899
      https://github.com/hawkular/hawkular-alerts/commit/5139ed39b5d28e1f062972e0a6b8d12f8f73c899
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2015-06-02 (Tue, 02 Jun 2015)

  Changed paths:
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassStatement.java

  Log Message:
  -----------
  Avoid repeatedly preparing the same statements.  The Datastax driver
requires a unique statement be prepared only one time.  The pooled beans
would define the same statements repeatedly, generated log warnings.


  Commit: 3a893f8d5940af30011bac24887cf56ed73d278d
      https://github.com/hawkular/hawkular-alerts/commit/3a893f8d5940af30011bac24887cf56ed73d278d
  Author: Lucas Ponce <ponce.ballesteros at gmail.com>
  Date:   2015-06-03 (Wed, 03 Jun 2015)

  Changed paths:
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassCluster.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java

  Log Message:
  -----------
  HWKALERTS-54 Single shared session per keyspace


  Commit: 7c0ee94ece055fb88def8cf1a917a58dcf862a10
      https://github.com/hawkular/hawkular-alerts/commit/7c0ee94ece055fb88def8cf1a917a58dcf862a10
  Author: Lucas Ponce <ponce.ballesteros at gmail.com>
  Date:   2015-06-03 (Wed, 03 Jun 2015)

  Changed paths:
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassStatement.java

  Log Message:
  -----------
  HWKALERTS-54 Move prepare statements into CassStatement


  Commit: 561e8dba42ac920e4beebbd75627175960bd1c45
      https://github.com/hawkular/hawkular-alerts/commit/561e8dba42ac920e4beebbd75627175960bd1c45
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2015-06-03 (Wed, 03 Jun 2015)

  Changed paths:
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassCluster.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassStatement.java

  Log Message:
  -----------
  Merge pull request #1 from lucasponce/HWKALERTS-54-Cassandra-Reorg

Hwkalerts 54 cassandra reorg


  Commit: d8331984198245c91d7943888494c20009483d94
      https://github.com/hawkular/hawkular-alerts/commit/d8331984198245c91d7943888494c20009483d94
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2015-06-03 (Wed, 03 Jun 2015)

  Changed paths:
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassStatement.java

  Log Message:
  -----------
  Reorganize CassStatements for clarity. Queries sectioned, alphabetized, and
sometimes re-stringified. (a totally OCD-based commit)


  Commit: 059b9b79a1ebbb662be217ad82789e94c4212d1a
      https://github.com/hawkular/hawkular-alerts/commit/059b9b79a1ebbb662be217ad82789e94c4212d1a
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2015-06-03 (Wed, 03 Jun 2015)

  Changed paths:
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/AlertsEngineImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java

  Log Message:
  -----------
  Move the CassCluster shutdown to AlertsEngineImpl because it is more likely
to remain a Singleton.


  Commit: b601d00e8cc8797a7b832ad5876857dbf329f72a
      https://github.com/hawkular/hawkular-alerts/commit/b601d00e8cc8797a7b832ad5876857dbf329f72a
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2015-06-03 (Wed, 03 Jun 2015)

  Changed paths:
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/AlertsEngineImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassStatement.java

  Log Message:
  -----------
  - Perform session close in only one place
  - Move cluster shutdown back to CassDefinitionsServiceImpl
  - Remove all session stuff from AlertsEngineImpl
    - the shutdown worked from here, but since this singleton doesn't
      actually use the C* session, take it out.
- Remove also the unused keyspace and gson relate stuff from AlertsEngineImpl
- Make sure renamed statements in the prior commit to CassStatements
  are reflected in the associated variable names holding the
  PreparedStatements.  Also, for consistency, add back _BY_ segment in a
  couple of select statement names.


  Commit: db15cdbe9ce57580bdf2a2c889c8bf7d0a0d1840
      https://github.com/hawkular/hawkular-alerts/commit/db15cdbe9ce57580bdf2a2c889c8bf7d0a0d1840
  Author: Lucas Ponce <ponce.ballesteros at gmail.com>
  Date:   2015-06-03 (Wed, 03 Jun 2015)

  Changed paths:
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/services/AlertsService.java
    M hawkular-alerts-bus/src/main/java/org/hawkular/alerts/bus/listener/AlertDataListener.java
    M hawkular-alerts-bus/src/main/java/org/hawkular/alerts/bus/listener/AvailDataListener.java
    M hawkular-alerts-bus/src/main/java/org/hawkular/alerts/bus/listener/MetricDataListener.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/StandaloneAlerts.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/AlertsEngineImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassCluster.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassDefinitionsServiceImpl.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassStatement.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/DbAlertsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/DbDefinitionsServiceImpl.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/AlertsEngine.java
    M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/DbDefinitionsTest.java
    M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/DefinitionsTest.java
    M hawkular-alerts-rest/src/main/java/org/hawkular/alerts/rest/AlertsHandler.java

  Log Message:
  -----------
  Merge pull request #56 from jshaughn/hwkalerts-54

Hwkalerts 54


Compare: https://github.com/hawkular/hawkular-alerts/compare/7aa7b18c1260...db15cdbe9ce5