[Hawkular-commits] [hawkular/hawkular-alerts] 54bb50: HWKALERTS-190 Reduce response time for sendData an...

[Lucas Ponce]

  Branch: refs/heads/master
  Home:   https://github.com/hawkular/hawkular-alerts
  Commit: 54bb50e395f19ac45c0f68cda317efb1fe257d7d
      https://github.com/hawkular/hawkular-alerts/commit/54bb50e395f19ac45c0f68cda317efb1fe257d7d
  Author: Jay Shaughnessy <jshaughn at redhat.com>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data/Data.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/event/Event.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/services/AlertsService.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/AlertsEngineImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/DataDrivenGroupCacheManager.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/DroolsRulesEngineImpl.java
    R hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/IncomingDataManager.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/IncomingDataManagerImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/PartitionManagerImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/AlertsEngine.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/IncomingDataManager.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/PartitionDataListener.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/PartitionManager.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/RulesEngine.java
    M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/PerfRulesEngineTest.java
    M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/RulesEngineTest.java
    M hawkular-alerts-rest-tests/pom.xml
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/ActionsITest.groovy
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/ClusterITest.groovy
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/GroupITest.groovy
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/LifecycleITest.groovy
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/PerfSendITest.groovy

  Log Message:
  -----------
  HWKALERTS-190 Reduce response time for sendData and improve overall throughput
- Enhance IncomingDataManager to perform more up-front async work
  before passing data on to the engine.
  - add new minReportingInterval enforcement
- Help object creation/GC by using TreeSet pervasively
- Fix to make sure Data/Event comparisons involve tenantId and source
  - Introduce Data.same(other) and Event.same(other) to ensure proper logical comparisons
- Fix synchronization in AlertsEngineImpl to avoid downstream
  ConcurrentModification problems.
- Improvements to DataDrivenGroupCacheManager and PartitionManagerImpl
  - increase timeout when updating cache/changing topology so that
    waiting calls don't timeout.
  - apply READ locks where possible, to reduce waiting
- Add a bit more more warm up time for cleaner test results
- Allow more concurrency by applying LockType.READ on sendData
  and sendEvents.
  - while still protecting pendingData/Events with synchronized blocks
- Add new hawkular-alerts.data-driven-triggers-enabled option to
  optionally disable data-driven group triggers, because they
  add processing overhead (particularly with a lot of trigger manipulation)
  - default is true (enabled OOB)
  - disable for perf and cluster tests
- Remove annoying and inefficient single Data/Event signatures


  Commit: 55152efdf30b0edf90c4c7afd8631117ecddf9f3
      https://github.com/hawkular/hawkular-alerts/commit/55152efdf30b0edf90c4c7afd8631117ecddf9f3
  Author: Lucas Ponce <ponce.ballesteros at gmail.com>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data/Data.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/event/Event.java
    M hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/services/AlertsService.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/AlertsEngineImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/CassAlertsServiceImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/DataDrivenGroupCacheManager.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/DroolsRulesEngineImpl.java
    R hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/IncomingDataManager.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/IncomingDataManagerImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/impl/PartitionManagerImpl.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/AlertsEngine.java
    A hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/IncomingDataManager.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/PartitionDataListener.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/PartitionManager.java
    M hawkular-alerts-engine/src/main/java/org/hawkular/alerts/engine/service/RulesEngine.java
    M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/PerfRulesEngineTest.java
    M hawkular-alerts-engine/src/test/java/org/hawkular/alerts/engine/RulesEngineTest.java
    M hawkular-alerts-rest-tests/pom.xml
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/ActionsITest.groovy
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/ClusterITest.groovy
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/GroupITest.groovy
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/LifecycleITest.groovy
    M hawkular-alerts-rest-tests/src/test/groovy/org/hawkular/alerts/rest/PerfSendITest.groovy

  Log Message:
  -----------
  Merge pull request #246 from jshaughn/send-data

HWKALERTS-190 IncomingDataManager enhancements


Compare: https://github.com/hawkular/hawkular-alerts/compare/5f247b61a64c...55152efdf30b