[Hawkular-commits] [hawkular/hawkular-alerts] 501764: More tidying of recent displayString logic (#415)

[Jay Shaughnessy]

  Branch: refs/heads/next
  Home:   https://github.com/hawkular/hawkular-alerts
  Commit: 5017642a7298285d7fa765d5a5c26d0503a48051
      https://github.com/hawkular/hawkular-alerts/commit/5017642a7298285d7fa765d5a5c26d0503a48051
  Author: Jay Shaughnessy <jshaughn at users.noreply.github.com>
  Date:   2017-07-28 (Fri, 28 Jul 2017)

  Changed paths:
    M api/src/main/java/org/hawkular/alerts/api/json/JacksonDeserializer.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/AvailabilityCondition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/AvailabilityConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/CompareCondition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/CompareConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/Condition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/ConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/EventCondition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/EventConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/ExternalCondition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/ExternalConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/MissingCondition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/MissingConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonCondition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/NelsonConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/RateCondition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/RateConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/StringCondition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/StringConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdCondition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdRangeCondition.java
    M api/src/main/java/org/hawkular/alerts/api/model/condition/ThresholdRangeConditionEval.java
    M api/src/main/java/org/hawkular/alerts/api/model/dampening/Dampening.java

  Log Message:
  -----------
  More tidying of recent displayString logic (#415)

- remove annoying, slow and likely unnecessary updateDisplayString()
  calls from all of the Condition impls.
  - Relevant Condition fields are likely  not updated after
    construction, so don't worry about it, just make updateDisplayString()
    public and jdoc that you need to call it if you do for some bizarre
    reason explicitly set a field after construction.  The exception is
    JSON deserialization.  In that case we now update the displayString
    one time before returning the deserialized Condition (same for
    ConditionEval)
- Also, make more consistent by usingthe same logic/method names for
  both Condition and ConditionEval.