[Hawkular-dev] agent error

[Lucas Ponce]

Hi,

So, now in Hawkular, any request from client sending a Hawkular-Tenant header should respond a 400 error, am I right ?

In Hawkular Alerts we have the two scenarios:

- In Hawkular if the header exist is simply overwritten with the tenant injected by accounts, I can change that to return a 400 as similar as Metrics is doing now.

- In standalone scenarions, clients are expected to use Hawkular-Tenant header to idenfity the tenant. This has not changed if I read correctly.

Thanks,
Lucas

----- Original Message -----
> From: "Thomas Segismont" <tsegismo at redhat.com>
> To: hawkular-dev at lists.jboss.org
> Sent: Friday, January 29, 2016 10:00:42 AM
> Subject: Re: [Hawkular-dev] agent error
> 
> This is one part of the problems I talked about yesterday in the thread
> "Metrics protected by accounts: agent should be updated"
> 
> Too bad you missed it ;-)
> 
> WRT the 400 error, the response has a pretty clear body text, so to me
> it's fine to keep the security check.
> 
> Le 29/01/2016 09:41, Juraci Paixão Kröhling a écrit :
> > Debugging it here, it seems that the Agent is sending a Hawkular-Tenant
> > header. IIRC, Metrics now blocks requests with that, as the tenant is
> > defined by Accounts[1]. Perhaps metrics could be a bit forgiving at
> > first, adding a WARN to the logs for a couple of weeks?
> >
> > I would also recommend adding the following to
> > MetricsOnlyStorageAdapter[2] to make it easier to see what's going on:
> >
> > response.body().source().readUtf8();
> >
> > When debugging it here, the code above returned this:
> > {"errorMsg":"The Hawkular-Tenant header is not allowed. The tenant is
> > determined from the credentials supplied with the request"}
> >
> > 1 - https://git.io/vzbs8
> > 2 - https://git.io/vzbsU
> >
> > - Juca.
> >
> >
> > On 28.01.2016 22:55, John Mazzitelli wrote:
> >> I wanted to verify this PR fixes my problem storing metrics:
> >>
> >> https://github.com/hawkular/hawkular-metrics/pull/438
> >>
> >> So I pulled hawkular-metrics, built, and then built kettle using metrics
> >> 0.12.0-SNAPSHOT.
> >>
> >> But now it is worse - even using username/password, agent can't store any
> >> metric data. I am wondering if the REST API changed in metrics? or if
> >> this PR actually broke something. The error makes it seem like the REST
> >> calls that did work on 0.11.0 no longer do, but I don't know if its an
> >> auth issue or a REST/JSON issue:
> >>
> >> 16:42:43,703 ERROR
> >> [org.hawkular.agent.monitor.storage.MetricsOnlyStorageAdapter] (OkHttp
> >> http://127.0.0.1:8080/hawkular/metrics/metrics/data) HAWKMONITOR010010:
> >> Failed to store metric data:
> >> {"counters":[],"availabilities":[],"gauges":[{"data":[{"value":0.0,"timestamp":1454017363117}],"id":"MI~R~[6f9d3775-410f-4f9a-bd76-cc6e9f2979c2/Local~/subsystem=messaging-activemq/server=default/jms-topic=HawkularAccountsEvents]~MT~JMS
> >> Topic Metrics~Message Count"}]}: java.io.IOException: status-code=[400],
> >> reason=[Bad Request],
> >> url=[http://127.0.0.1:8080/hawkular/metrics/metrics/data]
> >>
> >> I see no errors coming from accounts or metrics - this is the only error I
> >> get (its from the agent logging the error after attempting to make a REST
> >> request to metrics to store data)
> >> _______________________________________________
> >> hawkular-dev mailing list
> >> hawkular-dev at lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/hawkular-dev
> >>
> > _______________________________________________
> > hawkular-dev mailing list
> > hawkular-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hawkular-dev
> >
> 
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>