[hibernate-commits] Hibernate SVN: r10626 - trunk/HibernateExt/tools/src/test/org/hibernate/tool

[hibernate-commits at lists.jboss.org]

Author: max.andersen at jboss.com
Date: 2006-10-19 13:11:51 -0400 (Thu, 19 Oct 2006)
New Revision: 10626

Modified:
   trunk/HibernateExt/tools/src/test/org/hibernate/tool/JDBCMetaDataBinderTestCase.java
Log:
fix possible statement leak in junittest

Modified: trunk/HibernateExt/tools/src/test/org/hibernate/tool/JDBCMetaDataBinderTestCase.java
===================================================================
--- trunk/HibernateExt/tools/src/test/org/hibernate/tool/JDBCMetaDataBinderTestCase.java	2006-10-19 17:11:24 UTC (rev 10625)
+++ trunk/HibernateExt/tools/src/test/org/hibernate/tool/JDBCMetaDataBinderTestCase.java	2006-10-19 17:11:51 UTC (rev 10626)
@@ -76,6 +76,7 @@
 			return; // don't do anything to avoid crippled db
 		}
 		
+		Statement statement = null;
 		Connection con = null;
         try {
         	
@@ -85,10 +86,11 @@
 		storesLowerCaseIdentifiers = metaData.storesLowerCaseIdentifiers();
         storesUpperCaseIdentifiers = metaData.storesUpperCaseIdentifiers();
         
-		Statement statement = con.createStatement();
 		
+		statement = con.createStatement();
 		
 		
+		
 		for (int i = 0; i < sqls.length; i++) {
 			String ddlsql = sqls[i];
 			System.out.println("Execute: " + ddlsql);
@@ -104,10 +106,11 @@
             	}
             }
 		}
-		if (statement!=null) statement.close();
 		con.commit();
         } finally {
+        	if (statement!=null) statement.close();
         	testSettings.getConnectionProvider().closeConnection(con);
+        	
         }
 	}