[hibernate-commits] Hibernate SVN: r11517 - in trunk/HibernateExt/search/src/java/org/hibernate/search: query and 1 other directory.

[hibernate-commits at lists.jboss.org]

Author: epbernard
Date: 2007-05-13 17:21:11 -0400 (Sun, 13 May 2007)
New Revision: 11517

Modified:
   trunk/HibernateExt/search/src/java/org/hibernate/search/bridge/String2FieldBridgeAdaptor.java
   trunk/HibernateExt/search/src/java/org/hibernate/search/query/FullTextQueryImpl.java
Log:
Minor TODO

Modified: trunk/HibernateExt/search/src/java/org/hibernate/search/bridge/String2FieldBridgeAdaptor.java
===================================================================
--- trunk/HibernateExt/search/src/java/org/hibernate/search/bridge/String2FieldBridgeAdaptor.java	2007-05-10 12:21:05 UTC (rev 11516)
+++ trunk/HibernateExt/search/src/java/org/hibernate/search/bridge/String2FieldBridgeAdaptor.java	2007-05-13 21:21:11 UTC (rev 11517)
@@ -20,6 +20,7 @@
 	public void set(String name, Object value, Document document, Field.Store store, Field.Index index, Float boost) {
 		String indexedString = stringBridge.objectToString( value );
 		//Do not add fields on empty strings, seems a sensible default in most situations
+		//TODO if Store, probably also save empty ones
 		if ( StringHelper.isNotEmpty( indexedString ) ) {
 			Field field = new Field( name, indexedString, store, index );
 			if ( boost != null ) field.setBoost( boost );

Modified: trunk/HibernateExt/search/src/java/org/hibernate/search/query/FullTextQueryImpl.java
===================================================================
--- trunk/HibernateExt/search/src/java/org/hibernate/search/query/FullTextQueryImpl.java	2007-05-10 12:21:05 UTC (rev 11516)
+++ trunk/HibernateExt/search/src/java/org/hibernate/search/query/FullTextQueryImpl.java	2007-05-13 21:21:11 UTC (rev 11517)
@@ -112,7 +112,7 @@
 	public ScrollableResults scroll() throws HibernateException {
 		//keep the searcher open until the resultset is closed
 		SearchFactory searchFactory = ContextHelper.getSearchFactoryBySFI( session );
-		;
+		
 		//find the directories
 		Searcher searcher = buildSearcher( searchFactory );
 		//FIXME: handle null searcher
@@ -261,6 +261,7 @@
 		int dirNbr = directories.size();
 		if ( dirNbr > 1 ) {
 			try {
+				//TODO IndexSearcher on top of MultiReader
 				IndexSearcher[] searchers = new IndexSearcher[dirNbr];
 				Iterator<Directory> it = directories.iterator();
 				for ( int index = 0; index < dirNbr; index++ ) {