[hibernate-commits] Hibernate SVN: r14099 - core/trunk/core/src/main/java/org/hibernate/id.

[hibernate-commits at lists.jboss.org]

Author: gbadner
Date: 2007-10-18 02:20:04 -0400 (Thu, 18 Oct 2007)
New Revision: 14099

Modified:
   core/trunk/core/src/main/java/org/hibernate/id/IdentityGenerator.java
Log:
HHH-1312 : Unclosed ResultSet when using Identity


Modified: core/trunk/core/src/main/java/org/hibernate/id/IdentityGenerator.java
===================================================================
--- core/trunk/core/src/main/java/org/hibernate/id/IdentityGenerator.java	2007-10-18 06:17:56 UTC (rev 14098)
+++ core/trunk/core/src/main/java/org/hibernate/id/IdentityGenerator.java	2007-10-18 06:20:04 UTC (rev 14099)
@@ -70,10 +70,19 @@
 
 		public Serializable executeAndExtract(PreparedStatement insert) throws SQLException {
 			insert.executeUpdate();
-			return IdentifierGeneratorFactory.getGeneratedIdentity(
-					insert.getGeneratedKeys(),
-			        persister.getIdentifierType()
-			);
+			ResultSet rs = null;
+			try {
+				rs = insert.getGeneratedKeys();
+				return IdentifierGeneratorFactory.getGeneratedIdentity(
+						rs,
+						persister.getIdentifierType()
+				);
+			}
+			finally {
+				if ( rs != null ) {
+					rs.close();
+				}
+			}
 		}
 	}