[hibernate-commits] Hibernate SVN: r14287 - in branches/Branch_3_2/HibernateExt/tools/src: test/org/hibernate/tool/ide/completion and 1 other directory.

hibernate-commits at lists.jboss.org hibernate-commits at lists.jboss.org
Fri Jan 18 14:44:33 EST 2008


Author: max.andersen at jboss.com
Date: 2008-01-18 14:44:33 -0500 (Fri, 18 Jan 2008)
New Revision: 14287

Modified:
   branches/Branch_3_2/HibernateExt/tools/src/java/org/hibernate/tool/ide/completion/ConfigurationCompletion.java
   branches/Branch_3_2/HibernateExt/tools/src/test/org/hibernate/tool/ide/completion/ModelCompletionTest.java
Log:
Made code completion for HQL (previous comment were wrong ;) case insensitive (http://jira.jboss.com/jira/browse/JBIDE-1424)

Modified: branches/Branch_3_2/HibernateExt/tools/src/java/org/hibernate/tool/ide/completion/ConfigurationCompletion.java
===================================================================
--- branches/Branch_3_2/HibernateExt/tools/src/java/org/hibernate/tool/ide/completion/ConfigurationCompletion.java	2008-01-18 19:22:46 UTC (rev 14286)
+++ branches/Branch_3_2/HibernateExt/tools/src/java/org/hibernate/tool/ide/completion/ConfigurationCompletion.java	2008-01-18 19:44:33 UTC (rev 14287)
@@ -331,7 +331,7 @@
     }
 	
 	private void findMatchingWords(int cursorPosition, String prefix, String[] words, int kind, IHQLCompletionRequestor hcc) {
-		int i = Arrays.binarySearch(words, prefix);
+		int i = Arrays.binarySearch(words, prefix.toLowerCase());
 		if(i<0) {
 			i = Math.abs(i+1);
 		}

Modified: branches/Branch_3_2/HibernateExt/tools/src/test/org/hibernate/tool/ide/completion/ModelCompletionTest.java
===================================================================
--- branches/Branch_3_2/HibernateExt/tools/src/test/org/hibernate/tool/ide/completion/ModelCompletionTest.java	2008-01-18 19:22:46 UTC (rev 14286)
+++ branches/Branch_3_2/HibernateExt/tools/src/test/org/hibernate/tool/ide/completion/ModelCompletionTest.java	2008-01-18 19:44:33 UTC (rev 14287)
@@ -145,6 +145,17 @@
     	
     	assertEquals(1, completionProposals.length);
     	assertEquals("x", completionProposals[0].getCompletion());
+    	
+    	hcc.clear();
+    	cc.getMatchingKeywords("FR", 3, hcc);
+    	completionProposals = hcc.getCompletionProposals();
+    	assertEquals(1, completionProposals.length);
+    	
+    	hcc.clear();
+    	cc.getMatchingFunctions( "MA", 2, hcc );
+    	completionProposals = hcc.getCompletionProposals();
+    	assertEquals(1, completionProposals.length);
+    	
     }
 
     public void testUnmappedClassFields() {




More information about the hibernate-commits mailing list