[hibernate-commits] Hibernate SVN: r16001 - in validator/trunk/hibernate-validator/src: test/java/org/hibernate/validation/bootstrap and 1 other directory.

[hibernate-commits at lists.jboss.org]

Author: hardy.ferentschik
Date: 2009-02-19 09:13:19 -0500 (Thu, 19 Feb 2009)
New Revision: 16001

Modified:
   validator/trunk/hibernate-validator/src/main/java/org/hibernate/validation/engine/ConfigurationImpl.java
   validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/bootstrap/ValidationTest.java
Log:
Fixed some todos

Modified: validator/trunk/hibernate-validator/src/main/java/org/hibernate/validation/engine/ConfigurationImpl.java
===================================================================
--- validator/trunk/hibernate-validator/src/main/java/org/hibernate/validation/engine/ConfigurationImpl.java	2009-02-19 14:08:10 UTC (rev 16000)
+++ validator/trunk/hibernate-validator/src/main/java/org/hibernate/validation/engine/ConfigurationImpl.java	2009-02-19 14:13:19 UTC (rev 16001)
@@ -44,9 +44,8 @@
 		Version.touch();
 	}
 
-	//FIXME not sure why it is like that. We should cache these instances somehow. Static?
-	private final MessageInterpolator defaultMessageInterpolator = new ResourceBundleMessageInterpolator();
-	private final TraversableResolver defaultTraversableResolver = new DefaultTraversableResolver();
+	private static final MessageInterpolator defaultMessageInterpolator = new ResourceBundleMessageInterpolator();
+	private static final TraversableResolver defaultTraversableResolver = new DefaultTraversableResolver();
 
 	private MessageInterpolator messageInterpolator;
 	private ConstraintValidatorFactory constraintValidatorFactory = new ConstraintValidatorFactoryImpl();

Modified: validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/bootstrap/ValidationTest.java
===================================================================
--- validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/bootstrap/ValidationTest.java	2009-02-19 14:08:10 UTC (rev 16000)
+++ validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/bootstrap/ValidationTest.java	2009-02-19 14:13:19 UTC (rev 16001)
@@ -110,8 +110,8 @@
 		ConstraintViolation<Customer> constraintViolation = constraintViolations.iterator().next();
 		assertEquals( "Wrong message", "may not be null", constraintViolation.getMessage() );
 
-		//FIXME nothing guarantee that a configuration can be reused
 		// now we modify the configuration, get a new factory and valiator and try again
+		configuration = Validation.byDefaultProvider().configure();
 		configuration.messageInterpolator(
 				new MessageInterpolator() {
 					public String interpolate(String message, ConstraintDescriptor constraintDescriptor, Object value) {