[hibernate-commits] [hibernate/hibernate-search] e912fc: HSEARCH-780 Fix for @IndexedEmbedded PersistentSet...

[noreply at github.com]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search

  Commit: e912fc74ec56cc9af47a162df70648139879fdbf
      https://github.com/hibernate/hibernate-search/commit/e912fc74ec56cc9af47a162df70648139879fdbf
  Author: Samppa Saarela <samppa.saarela at mysema.com>
  Date:   2011-06-21 (Tue, 21 Jun 2011)

  Changed paths:
    M hibernate-search/src/main/java/org/hibernate/search/engine/AbstractDocumentBuilder.java
  A hibernate-search/src/test/java/org/hibernate/search/test/embedded/AbstractProduct.java
  A hibernate-search/src/test/java/org/hibernate/search/test/embedded/Book.java
  M hibernate-search/src/test/java/org/hibernate/search/test/embedded/EmbeddedTest.java
  A hibernate-search/src/test/java/org/hibernate/search/test/embedded/ProductFeature.java

  Log Message:
  -----------
  HSEARCH-780 Fix for @IndexedEmbedded PersistentSet dirty analysis in a super class

Wrong collectionRole is used for collection exclusion analysis in
FullTextIndexEventListener.processCollectionEvent > AbstractDocumentBuilder.isCollectionRoleExcluded check.

A PersistentSet of an abstract superclass has it's collection role bound to the superclass, but AbstractDocumentBuilder's
indexedEmbeddedCollectionRoles contains roles that are bound to a specific subclass. Thus when the contents of a collection
in superclass are changed, Hibernate Search fails to re-index the change as the collection gets excluded.


  Commit: b6b454038fb9e56068e7df811a2c239771ecefa0
      https://github.com/hibernate/hibernate-search/commit/b6b454038fb9e56068e7df811a2c239771ecefa0
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2011-06-21 (Tue, 21 Jun 2011)

  Changed paths:
    M hibernate-search/src/main/java/org/hibernate/search/engine/AbstractDocumentBuilder.java
  M hibernate-search/src/test/java/org/hibernate/search/test/embedded/ProductFeature.java

  Log Message:
  -----------
  HSEARCH-780 Fix collection role for contained in too


Compare: https://github.com/hibernate/hibernate-search/compare/5cd16e6...b6b4540