[hibernate-commits] [hibernate/hibernate-validator] ef8ec2: HV-809 Improving ModCheck

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: ef8ec2d8fdd3d761eab39dac70089aca0be2cffd
      https://github.com/hibernate/hibernate-validator/commit/ef8ec2d8fdd3d761eab39dac70089aca0be2cffd
  Author: Victor Rezende dos Santos <victor.rds at outlook.com>
  Date:   2013-08-14 (Wed, 14 Aug 2013)

  Changed paths:
    M annotation-processor/src/main/java/org/hibernate/validator/ap/util/TypeNames.java
    M annotation-processor/src/test/java/org/hibernate/validator/ap/testmodel/customconstraints/HibernateValidatorProvidedCustomConstraints.java
    M engine/src/main/java/org/hibernate/validator/constraints/CreditCardNumber.java
    A engine/src/main/java/org/hibernate/validator/constraints/Mod10Check.java
    A engine/src/main/java/org/hibernate/validator/constraints/Mod11Check.java
    M engine/src/main/java/org/hibernate/validator/constraints/br/CNPJ.java
    M engine/src/main/java/org/hibernate/validator/constraints/br/CPF.java
    M engine/src/main/java/org/hibernate/validator/constraints/br/TituloEleitoral.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/Mod10CheckValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/Mod11CheckValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckCommonValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/ConstraintHelper.java
    M engine/src/main/java/org/hibernate/validator/internal/util/ModUtil.java
    M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java
    A engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/Mod10CheckValidatorTest.java
    A engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/Mod11CheckValidatorTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/ModCheckValidatorTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/util/ModUtilTest.java

  Log Message:
  -----------
  HV-809 Improving ModCheck

- Separates @ModCHeck in two new constraints with own options.

- Creates @Mod10Check constraint and @Mod10CheckValidator. Adds support for the weight option (second multiplier) and multiplier now defaults to 2

- Creates @Mod11Check constraint and @Mod11CheckValidator. Adds support for non-digit character for check digit using treatCheck10As() and treatCheck11As(), adds an option reverseOrder to alter the processing order of the digits

- Creates the abstract ModCheckCommonValidator with all shared options and common behaviors of ModXXCheck constraints, imposes the implementation of the method isCheckDigitValid(List<Integer>, char), instead of overriding isValid() in each validator class

- ModCheckValidator now extends ModCheckCommonValidator

- Adds @Mod10Check and @Mod11Check in TypeNames and to HibernateValidatorProvidedCustomConstraints

- Adds @Mod10Check, @Mod11Check, @Mod10CheckValidator and @Mod11CheckValidator to ConstraintHelper

- ModUtil support for the new mod10 weight option

- Updates @CPF, @CNPJ, @TituloEleitoraand @CreditCardNumber to use new @ModXXCheck constraints instead of old @ModCheck

- Adds tests for all the new classes, updates ModUtilTest.


  Commit: 83bb6ff7f0a7234e6a35382d0fab9779644624a7
      https://github.com/hibernate/hibernate-validator/commit/83bb6ff7f0a7234e6a35382d0fab9779644624a7
  Author: Victor Rezende dos Santos <victor.rds at outlook.com>
  Date:   2013-08-14 (Wed, 14 Aug 2013)

  Changed paths:
    M annotation-processor/src/main/java/org/hibernate/validator/ap/util/ConstraintHelper.java
    M annotation-processor/src/test/java/org/hibernate/validator/ap/ConstraintValidationProcessorTest.java
    M annotation-processor/src/test/java/org/hibernate/validator/ap/testmodel/customconstraints/HibernateValidatorProvidedCustomConstraints.java
    M engine/src/main/java/org/hibernate/validator/constraints/Mod10Check.java
    M engine/src/main/java/org/hibernate/validator/constraints/Mod11Check.java
    M engine/src/main/java/org/hibernate/validator/constraints/ModCheck.java
    M engine/src/main/java/org/hibernate/validator/constraints/br/CPF.java
    M engine/src/main/java/org/hibernate/validator/constraints/br/TituloEleitoral.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/Mod10CheckValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/Mod11CheckValidator.java
    A engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckBase.java
    R engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckCommonValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/util/ModUtil.java
    M engine/src/main/resources/org/hibernate/validator/ValidationMessages.properties
    M engine/src/main/resources/org/hibernate/validator/ValidationMessages_pt_BR.properties
    M engine/src/test/java/org/hibernate/validator/test/constraints/br/CPFValidatorTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/Mod11CheckValidatorTest.java
    M engine/src/test/java/org/hibernate/validator/test/internal/util/ModUtilTest.java

  Log Message:
  -----------
  HV-809 Improving ModCheck updates

Updating code based on Pull Request #268 feedback

- Mod11Check changes reverseOrder type from boolean to ProcessingDirection enum

- Mark @ModCheck and ModCheckValidator as @Deprecated

- Renaming ModCheckCommonValidator to ModCheckBase

- Added messages templates for ModCheck constraints on ValidationMessages.properties

- Updated pt-BR messages

- Fix code identation and style

- Fix HV-5-SNAPSHOT #325 FAILURE


  Commit: c4b18221e2cfa56579be6ab2e4ba2f998c7e8026
      https://github.com/hibernate/hibernate-validator/commit/c4b18221e2cfa56579be6ab2e4ba2f998c7e8026
  Author: Gunnar Morling <gunnar.morling at googlemail.com>
  Date:   2013-08-14 (Wed, 14 Aug 2013)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/constraints/Mod11Check.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/Mod11CheckValidator.java

  Log Message:
  -----------
  HV-809 Clarifying purpose of "processingOrder" attribute


  Commit: ac6188b14f1f7cb8a7f64a0386c40fa549ef57b9
      https://github.com/hibernate/hibernate-validator/commit/ac6188b14f1f7cb8a7f64a0386c40fa549ef57b9
  Author: Victor Rezende dos Santos <victor.rds at outlook.com>
  Date:   2013-08-21 (Wed, 21 Aug 2013)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/constraints/Mod11Check.java
    M engine/src/main/java/org/hibernate/validator/constraints/br/CNPJ.java
    M engine/src/main/java/org/hibernate/validator/constraints/br/CPF.java
    M engine/src/main/java/org/hibernate/validator/constraints/br/TituloEleitoral.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/Mod10CheckValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/Mod11CheckValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckBase.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/util/ModUtil.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/Mod11CheckValidatorTest.java

  Log Message:
  -----------
  HV-809 Code clean up:

Based on the chages done by @gunnarmorling and feedback from #270

- ModCheckBase: removed multiplier attribute

- Mod11Check: change multiplier to threshold, threshold now defaults to
Integer.MAX_VALUE

- Mod10Check: added multiplier option since is no longer present in
ModCheckBase.

- Update CPF, CNPJ and TituloEleitoral constraints

- ModUtil: Changed the variable names for better understanding


  Commit: 7a23e60fe7981f4397f24e1200af1940759605b4
      https://github.com/hibernate/hibernate-validator/commit/7a23e60fe7981f4397f24e1200af1940759605b4
  Author: Gunnar Morling <gunnar.morling at googlemail.com>
  Date:   2013-08-21 (Wed, 21 Aug 2013)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/constraints/Mod10Check.java
    M engine/src/main/java/org/hibernate/validator/constraints/Mod11Check.java
    M engine/src/main/java/org/hibernate/validator/constraints/br/CNPJ.java
    M engine/src/main/java/org/hibernate/validator/constraints/br/CPF.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/Mod10CheckValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckBase.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/util/ModUtil.java

  Log Message:
  -----------
  HV-809 Changing default value of @Mod11Check#ignoreNonDigitCharacters() to false to support 'X' as check digit by default; Misc. style, formatting and comment improvements


  Commit: b93885e1be64513dc5a44b5c3a15e8abf2535893
      https://github.com/hibernate/hibernate-validator/commit/b93885e1be64513dc5a44b5c3a15e8abf2535893
  Author: Gunnar Morling <gunnar.morling at googlemail.com>
  Date:   2013-08-21 (Wed, 21 Aug 2013)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/Mod10CheckValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/Mod11CheckValidator.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckBase.java
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckValidator.java

  Log Message:
  -----------
  HV-809 Misc. improvements: Avoiding repeated stripping of non-digit characters; Making some members private; Compiling regex pattern for re-use


  Commit: 149664289538e24cc59fdcfafb07f3b6a39d4456
      https://github.com/hibernate/hibernate-validator/commit/149664289538e24cc59fdcfafb07f3b6a39d4456
  Author: Gunnar Morling <gunnar.morling at googlemail.com>
  Date:   2013-08-21 (Wed, 21 Aug 2013)

  Changed paths:
    M documentation/src/main/docbook/en-US/modules/bean-constraints.xml

  Log Message:
  -----------
  HV-809 Updating reference documentation


  Commit: e2c14d812c604ecf9b8fc790cc14d0abb2238dd5
      https://github.com/hibernate/hibernate-validator/commit/e2c14d812c604ecf9b8fc790cc14d0abb2238dd5
  Author: Gunnar Morling <gunnar.morling at googlemail.com>
  Date:   2013-08-21 (Wed, 21 Aug 2013)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/ModCheckBase.java
    M engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/Mod10CheckValidatorTest.java

  Log Message:
  -----------
  HV-809 Making constraint work if only character range but no check digit index is given


Compare: https://github.com/hibernate/hibernate-validator/compare/3ace852226f0...e2c14d812c60