[hibernate-commits] [hibernate/hibernate-orm] 4d04df: HHH-8207 - Locale conversion is broken

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-orm
  Commit: 4d04dfc0888bbb59c5a99d5fe13a2d37184eb28d
      https://github.com/hibernate/hibernate-orm/commit/4d04dfc0888bbb59c5a99d5fe13a2d37184eb28d
  Author: Steve Ebersole <steve at hibernate.org>
  Date:   2013-05-01 (Wed, 01 May 2013)

  Changed paths:
    A hibernate-core/src/test/java/org/hibernate/test/type/AttributeConverterTest.java
    A hibernate-core/src/test/java/org/hibernate/test/type/BasicTypeRegistryTest.java
    A hibernate-core/src/test/java/org/hibernate/test/type/TypeTest.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/AbstractDescriptorTest.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BigDecimalDescriptorTest.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BigIntegerDescriptorTest.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BlobDescriptorTest.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/BooleanDescriptorTest.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/LocaleTypeDescriptorTest.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/StringDescriptorTest.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/sql/PreparedStatementProxy.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/sql/ResultSetProxy.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/sql/StringClobImpl.java
    A hibernate-core/src/test/java/org/hibernate/test/type/descriptor/sql/StringValueMappingTest.java
    R hibernate-core/src/test/java/org/hibernate/type/AttributeConverterTest.java
    R hibernate-core/src/test/java/org/hibernate/type/BasicTypeRegistryTest.java
    R hibernate-core/src/test/java/org/hibernate/type/TypeTest.java
    R hibernate-core/src/test/java/org/hibernate/type/descriptor/java/AbstractDescriptorTest.java
    R hibernate-core/src/test/java/org/hibernate/type/descriptor/java/BigDecimalDescriptorTest.java
    R hibernate-core/src/test/java/org/hibernate/type/descriptor/java/BigIntegerDescriptorTest.java
    R hibernate-core/src/test/java/org/hibernate/type/descriptor/java/BlobDescriptorTest.java
    R hibernate-core/src/test/java/org/hibernate/type/descriptor/java/BooleanDescriptorTest.java
    R hibernate-core/src/test/java/org/hibernate/type/descriptor/java/StringDescriptorTest.java
    R hibernate-core/src/test/java/org/hibernate/type/descriptor/sql/PreparedStatementProxy.java
    R hibernate-core/src/test/java/org/hibernate/type/descriptor/sql/ResultSetProxy.java
    R hibernate-core/src/test/java/org/hibernate/type/descriptor/sql/StringClobImpl.java
    R hibernate-core/src/test/java/org/hibernate/type/descriptor/sql/StringValueMappingTest.java

  Log Message:
  -----------
  HHH-8207 - Locale conversion is broken


  Commit: b39fdbf1f8bfaf0e717deb5b8530bbe52534f665
      https://github.com/hibernate/hibernate-orm/commit/b39fdbf1f8bfaf0e717deb5b8530bbe52534f665
  Author: Christian Beikov <christian.beikov at gmail.com>
  Date:   2013-05-01 (Wed, 01 May 2013)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocaleTypeDescriptor.java

  Log Message:
  -----------
  Fix string to locale conversion

The original implementation didn't care about leading underscores. StringTokenizer skips leading separators which is actually wrong. new Locale("", "XX").toString() produces "_XX" which can't be converted back to the same locale with the original implementation.


  Commit: 2b20197249e2e94bc22b6d1be54b28458e36211c
      https://github.com/hibernate/hibernate-orm/commit/2b20197249e2e94bc22b6d1be54b28458e36211c
  Author: Steve Ebersole <steve at hibernate.org>
  Date:   2013-05-01 (Wed, 01 May 2013)

  Changed paths:
    M hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocaleTypeDescriptor.java
    M hibernate-core/src/test/java/org/hibernate/test/type/descriptor/java/LocaleTypeDescriptorTest.java

  Log Message:
  -----------
  HHH-8207 - Locale conversion is broken


Compare: https://github.com/hibernate/hibernate-orm/compare/a1d190d6748e...2b20197249e2