[hibernate-commits] [hibernate/hibernate-ogm] 84d9c6: OGM-767 Copy batching classes from ORM as is

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-ogm
  Commit: 84d9c68545522a6bd35499e9ddd26654b790f84e
      https://github.com/hibernate/hibernate-ogm/commit/84d9c68545522a6bd35499e9ddd26654b790f84e
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    A core/src/main/java/org/hibernate/ogm/loader/entity/impl/BatchingEntityLoader.java
    A core/src/main/java/org/hibernate/ogm/loader/entity/impl/BatchingEntityLoaderBuilder.java
    A core/src/main/java/org/hibernate/ogm/loader/entity/impl/PaddedBatchingEntityLoaderBuilder.java

  Log Message:
  -----------
  OGM-767 Copy batching classes from ORM as is


  Commit: 85390052dec9cd15a76b96139588e7371b1970dc
      https://github.com/hibernate/hibernate-ogm/commit/85390052dec9cd15a76b96139588e7371b1970dc
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    A core/src/main/java/org/hibernate/ogm/loader/entity/impl/BatchableEntityLoader.java
    M core/src/main/java/org/hibernate/ogm/loader/entity/impl/BatchingEntityLoader.java
    M core/src/main/java/org/hibernate/ogm/loader/entity/impl/BatchingEntityLoaderBuilder.java
    M core/src/main/java/org/hibernate/ogm/loader/entity/impl/PaddedBatchingEntityLoaderBuilder.java

  Log Message:
  -----------
  OGM-767 Add flexibility to batch fetching ORM engine

Disabled all but one strategy for the MVP
Introduce ability to customize how the inner loader is built
as OGM and ORM have different loaders.
Introduce notion of BatchableEntityLoader to abstract OgmLoader,
the legacy EntityLoader and plan.EntityLoader.
Methods of this interface is to be moved to UniqueEntityLoader
when moving things back to ORM.


  Commit: 76a094c63840f20462a8100e73ee12058fd01b72
      https://github.com/hibernate/hibernate-ogm/commit/76a094c63840f20462a8100e73ee12058fd01b72
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M core/src/main/java/org/hibernate/ogm/loader/entity/impl/BatchingEntityLoaderBuilder.java
    M core/src/main/java/org/hibernate/ogm/loader/entity/impl/PaddedBatchingEntityLoaderBuilder.java

  Log Message:
  -----------
  OGM-767 Offer ability to customize inner entity loader builder


  Commit: f7f2ee0878d3b75e54a9fe8e0d5b139be5cffceb
      https://github.com/hibernate/hibernate-ogm/commit/f7f2ee0878d3b75e54a9fe8e0d5b139be5cffceb
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M core/src/main/java/org/hibernate/ogm/hibernatecore/impl/BackendCustomLoader.java
    A core/src/main/java/org/hibernate/ogm/loader/entity/impl/OgmBatchableEntityLoaderBuilder.java
    M core/src/main/java/org/hibernate/ogm/loader/impl/OgmLoader.java
    M core/src/main/java/org/hibernate/ogm/massindex/impl/TupleIndexer.java
    M core/src/main/java/org/hibernate/ogm/persister/impl/OgmEntityPersister.java
    M core/src/main/java/org/hibernate/ogm/query/impl/OgmQueryLoader.java
    M core/src/main/java/org/hibernate/ogm/util/impl/Log.java
    M core/src/test/java/org/hibernate/ogm/backendtck/loader/LoaderFromTupleTest.java

  Log Message:
  -----------
  OGM-767 Use batch loaders in OgmEntityPersister

Add support for accepting several ids in OgmLoader (for entities).
Make OgmEntityPersister use the batch fetching framework to build batching loaders.
Adapt OgmLoader creators to instead get their instances from OgmEntityPersister


  Commit: 9568e9b66bba7d0059ad37e82766dbd8876e7477
      https://github.com/hibernate/hibernate-ogm/commit/9568e9b66bba7d0059ad37e82766dbd8876e7477
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    A core/src/test/java/org/hibernate/ogm/test/batchfetching/BatchFetchingTest.java
    A core/src/test/java/org/hibernate/ogm/test/batchfetching/Floor.java
    A core/src/test/java/org/hibernate/ogm/test/batchfetching/Tower.java
    A core/src/test/java/org/hibernate/ogm/test/batchfetching/package-info.java

  Log Message:
  -----------
  OGM-767 Add test for entity batch fetching


  Commit: 7458de100febaf7d244b7f30be6f6999b98b18a0
      https://github.com/hibernate/hibernate-ogm/commit/7458de100febaf7d244b7f30be6f6999b98b18a0
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M core/src/main/java/org/hibernate/ogm/jdbc/impl/TupleAsMapResultSet.java
    M core/src/main/java/org/hibernate/ogm/loader/impl/OgmLoader.java
    M core/src/test/java/org/hibernate/ogm/test/batchfetching/BatchFetchingTest.java

  Log Message:
  -----------
  OGM-767 Load elements of collection in two phases to build the batch fetching queue


  Commit: 8fb0d5da297a234555eed61c28b8e94d461e28d5
      https://github.com/hibernate/hibernate-ogm/commit/8fb0d5da297a234555eed61c28b8e94d461e28d5
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M core/src/main/java/org/hibernate/ogm/dialect/impl/ForwardingGridDialect.java
    M core/src/main/java/org/hibernate/ogm/dialect/impl/GridDialectLogger.java
    A core/src/main/java/org/hibernate/ogm/dialect/impl/MultigetGridDialectInitiator.java
    A core/src/main/java/org/hibernate/ogm/dialect/multiget/spi/MultigetGridDialect.java
    M core/src/main/java/org/hibernate/ogm/loader/impl/OgmLoader.java
    M core/src/main/java/org/hibernate/ogm/service/impl/OgmIntegrator.java
    M core/src/test/java/org/hibernate/ogm/utils/InvokedOperationsLoggingDialect.java

  Log Message:
  -----------
  OGM-767 Introduce and make use of MultigetGridDialect facet

No dialect is currently making use of it


  Commit: 355cd3b30c9881384bdc26c77d928622b8d71a48
      https://github.com/hibernate/hibernate-ogm/commit/355cd3b30c9881384bdc26c77d928622b8d71a48
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M core/src/main/java/org/hibernate/ogm/loader/entity/impl/BatchingEntityLoaderBuilder.java
    A core/src/main/java/org/hibernate/ogm/loader/entity/impl/DynamicBatchingEntityLoaderBuilder.java
    M core/src/main/java/org/hibernate/ogm/loader/entity/impl/OgmBatchableEntityLoaderBuilder.java

  Log Message:
  -----------
  OGM-767 Add support for dynamic entity loader


  Commit: 686dc8705cb88b3a9d709659a0d16fe659ce5e21
      https://github.com/hibernate/hibernate-ogm/commit/686dc8705cb88b3a9d709659a0d16fe659ce5e21
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M core/src/test/java/org/hibernate/ogm/test/batchfetching/BatchFetchingTest.java

  Log Message:
  -----------
  OGM-767 Remove logs from tests


  Commit: 91adb76ffa5ace13f95217e10dd0e9c2b5b1faa1
      https://github.com/hibernate/hibernate-ogm/commit/91adb76ffa5ace13f95217e10dd0e9c2b5b1faa1
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M core/src/main/java/org/hibernate/ogm/datastore/map/impl/MapDatastoreProvider.java
    M core/src/main/java/org/hibernate/ogm/datastore/map/impl/MapDialect.java
    M core/src/main/java/org/hibernate/ogm/persister/impl/OgmEntityPersister.java
    M core/src/test/java/org/hibernate/ogm/test/batchfetching/BatchFetchingTest.java

  Log Message:
  -----------
  OGM-767 Disable batch framework if the dialect does not support MultigetGridDialect

This avoid skewing the ORM fetch statistics


  Commit: 457591db360eb0616164c76ffb4f11d8c69b3f45
      https://github.com/hibernate/hibernate-ogm/commit/457591db360eb0616164c76ffb4f11d8c69b3f45
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    A core/src/test/java/org/hibernate/ogm/backendtck/batchfetching/BatchFetchingTest.java
    A core/src/test/java/org/hibernate/ogm/backendtck/batchfetching/Floor.java
    A core/src/test/java/org/hibernate/ogm/backendtck/batchfetching/Tower.java
    A core/src/test/java/org/hibernate/ogm/backendtck/batchfetching/package-info.java
    R core/src/test/java/org/hibernate/ogm/test/batchfetching/BatchFetchingTest.java
    R core/src/test/java/org/hibernate/ogm/test/batchfetching/Floor.java
    R core/src/test/java/org/hibernate/ogm/test/batchfetching/Tower.java
    R core/src/test/java/org/hibernate/ogm/test/batchfetching/package-info.java

  Log Message:
  -----------
  OGM-767 Move batch fetching test to TCK


  Commit: 637c517c1582ff48b621a13a24d5d0c0dd59afad
      https://github.com/hibernate/hibernate-ogm/commit/637c517c1582ff48b621a13a24d5d0c0dd59afad
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M core/src/main/java/org/hibernate/ogm/hibernatecore/impl/BackendCustomLoader.java
    M core/src/main/java/org/hibernate/ogm/query/impl/OgmQueryLoader.java

  Log Message:
  -----------
  OGM-767 Make OgmQueryLoader and BackendCustomLoader use the resultset

It was only containing a single entry per call to the loader
The compiler might be able to optimize better now that one call happens


  Commit: 081e6bb17599bc2218750f14aed6348370a876e1
      https://github.com/hibernate/hibernate-ogm/commit/081e6bb17599bc2218750f14aed6348370a876e1
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M core/src/test/java/org/hibernate/ogm/backendtck/batchfetching/BatchFetchingTest.java

  Log Message:
  -----------
  OGM-767 Improve batch fetching test to look at which GridDialect method is used

Make sure getTuples is effectively used when expected basically


  Commit: 99fd1c10ec633bd81b436b1369a96056a7116798
      https://github.com/hibernate/hibernate-ogm/commit/99fd1c10ec633bd81b436b1369a96056a7116798
  Author: Emmanuel Bernard <emmanuel at hibernate.org>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M core/src/main/java/org/hibernate/ogm/loader/entity/impl/BatchingEntityLoaderBuilder.java

  Log Message:
  -----------
  OGM-767 Use the dynamic batch fetching solution for OGM

MultigetGridDialect don't provide the right params
to build prepared statements ahead of time.
Also no dialect have this specific need.


Compare: https://github.com/hibernate/hibernate-ogm/compare/f9b5e1fe3cbb...99fd1c10ec63