[hibernate-commits] [hibernate/hibernate-search] 4c9c19: HSEARCH-2170 Convert the GsonHolder to a Service t...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 4c9c1953a4ad802292c3999b6fa27f1b1bfd5daa
      https://github.com/hibernate/hibernate-search/commit/4c9c1953a4ad802292c3999b6fa27f1b1bfd5daa
  Author: Yoann Rodière <yrodiere at redhat.com>
  Date:   2016-08-25 (Thu, 25 Aug 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/ElasticsearchQueries.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/client/impl/JestClient.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/DefaultGsonService.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java
    R elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/GsonHolder.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/GsonService.java
    A elasticsearch/src/main/resources/META-INF/services/org.hibernate.search.elasticsearch.impl.GsonService

  Log Message:
  -----------
  HSEARCH-2170 Convert the GsonHolder to a Service to ensure cleanup

Mainly because Gson holds references to ThreadLocals, so having it stored in a static variable is not desirable.
JsonParser has been moved to private static variables, though, since it does not contain any data.