[hibernate-commits] [hibernate/hibernate-validator] 34844c: HV-1080 Simplifying retrieval of cascaded values;

GitHub noreply at github.com
Wed Aug 31 07:42:07 EDT 2016


  Branch: refs/heads/5.3
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: 34844cdfaee51be504eb565a0ae6a9e2847b97e9
      https://github.com/hibernate/hibernate-validator/commit/34844cdfaee51be504eb565a0ae6a9e2847b97e9
  Author: Gunnar Morling <gunnar.morling at googlemail.com>
  Date:   2016-08-31 (Wed, 31 Aug 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ParameterMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ReturnValueMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/facets/Cascadable.java

  Log Message:
  -----------
  HV-1080 Simplifying retrieval of cascaded values;

* No instanceof check needed anymore
* No repeated setAccessible() calls
* No need to expose getCascadedMember() on PropertyMetadata


  Commit: 9de1ab4e75b3a98f68d9e17d67fb4c33e9ebd6c6
      https://github.com/hibernate/hibernate-validator/commit/9de1ab4e75b3a98f68d9e17d67fb4c33e9ebd6c6
  Author: Gunnar Morling <gunnar.morling at googlemail.com>
  Date:   2016-08-31 (Wed, 31 Aug 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ParameterMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ReturnValueMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/facets/Cascadable.java
    A engine/src/test/java/org/hibernate/validator/test/internal/engine/valuehandling/CascadedOptionalTest.java

  Log Message:
  -----------
  HV-1080 Making sure that the correct type is used for unwrapper resolution;

When determining the unwrapper for a cascadable property, it wasn't determined
which type (the one from the field or the getter) would be used. Mostly that
doesn't matter, but it makes a difference if the field is a "normal" type and
the getter is an Optional<T> of this type. Now always the type of the cascadable
member (marked with @Valid) is used.


Compare: https://github.com/hibernate/hibernate-validator/compare/deb8f5eb1721...9de1ab4e75b3


More information about the hibernate-commits mailing list