[hibernate-commits] [hibernate/hibernate-validator] a4d775: HV-451 Added a check to annotation processor for @...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: a4d77518222c6822c2ba27b969e990d8dbaac5ed
      https://github.com/hibernate/hibernate-validator/commit/a4d77518222c6822c2ba27b969e990d8dbaac5ed
  Author: marko.bekhta <markob at prykladna.lviv.ua>
  Date:   2016-12-07 (Wed, 07 Dec 2016)

  Changed paths:
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/ConstraintCheckFactory.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersGroupsCheck.java
    A annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/GroupSequenceCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/util/AnnotationApiHelper.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/util/ConstraintHelper.java
    M annotation-processor/src/main/resources/org/hibernate/validator/ap/ValidationProcessorMessages.properties
    M annotation-processor/src/test/java/org/hibernate/validator/ap/AnnotationParametersValidationTest.java
    A annotation-processor/src/test/java/org/hibernate/validator/ap/testmodel/annotationparameters/InvalidGroupSequenceParameters.java
    A annotation-processor/src/test/java/org/hibernate/validator/ap/testmodel/annotationparameters/ValidGroupSequenceParameters.java

  Log Message:
  -----------
  HV-451 Added a check to annotation processor for @GroupSequence values:
 -the class list contains the hosting bean class (for default group sequence re-definition)
 -the class list contains only interface
 -the defined group sequence is expandable (no cyclic definition)


  Commit: bcc085240933da302cf45a3144e1fe02bfeded13
      https://github.com/hibernate/hibernate-validator/commit/bcc085240933da302cf45a3144e1fe02bfeded13
  Author: marko.bekhta <markob at prykladna.lviv.ua>
  Date:   2016-12-07 (Wed, 07 Dec 2016)

  Changed paths:
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersDecimalMinMaxCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersDigitsCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersPatternCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersScriptAssertCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersSizeLengthCheck.java

  Log Message:
  -----------
  HV-451 Replaced string literals with constants from TypeNames


  Commit: 763eff8920cec174fbb9f84dfd66417647f42230
      https://github.com/hibernate/hibernate-validator/commit/763eff8920cec174fbb9f84dfd66417647f42230
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2016-12-07 (Wed, 07 Dec 2016)

  Changed paths:
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/GroupSequenceCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/util/AnnotationApiHelper.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/util/ConstraintHelper.java
    M annotation-processor/src/main/resources/org/hibernate/validator/ap/ValidationProcessorMessages.properties
    M annotation-processor/src/test/java/org/hibernate/validator/ap/AnnotationParametersValidationTest.java
    A annotation-processor/src/test/java/org/hibernate/validator/ap/GroupSequenceValidationTest.java
    M annotation-processor/src/test/java/org/hibernate/validator/ap/testmodel/annotationparameters/InvalidGroupSequenceParameters.java
    M annotation-processor/src/test/java/org/hibernate/validator/ap/testmodel/annotationparameters/ValidGroupSequenceParameters.java

  Log Message:
  -----------
  HV-451 Additional fixes and style improvements

The main issue was that a group extending another group is perfectly
valid. It's a group sequence extending an interface which is not
recommended by the doc.

Note that the AP is currently too permissive as it does not detect
cyclic definition due to group inheritance. This will be addressed in a
follow-up commit.


Compare: https://github.com/hibernate/hibernate-validator/compare/68aa928c37c9...763eff8920ce