[hibernate-commits] [hibernate/hibernate-validator] 9af877: HV-451 Added a check to annotation processor for @...

[GitHub]

  Branch: refs/heads/5.4
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: 9af877028104daf53020f0525cda915144184ed6
      https://github.com/hibernate/hibernate-validator/commit/9af877028104daf53020f0525cda915144184ed6
  Author: marko.bekhta <markob at prykladna.lviv.ua>
  Date:   2016-12-07 (Wed, 07 Dec 2016)

  Changed paths:
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/ConstraintCheckFactory.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersGroupsCheck.java
    A annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/GroupSequenceCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/util/AnnotationApiHelper.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/util/ConstraintHelper.java
    M annotation-processor/src/main/resources/org/hibernate/validator/ap/ValidationProcessorMessages.properties
    M annotation-processor/src/test/java/org/hibernate/validator/ap/AnnotationParametersValidationTest.java
    A annotation-processor/src/test/java/org/hibernate/validator/ap/testmodel/annotationparameters/InvalidGroupSequenceParameters.java
    A annotation-processor/src/test/java/org/hibernate/validator/ap/testmodel/annotationparameters/ValidGroupSequenceParameters.java

  Log Message:
  -----------
  HV-451 Added a check to annotation processor for @GroupSequence values:
 -the class list contains the hosting bean class (for default group sequence re-definition)
 -the class list contains only interface
 -the defined group sequence is expandable (no cyclic definition)


  Commit: 71de953f290a81dea4cd3dd9f97e0db67276c477
      https://github.com/hibernate/hibernate-validator/commit/71de953f290a81dea4cd3dd9f97e0db67276c477
  Author: marko.bekhta <markob at prykladna.lviv.ua>
  Date:   2016-12-07 (Wed, 07 Dec 2016)

  Changed paths:
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersDecimalMinMaxCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersDigitsCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersPatternCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersScriptAssertCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/AnnotationParametersSizeLengthCheck.java

  Log Message:
  -----------
  HV-451 Replaced string literals with constants from TypeNames


  Commit: c965ea18c7a87dc0b162e7d17f4a617ffca0d672
      https://github.com/hibernate/hibernate-validator/commit/c965ea18c7a87dc0b162e7d17f4a617ffca0d672
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2016-12-07 (Wed, 07 Dec 2016)

  Changed paths:
    M annotation-processor/src/main/java/org/hibernate/validator/ap/checks/annotationparameters/GroupSequenceCheck.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/util/AnnotationApiHelper.java
    M annotation-processor/src/main/java/org/hibernate/validator/ap/util/ConstraintHelper.java
    M annotation-processor/src/main/resources/org/hibernate/validator/ap/ValidationProcessorMessages.properties
    M annotation-processor/src/test/java/org/hibernate/validator/ap/AnnotationParametersValidationTest.java
    A annotation-processor/src/test/java/org/hibernate/validator/ap/GroupSequenceValidationTest.java
    M annotation-processor/src/test/java/org/hibernate/validator/ap/testmodel/annotationparameters/InvalidGroupSequenceParameters.java
    M annotation-processor/src/test/java/org/hibernate/validator/ap/testmodel/annotationparameters/ValidGroupSequenceParameters.java

  Log Message:
  -----------
  HV-451 Additional fixes and style improvements

The main issue was that a group extending another group is perfectly
valid. It's a group sequence extending an interface which is not
recommended by the doc.

Note that the AP is currently too permissive as it does not detect
cyclic definition due to group inheritance. This will be addressed in a
follow-up commit.


Compare: https://github.com/hibernate/hibernate-validator/compare/dddc3d145e9a...c965ea18c7a8