[hibernate-commits] [hibernate/hibernate-ogm] 26a34a: OGM-900 adding support for "dotted" collection nam...

GitHub noreply at github.com
Fri Jan 8 02:48:18 EST 2016


  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-ogm
  Commit: 26a34a23438dd7718977cf384e17c593aa568175
      https://github.com/hibernate/hibernate-ogm/commit/26a34a23438dd7718977cf384e17c593aa568175
  Author: ledroff <ledroff at adobe.com>
  Date:   2016-01-08 (Fri, 08 Jan 2016)

  Changed paths:
    M mongodb/src/main/java/org/hibernate/ogm/datastore/mongodb/query/parsing/nativequery/impl/NativeQueryParser.java
    M mongodb/src/test/java/org/hibernate/ogm/datastore/mongodb/test/query/parsing/nativequery/NativeQueryParserTest.java

  Log Message:
  -----------
  OGM-900 adding support for "dotted" collection names

* refactored the `parboiled` `NativeQueryParser` rules to look for dots as prefixed of reserved keywords
* added a Unit test for in `NativeQueryParserTest` : `shouldSupportDotInCollectionName()`
* added `TODOs` and javadoc on these points:
  * the parser will fail detecting non supported API : currently we only support `find` and/or `count`
  * mongo collection names have some naming restrictions (cf. https://docs.mongodb.org/manual/faq/developers/#are-there-any-restrictions-on-the-names-of-collections) not reflected in our implementations


  Commit: a84b6b07fb389e0e7848bf702f32288a2aa64bd3
      https://github.com/hibernate/hibernate-ogm/commit/a84b6b07fb389e0e7848bf702f32288a2aa64bd3
  Author: ledroff <ledroff at adobe.com>
  Date:   2016-01-08 (Fri, 08 Jan 2016)

  Changed paths:
    M mongodb/src/main/java/org/hibernate/ogm/datastore/mongodb/query/parsing/nativequery/impl/NativeQueryParser.java
    M mongodb/src/test/java/org/hibernate/ogm/datastore/mongodb/test/datastore/CollectionNamingValidationTest.java

  Log Message:
  -----------
  OGM-900 added one more test which actually fetches an entity from a dot-named table

also :
* got rid of redundant `NativeQueryParser` operation
* added a reference to a newly created lira entry on collection naming constraints


Compare: https://github.com/hibernate/hibernate-ogm/compare/504ae61f120d...a84b6b07fb38


More information about the hibernate-commits mailing list