[hibernate-commits] [hibernate/hibernate-ogm] f75678: OGM-1113 Ensure settings passed in the configure m...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-ogm
  Commit: f756781eba8d959de932e06a0a10c0da2e5a302d
      https://github.com/hibernate/hibernate-ogm/commit/f756781eba8d959de932e06a0a10c0da2e5a302d
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2016-07-13 (Wed, 13 Jul 2016)

  Changed paths:
    M cassandra/src/test/java/org/hibernate/ogm/datastore/cassandra/utils/CassandraTestHelper.java
    R core/src/main/java/org/hibernate/ogm/datastore/impl/AvailableDatastoreProvider.java
    M core/src/main/java/org/hibernate/ogm/datastore/impl/DatastoreProviderInitiator.java
    A core/src/main/java/org/hibernate/ogm/datastore/impl/DatastoreProviderType.java
    M core/src/test/java/org/hibernate/ogm/backendtck/associations/collection/manytomany/ManyToManyExtraTest.java
    M core/src/test/java/org/hibernate/ogm/backendtck/associations/collection/manytomany/ManyToManyTest.java
    M core/src/test/java/org/hibernate/ogm/backendtck/associations/collection/types/MapContentsStoredInSeparateDocumentTest.java
    M core/src/test/java/org/hibernate/ogm/backendtck/associations/collection/types/MapTest.java
    M core/src/test/java/org/hibernate/ogm/backendtck/associations/collection/unidirectional/CollectionUnidirectionalTest.java
    M core/src/test/java/org/hibernate/ogm/backendtck/associations/manytoone/ManyToOneTest.java
    M core/src/test/java/org/hibernate/ogm/backendtck/queries/QueriesWithEmbeddedCollectionTest.java
    M core/src/test/java/org/hibernate/ogm/backendtck/queries/QueryUpdateTest.java
    M core/src/test/java/org/hibernate/ogm/backendtck/simpleentity/CRUDTest.java
    M core/src/test/java/org/hibernate/ogm/backendtck/type/converter/JpaAttributeConverterTest.java
    A core/src/test/java/org/hibernate/ogm/test/testsupport/OgmTestCaseConfigureTest.java
    A core/src/test/java/org/hibernate/ogm/test/testsupport/Poem.java
    A core/src/test/java/org/hibernate/ogm/utils/GridDialectTestHelper.java
    A core/src/test/java/org/hibernate/ogm/utils/GridDialectTestHelperType.java
    M core/src/test/java/org/hibernate/ogm/utils/GridDialectType.java
    R core/src/test/java/org/hibernate/ogm/utils/GridModule.java
    M core/src/test/java/org/hibernate/ogm/utils/HashMapTestHelper.java
    M core/src/test/java/org/hibernate/ogm/utils/OgmTestCase.java
    M core/src/test/java/org/hibernate/ogm/utils/OgmTestRunner.java
    M core/src/test/java/org/hibernate/ogm/utils/SkipByDatastoreProvider.java
    M core/src/test/java/org/hibernate/ogm/utils/SkippableTestRunner.java
    M core/src/test/java/org/hibernate/ogm/utils/TestHelper.java
    R core/src/test/java/org/hibernate/ogm/utils/TestableGridDialect.java
    M core/src/test/java/org/hibernate/ogm/utils/test/SkipByDatastoreProviderClassLevelSelfTest.java
    M core/src/test/java/org/hibernate/ogm/utils/test/SkipByDatastoreProviderSelfJpaTest.java
    M core/src/test/java/org/hibernate/ogm/utils/test/SkipByDatastoreProviderSelfTest.java
    M couchdb/src/test/java/org/hibernate/ogm/datastore/couchdb/utils/CouchDBTestHelper.java
    M documentation/manual/src/main/asciidoc/en-US/modules/how-to-contribute.asciidoc
    M ehcache/src/test/java/org/hibernate/ogm/datastore/ehcache/test/cachemapping/CacheMappingTestBase.java
    M ehcache/src/test/java/org/hibernate/ogm/datastore/ehcache/utils/EhcacheTestHelper.java
    M infinispan/src/test/java/org/hibernate/ogm/datastore/infinispan/utils/InfinispanTestHelper.java
    M mongodb/src/test/java/org/hibernate/ogm/datastore/mongodb/test/associations/storageconfiguration/AssociationDocumentStorageConfiguredViaAnnotationsTest.java
    M mongodb/src/test/java/org/hibernate/ogm/datastore/mongodb/test/datastore/DatastoreInitializationTest.java
    M mongodb/src/test/java/org/hibernate/ogm/datastore/mongodb/test/index/MongoDBIndexTest.java
    M mongodb/src/test/java/org/hibernate/ogm/datastore/mongodb/utils/MongoDBTestHelper.java
    M neo4j/src/test/java/org/hibernate/ogm/datastore/neo4j/utils/Neo4jTestHelper.java
    M redis/src/test/java/org/hibernate/ogm/datastore/redis/utils/RedisTestHelper.java

  Log Message:
  -----------
  OGM-1113 Ensure settings passed in the configure method of a test are
correctly applied

So basically, it was already working but the test machinery does not
make it very clear. There were quite a lot of leftovers from various
iterations and the main objective of this commit is to make everything
more clear so that we understand what is going on.

I mostly renamed classes and interfaces so that they clearly state what
they are and to improve consistency. Typically, TestableGridDialect
must have been called that way when the plan was to integrate it in the
dialect but actually it is a GridDialectTestHelper.

Also renamed sessions to sessionFactory. And so on.


  Commit: a08a24fe1d6c3eb980bf65830185278a54d54b86
      https://github.com/hibernate/hibernate-ogm/commit/a08a24fe1d6c3eb980bf65830185278a54d54b86
  Author: Gunnar Morling <gunnar.morling at googlemail.com>
  Date:   2016-07-13 (Wed, 13 Jul 2016)

  Changed paths:
    M core/src/main/java/org/hibernate/ogm/dialect/eventstate/impl/EventContextManager.java
    M core/src/main/java/org/hibernate/ogm/dialect/eventstate/impl/EventStateLifecycle.java
    M core/src/main/java/org/hibernate/ogm/dialect/eventstate/impl/EventStateLifecycles.java
    M core/src/main/java/org/hibernate/ogm/service/impl/OgmIntegrator.java
    A mongodb/src/test/java/org/hibernate/ogm/datastore/mongodb/test/lifecycle/BarKeeper.java
    A mongodb/src/test/java/org/hibernate/ogm/datastore/mongodb/test/lifecycle/PersistOperationCollectorTest.java

  Log Message:
  -----------
  OGM-1103 Prevent ConcurrentModificationException in EventContextManager

When using an OperationCollector and an OperationsQueue in the
EventContextManager, you might have ended up with a
ConcurrentModificationException as the stateHolder map was
modified while iterating over it.
We now initialize all the required elements at the start of the event
cyle to prevent that.


  Commit: 22e6d6ffc053b048a1858371917631f246eab8d0
      https://github.com/hibernate/hibernate-ogm/commit/22e6d6ffc053b048a1858371917631f246eab8d0
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2016-07-13 (Wed, 13 Jul 2016)

  Changed paths:
    M cassandra/pom.xml
    M core/pom.xml
    A core/src/test/java/org/hibernate/ogm/utils/BytemanHelper.java
    A core/src/test/java/org/hibernate/ogm/utils/BytemanHelperStateCleanup.java
    M core/src/test/java/org/hibernate/ogm/utils/SkippableTestRunner.java
    M couchdb/pom.xml
    M ehcache/pom.xml
    M infinispan/pom.xml
    M mongodb/pom.xml
    M neo4j/pom.xml
    M pom.xml
    M redis/pom.xml

  Log Message:
  -----------
  OGM-1114 Make Byteman usable in OGM tests


  Commit: 6789cb9359ee67770a9d307a6c9bc144f51592d1
      https://github.com/hibernate/hibernate-ogm/commit/6789cb9359ee67770a9d307a6c9bc144f51592d1
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2016-07-13 (Wed, 13 Jul 2016)

  Changed paths:
    M core/src/main/java/org/hibernate/ogm/dialect/eventstate/impl/EventContextManagingPersistEventListener.java
    M core/src/main/java/org/hibernate/ogm/service/impl/OgmIntegrator.java
    M mongodb/src/test/java/org/hibernate/ogm/datastore/mongodb/test/lifecycle/PersistOperationCollectorTest.java

  Log Message:
  -----------
  OGM-1114 Set up the event context even for persist and non JPA


Compare: https://github.com/hibernate/hibernate-ogm/compare/ecb24aac6f18...6789cb9359ee