[hibernate-commits] [hibernate/hibernate-search] cdaa87: HSEARCH-2396 Enable tests relating to embedded IDs...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: cdaa87431143be2267b9411e3a574919cbb2299f
      https://github.com/hibernate/hibernate-search/commit/cdaa87431143be2267b9411e3a574919cbb2299f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/batchindexing/LegacyCarPlantPKBridge.java
    M orm/src/test/java/org/hibernate/search/test/id/PersonPKBridge.java

  Log Message:
  -----------
  HSEARCH-2396 Enable tests relating to embedded IDs for ES


  Commit: 550a545de47be9ceefe198609115674c551b99f6
      https://github.com/hibernate/hibernate-search/commit/550a545de47be9ceefe198609115674c551b99f6
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexWorkVisitor.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchMappingBuilder.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/JsonAccessor.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/JsonAccessorBuilder.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/JsonElementType.java
    R elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/JsonTreeBuilder.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/PathComponentExtractor.java
    M engine/src/main/java/org/hibernate/search/spatial/impl/DistanceFilter.java
    M engine/src/main/java/org/hibernate/search/spatial/impl/SpatialHelper.java

  Log Message:
  -----------
  HSEARCH-2396 Support for creating nested fields from custom field bridges with Elasticsearch

In order to do that, we have to make sure to properly analyze the end of
the field names (the part that is not an @IndexedEmbedded prefix), and
create nodes for path components in this part of the path.

The implied changes to the implementation are not trivial, because the
algorithms in JsonTreeBuilder that previously always created empty
JsonObjects now must also be able to add a user-supplied JsonPrimitive.
The introduction of JsonAccessor helps to avoid code duplication and
to keep the code simple.


  Commit: 480e0359ec32a91efbce17dcb2c213356676632d
      https://github.com/hibernate/hibernate-search/commit/480e0359ec32a91efbce17dcb2c213356676632d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexWorkVisitor.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchIndexMappingIT.java

  Log Message:
  -----------
  HSEARCH-2396 Enable indexing the ID as part of the document with ES

The ID was previously only provided to ES in the URL, resulting in
searches on the ID field with the Hibernate Search field name
(instead of the ES-specific '_id' keyword) failing miserably.

Also, re-enabled some tests that used not to work on ES due to the lack
of support for ID searches.


  Commit: 82c4e9ccecde2d291acd53a8cfbe5a71e1f4bd88
      https://github.com/hibernate/hibernate-search/commit/82c4e9ccecde2d291acd53a8cfbe5a71e1f4bd88
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M documentation/src/main/asciidoc/elasticsearch-integration.asciidoc
    M orm/src/test/java/org/hibernate/search/test/batchindexing/LegacyCarPlantPKBridge.java
    M orm/src/test/java/org/hibernate/search/test/id/EmbeddedIdTest.java
    M orm/src/test/java/org/hibernate/search/test/id/PersonPKBridge.java
    M orm/src/test/java/org/hibernate/search/test/id/ProgrammaticEmbeddedItTest.java

  Log Message:
  -----------
  HSEARCH-2396 Document the limitations of field nesting in custom field bridges


  Commit: a437617206d82767205d2b007538549fbadd5f7f
      https://github.com/hibernate/hibernate-search/commit/a437617206d82767205d2b007538549fbadd5f7f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M documentation/src/main/asciidoc/elasticsearch-integration.asciidoc

  Log Message:
  -----------
  HSEARCH-2396 Updated the limitations in the documentation

We now can use custom field bridges on documents IDs, even though there
are limitations as for other fields (see previous commit).


  Commit: e8c8192789e51e72cf7d600e69215e1fe0c1c4e2
      https://github.com/hibernate/hibernate-search/commit/e8c8192789e51e72cf7d600e69215e1fe0c1c4e2
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/embedded/sorting/EmbeddedSortableIdFieldTest.java

  Log Message:
  -----------
  HSEARCH-2396 Disable a test that should be fixed with HSEARCH-2398

An exception is raised as desired, but not the exact exception we expect
because validation is delegated to Elasticsearch and errors are not
translated.


Compare: https://github.com/hibernate/hibernate-search/compare/4f9e26813973...e8c8192789e5