[hibernate-commits] [hibernate/hibernate-search] d4ae60: HSEARCH-2393 Fixed ClassBridgeTest for Elasticsear...

Thu Nov 3 15:15:55 EDT 2016

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: d4ae60eadefc3f8599c2971dcd4f0ac75951697d
      https://github.com/hibernate/hibernate-search/commit/d4ae60eadefc3f8599c2971dcd4f0ac75951697d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/bridge/CatDeptsFieldsClassBridge.java
    M orm/src/test/java/org/hibernate/search/test/bridge/ClassBridgeTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/EquipmentType.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed ClassBridgeTest for Elasticsearch

  Commit: c32b6144d7a8132d3d7a9bdb3f6586d39e0e332d
      https://github.com/hibernate/hibernate-search/commit/c32b6144d7a8132d3d7a9bdb3f6586d39e0e332d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/jmx/IndexControlMBeanTest.java

  Log Message:
  -----------
  HSEARCH-2393 Changed the ticket associated with IndexControlMBeanTest.testIndexAndPurge

Will be fixed with HSEARCH-2421

  Commit: 7b716eef667b2e00c9c3eb9adcce483878a25e4b
      https://github.com/hibernate/hibernate-search/commit/7b716eef667b2e00c9c3eb9adcce483878a25e4b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/embedded/depth/WorkDoneOnEntitiesTest.java

  Log Message:
  -----------
  HSEARCH-2393 Removed reliance of WorkDoneOnEntitiesTest on IndexReader

The new method is probably less efficient, but at least it works with
Elasticsearch.

  Commit: 754276bb03d4c354da73c3030db85adc9fb6ec0c
      https://github.com/hibernate/hibernate-search/commit/754276bb03d4c354da73c3030db85adc9fb6ec0c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/engine/optimizations/deletebyterm/DeleteByTermTest.java

  Log Message:
  -----------
  HSEARCH-2393 Disabled DeleteByTermTest for Elasticsearch

... since this optimization only makes sense with the Lucene backend.

  Commit: a2232be661637755d8953854964d946124415fdd
      https://github.com/hibernate/hibernate-search/commit/a2232be661637755d8953854964d946124415fdd
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/engine/optimizations/UpdateOperationsTest.java

  Log Message:
  -----------
  HSEARCH-2393 Disabled UpdateOperationsTest for Elasticsearch

... since this optimization only makes sense with the Lucene backend.

  Commit: 69afadefcdbd98acb014abd952251c75f9f119c6
      https://github.com/hibernate/hibernate-search/commit/69afadefcdbd98acb014abd952251c75f9f119c6
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/TestResourceManager.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed TestResourceManager.getExtendedSearchIntegrator's return type

  Commit: dbaf37951521e73fd20413825dd6a7d3027c937d
      https://github.com/hibernate/hibernate-search/commit/dbaf37951521e73fd20413825dd6a7d3027c937d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/DefaultTestResourceManager.java
    M orm/src/test/java/org/hibernate/search/test/SearchTestBase.java
    M orm/src/test/java/org/hibernate/search/test/TestResourceManager.java
    M orm/src/test/java/org/hibernate/search/test/directoryProvider/RamDirectoryTest.java
    M orm/src/test/java/org/hibernate/search/test/engine/TransactionTest.java
    M orm/src/test/java/org/hibernate/search/test/util/BackendTestHelper.java

  Log Message:
  -----------
  HSEARCH-2393 Use BackendTestHelper to retrieve the number of docs in an index

Also, removed some Lucene-specific methods in test classes that are not
needed anymore.

  Commit: 78f29cf0211fb59665f42b818cad4b869f0a68f8
      https://github.com/hibernate/hibernate-search/commit/78f29cf0211fb59665f42b818cad4b869f0a68f8
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml

  Log Message:
  -----------
  HSEARCH-2393 Enable TransactionTest for Elasticsearch

  Commit: f4c43cde846cb40e2f904d545ace8e88e126d3bb
      https://github.com/hibernate/hibernate-search/commit/f4c43cde846cb40e2f904d545ace8e88e126d3bb
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/interceptor/Blog.java
    M orm/src/test/java/org/hibernate/search/test/interceptor/IndexingActionInterceptorTest.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed IndexingActionInterceptorTest for Elasticsearch

  Commit: b737e2aa7f593b9e07c23f76307840321ad63ea5
      https://github.com/hibernate/hibernate-search/commit/b737e2aa7f593b9e07c23f76307840321ad63ea5
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    A orm/src/test/java/org/hibernate/search/test/SearchInitializationTestBase.java

  Log Message:
  -----------
  HSEARCH-2393 Added a base class for initialization tests

  Commit: 7b5cdd7679a87929cb79d44214669802e80bdf4e
      https://github.com/hibernate/hibernate-search/commit/7b5cdd7679a87929cb79d44214669802e80bdf4e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchIndexNullAsTypeCheckingIT.java

  Log Message:
  -----------
  HSEARCH-2393 Make use of the base for initialization tests

  Commit: 689b74af6326f6f59195a46cafbfbcc186bf520f
      https://github.com/hibernate/hibernate-search/commit/689b74af6326f6f59195a46cafbfbcc186bf520f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    A engine/src/test/java/org/hibernate/search/test/util/impl/ExpectedLog4jLog.java

  Log Message:
  -----------
  HSEARCH-2393 Add a rule for asserting produced logs

  Commit: c18b57843ad2c6006b3103e0a2ef1131783f5788
      https://github.com/hibernate/hibernate-search/commit/c18b57843ad2c6006b3103e0a2ef1131783f5788
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M documentation/src/main/asciidoc/elasticsearch-integration.asciidoc
    M elasticsearch/pom.xml
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java
    A elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchUnsupportedFeaturesIT.java
    M orm/src/test/java/org/hibernate/search/test/configuration/ProgrammaticMappingTest.java
    M orm/src/test/java/org/hibernate/search/test/query/boost/DynamicBoostingTest.java

  Log Message:
  -----------
  HSEARCH-2393 Make the lack of support for dynamic boosting on Elasticsearch explicit

  Commit: 2bc52aff8063ca71f269f44c5f67bcb6c2907c12
      https://github.com/hibernate/hibernate-search/commit/2bc52aff8063ca71f269f44c5f67bcb6c2907c12
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/jpa/ToStringTest.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed ToStringTest for Elasticsearch

  Commit: 9f5c828f061625bc3c3f3ef83fa89daa00f02a12
      https://github.com/hibernate/hibernate-search/commit/9f5c828f061625bc3c3f3ef83fa89daa00f02a12
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/query/nullValues/IndexAndQueryNullTest.java
    A orm/src/test/java/org/hibernate/search/test/query/nullValues/IndexNullLuceneDocumentContentTest.java
    M orm/src/test/java/org/hibernate/search/test/query/nullValues/ProgrammaticIndexAndQueryNullTest.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed *IndexAndQueryNullTest for Elasticsearch

Also, did some cleanup on these very old tests.

  Commit: 16645111ccd522e39f83730f46fd73daf13fcc4b
      https://github.com/hibernate/hibernate-search/commit/16645111ccd522e39f83730f46fd73daf13fcc4b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/bridge/DateSplitBridge.java
    A orm/src/test/java/org/hibernate/search/test/query/LuceneProjectionQueryTest.java
    M orm/src/test/java/org/hibernate/search/test/query/ProjectionQueryTest.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed ProjectionQueryTest for Elasticsearch

 * Isolated and moved Lucene-specific tests to LuceneProjectionQueryTest
 * Isolated and moved a test about projecting on unstored field that
   won't work right now (see HSEARCH-2423)
 * Isolated and moved a test about projecting on score without sorting
   by relevance (see HSEARCH-2422)
 * Fixed DateSplitBridge (see HSEARCH-2396)
 * Cleaned up a bit

  Commit: 250ade71bb0c7038675049e51bed9f2099d06efd
      https://github.com/hibernate/hibernate-search/commit/250ade71bb0c7038675049e51bed9f2099d06efd
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/query/sorting/SortUsingEntityManagerTest.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed SortUsingEntityManagerTest on Elasticsearch

The sort type for dates happens to differ between the Lucene backend and
the Elasticsearch backend.

  Commit: 657013c829f311b451b457a4df36b710e575df65
      https://github.com/hibernate/hibernate-search/commit/657013c829f311b451b457a4df36b710e575df65
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/engine/LazyCollectionsUpdatingTest.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed LazyCollectionsUpdatingTest for Elasticsearch

The FieldSelector bits aren't necessary, because we already test that in
LuceneProjectionQueryTest.

The analysis bit was not the purpose of this test.

  Commit: 4440ad7e034b4640ce84d5f332bd4af132641b0f
      https://github.com/hibernate/hibernate-search/commit/4440ad7e034b4640ce84d5f332bd4af132641b0f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/engine/worker/WorkerTestCase.java

  Log Message:
  -----------
  HSEARCH-2393 Do not depend on analyzers in Worker test cases

Analyzers are not what we're testing, and they work differently in ES,
so we better not bother with that.

  Commit: dcf7a6751286fa7641ec46f0b788d92bae08da73
      https://github.com/hibernate/hibernate-search/commit/dcf7a6751286fa7641ec46f0b788d92bae08da73
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    A orm/src/test/java/org/hibernate/search/test/engine/LuceneNumericFieldTest.java
    M orm/src/test/java/org/hibernate/search/test/engine/NumericFieldTest.java
    M orm/src/test/java/org/hibernate/search/test/engine/TouristAttraction.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed NumericFieldTest for Elasticsearch

Also, disabled NumericFieldTest.testNumericFieldProjections for now and
created HSEARCH-2425 to fix it.

  Commit: 3a1977a73129536818a3e5153ffa9808c78d5d0d
      https://github.com/hibernate/hibernate-search/commit/3a1977a73129536818a3e5153ffa9808c78d5d0d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/query/sorting/Explorer.java
    M orm/src/test/java/org/hibernate/search/test/query/sorting/SortOnFieldsFromCustomBridgeTest.java
    M orm/src/test/java/org/hibernate/search/test/query/sorting/Territory.java

  Log Message:
  -----------
  HSEARCH-2393 Fix SortOnFieldsFromCustomBridgeTest for Elasticsearch

 * The territory name, which we sort on, was being analyzed.
 * The embedded property was being used as both an embedded field prefix
   and a field name, which can't work with Elasticsearch (see the
   ES documentation).
 * There was an extra, useless @SortableField annotation on the field
   derived from the embedded property
 * A field bridge was adding a property directly to the root of the
   document, which definitely isn't a good idea when we embed the entity
   in another.

  Commit: 198ab403d0e5120aed8e33c965f6d299839c47e5
      https://github.com/hibernate/hibernate-search/commit/198ab403d0e5120aed8e33c965f6d299839c47e5
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml

  Log Message:
  -----------
  HSEARCH-2393 Added ES test exclusions due to HSEARCH-2426

  Commit: 9454cd004ac2dbdd036a08df6a693508c6afc555
      https://github.com/hibernate/hibernate-search/commit/9454cd004ac2dbdd036a08df6a693508c6afc555
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M orm/src/test/java/org/hibernate/search/test/errorhandling/LuceneErrorHandlingTest.java

  Log Message:
  -----------
  HSEARCH-2393 Skipped LuceneErrorHandlingTest on Elasticsearch

  Commit: c784fd577eef754ec5ad60c93911747ad496f50f
      https://github.com/hibernate/hibernate-search/commit/c784fd577eef754ec5ad60c93911747ad496f50f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml

  Log Message:
  -----------
  HSEARCH-2393 Enabled ProgrammaticMappingTest for Elasticsearch

  Commit: 14fbaacec4343af88a5a88cc0b027926f07c36d8
      https://github.com/hibernate/hibernate-search/commit/14fbaacec4343af88a5a88cc0b027926f07c36d8
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/elasticsearchconfiguration/elasticsearch.yml
    M orm/src/test/java/org/hibernate/search/test/configuration/BlogEntry.java
    M orm/src/test/java/org/hibernate/search/test/configuration/ProgrammaticSearchMappingFactory.java

  Log Message:
  -----------
  HSEARCH-2393 Added analyzers to elasticsearch.yml for ProgrammaticMappingTest

  Commit: 4c385858d44e7e2a2cb0063d9473c0a36be2740f
      https://github.com/hibernate/hibernate-search/commit/4c385858d44e7e2a2cb0063d9473c0a36be2740f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M documentation/src/main/asciidoc/elasticsearch-integration.asciidoc
    M orm/src/test/java/org/hibernate/search/test/configuration/ProgrammaticMappingTest.java

  Log Message:
  -----------
  HSEARCH-2393 Added ES test exclusion due to HSEARCH-2428

  Commit: ca54104d1245b8ed2fc2e11e61e9dc3b106dc160
      https://github.com/hibernate/hibernate-search/commit/ca54104d1245b8ed2fc2e11e61e9dc3b106dc160
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/configuration/ProgrammaticMappingTest.java

  Log Message:
  -----------
  HSEARCH-2393 Added test exclusion due to HSEARCH-2429

  Commit: 825df5e7c2f29b8210ae1834b020a4c8e9042050
      https://github.com/hibernate/hibernate-search/commit/825df5e7c2f29b8210ae1834b020a4c8e9042050
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    A orm/src/test/java/org/hibernate/search/test/configuration/LuceneProgrammaticMappingTest.java
    M orm/src/test/java/org/hibernate/search/test/configuration/ProgrammaticMappingTest.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed ProgrammaticMappingTest.testNumeric for Elasticsearch

  Commit: acfab7ad5fecee6c2196431c1ae8afa028c75753
      https://github.com/hibernate/hibernate-search/commit/acfab7ad5fecee6c2196431c1ae8afa028c75753
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/configuration/ProgrammaticMappingTest.java
    M orm/src/test/java/org/hibernate/search/test/configuration/ProgrammaticSearchMappingFactory.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed ProgrammaticMappingTest.testProvidedIdMapping for Elasticsearch

  Commit: b1757af28c5680a8886a73402639af082aad6678
      https://github.com/hibernate/hibernate-search/commit/b1757af28c5680a8886a73402639af082aad6678
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ToElasticsearch.java

  Log Message:
  -----------
  HSEARCH-2393 Adding support for org.apache.lucene.search.CachingWrapperFilter with Elasticsearch

This filter type is used in some tests, and some users might use it.

  Commit: 78f1ee52674d91ca3bc3ffb3707b1338bb443fa5
      https://github.com/hibernate/hibernate-search/commit/78f1ee52674d91ca3bc3ffb3707b1338bb443fa5
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/configuration/ProgrammaticMappingTest.java
    M orm/src/test/java/org/hibernate/search/test/configuration/SecurityFilterFactory.java

  Log Message:
  -----------
  HSEARCH-2393 Fixed ProgrammaticMappingTest.testFullTextFilterDefAtMappingLevel

We don't need advanced filters, we just test that the filter we
configured is actually used. Which is why replacing the actual filter
implementation seems okay.

Also, we don't need to test analysis on the "owner" field, so we better
use a simple keyword and avoid conflicts between the way the Lucene
backend and the Elasticsearch backend do the analysis.

  Commit: 156c8033743052ff0b815eb2292e2e10a879b2ed
      https://github.com/hibernate/hibernate-search/commit/156c8033743052ff0b815eb2292e2e10a879b2ed
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/query/dsl/DSLTest.java

  Log Message:
  -----------
  HSEARCH-2393 Disable tests about range queries on dates ignoring field bridges for Elasticsearch

Those only work because of a hack in the query DSL that is necessary for
the Lucene backend: even when field bridges are not ignored, there's no
way for the query DSL to convert a date to a numeric value, so the
org.hibernate.search.bridge.util.impl.NumericFieldUtils.createNumericRangeQuery
method does that for us whenever we detect a numeric field bridge, but
it does that totally independently from the actual field bridge...

Since date bridges are not numeric with Elasticsearch, ignoring the
field bridges has another effect entirely: the date is converted to
string using toString(), which obviously fails.

Compare: https://github.com/hibernate/hibernate-search/compare/e8c8192789e5...156c80337430