[hibernate-commits] [hibernate/hibernate-search] a36e81: HSEARCH-2432 Test for entity Ids containing unders...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: a36e810a312f9accd21a7a23b714b83ddc21081b
      https://github.com/hibernate/hibernate-search/commit/a36e810a312f9accd21a7a23b714b83ddc21081b
  Author: gustavonalle <gustavonalle at gmail.com>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchImplicitProvidedIdIT.java
    M engine/src/test/java/org/hibernate/search/testsupport/junit/SearchFactoryHolder.java

  Log Message:
  -----------
  HSEARCH-2432 Test for entity Ids containing underscore lost when querying


  Commit: af13cd3ff0274978ecf7418ae7831ee1e9fad974
      https://github.com/hibernate/hibernate-search/commit/af13cd3ff0274978ecf7418ae7831ee1e9fad974
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchImplicitProvidedIdIT.java

  Log Message:
  -----------
  HSEARCH-2432 Make some test entities private


  Commit: 5b78dfcf735b2108ce7676619d67f1abebf111ac
      https://github.com/hibernate/hibernate-search/commit/5b78dfcf735b2108ce7676619d67f1abebf111ac
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    R elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/User.java

  Log Message:
  -----------
  HSEARCH-2432 Removed a remnant from a previous refactoring

A test entity was previously refactored to an inner class, but
the original file wasn't deleted as it should have.

Making test entities nested helps when making new tests with
the same entities, especially when we do not want to alter existing
tests.


  Commit: 2d137a9678a2b9cdebc43e3764afc813324a8df8
      https://github.com/hibernate/hibernate-search/commit/2d137a9678a2b9cdebc43e3764afc813324a8df8
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    A elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchMultitenancyIT.java
    M engine/src/test/java/org/hibernate/search/testsupport/junit/SearchFactoryHolder.java
    M engine/src/test/java/org/hibernate/search/testsupport/setup/SearchConfigurationForTest.java

  Log Message:
  -----------
  HSEARCH-2420 Test for tenant IDs containing underscores messing with entity ID retrieval


  Commit: 53ccb682be5adf888c8ebf0b01cdb19de3912eef
      https://github.com/hibernate/hibernate-search/commit/53ccb682be5adf888c8ebf0b01cdb19de3912eef
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    R elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/DocumentIdHelper.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexWorkVisitor.java

  Log Message:
  -----------
  HSEARCH-2420 and HSEARCH-2432 Rationalize data extraction from ES query results

Previously, we had:

 * Different behavior between ID fields and standard fields
 * ID extraction from the ES "_id" field, which contains a concatenation
   of tenant ID and entity ID (thus the extraction was error prone)
 * Half-baked support for TwoWayFieldBridges on non-ID fields (they
   would not find their additional fields in the document when we called
   get())

To solve this:

 * The entity ID is now extracted from in-document fields added by the ID
   field bridge
 * Thus the entity ID is extracted like any other field
 * Support has been added for TwoWayFieldBridges which define additional
   fields


Compare: https://github.com/hibernate/hibernate-search/compare/ff35fcabf4ab...53ccb682be5a