[hibernate-commits] [hibernate/hibernate-search] a51eb0: HSEARCH-2260 Fixed an issue with index creation ti...

Thu Nov 17 11:41:25 EST 2016

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: a51eb0207466b5aa0ad71da370ec3730765d3c72
      https://github.com/hibernate/hibernate-search/commit/a51eb0207466b5aa0ad71da370ec3730765d3c72
  Author: Yoann Rodière <yrodiere at redhat.com>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java

  Log Message:
  -----------
  HSEARCH-2260 Fixed an issue with index creation timing out

When the index name contained some special character that should be url-encoded (such as '$'), it was not url-encoded.
As a result, we waited for the creation of an index that was never created in the first place, so we were reaching the timeout and considered the index creation had failed, whereas it had not.

  Commit: 3b20446a206df72fc44d02634f447cb05c0d9cad
      https://github.com/hibernate/hibernate-search/commit/3b20446a206df72fc44d02634f447cb05c0d9cad
  Author: Yoann Rodière <yrodiere at redhat.com>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/cfg/ElasticsearchEnvironment.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/client/impl/JestClient.java

  Log Message:
  -----------
  HSEARCH-2260 Added public defaults for some ES client properties

This will ease up connections to the server from test code.

  Commit: dd2084ed5232f36300348405c931516bdaab04a7
      https://github.com/hibernate/hibernate-search/commit/dd2084ed5232f36300348405c931516bdaab04a7
  Author: Yoann Rodière <yrodiere at redhat.com>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    A engine/src/test/java/org/hibernate/search/test/util/impl/ExceptionMatcherBuilder.java

  Log Message:
  -----------
  HSEARCH-2260 Added tools for precise exception mapping

  Commit: 4f3419a399439598b129659fb8887b61670d8220
      https://github.com/hibernate/hibernate-search/commit/4f3419a399439598b129659fb8887b61670d8220
  Author: Yoann Rodière <yrodiere at redhat.com>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    A elasticsearch/src/test/java/org/hibernate/search/elasticsearch/testutil/TestElasticsearchClient.java

  Log Message:
  -----------
  HSEARCH-2260 Added tools for controlling an ES instance without Hibernate Search (for tests)

  Commit: 01dbdd652709ab254b7c3855f2c64628f834f266
      https://github.com/hibernate/hibernate-search/commit/01dbdd652709ab254b7c3855f2c64628f834f266
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/DefaultGsonService.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticSearchIndexNullAsHelper.java
    R elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchFieldType.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchMappingBuilder.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/GsonService.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/model/DataType.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/model/DynamicType.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/model/ElasticsearchFormatJsonAdapter.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/model/IndexMetadata.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/model/IndexType.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/model/PropertyMapping.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/model/TypeMapping.java

  Log Message:
  -----------
  HSEARCH-2260 Introduced a typed Elasticsearch schema model

This will help when validating data, because reading from JsonObject is
really not practical. If we use a strongly typed model instead, code
will be much more readable.

  Commit: a63b050c8f50b00415c9cabd6d2232042919511f
      https://github.com/hibernate/hibernate-search/commit/a63b050c8f50b00415c9cabd6d2232042919511f
  Author: Yoann Rodière <yrodiere at redhat.com>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/cfg/IndexSchemaManagementStrategy.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaValidationException.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaValidator.java
    A elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java

  Log Message:
  -----------
  HSEARCH-2260 Added the VALIDATE index management strategy.

  Commit: a6dad687170e3f464d897d1e68fb8812591e731a
      https://github.com/hibernate/hibernate-search/commit/a6dad687170e3f464d897d1e68fb8812591e731a
  Author: Yoann Rodière <yrodiere at redhat.com>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java

  Log Message:
  -----------
  HSEARCH-2260 Added some leniency to ES mapping validation

  Commit: 554f9a89104d239e81252e8b6b5c067b60bb60fd
      https://github.com/hibernate/hibernate-search/commit/554f9a89104d239e81252e8b6b5c067b60bb60fd
  Author: Yoann Rodière <yrodiere at redhat.com>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexWorkVisitor.java
    R elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/FieldHelper.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ToElasticsearch.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/util/impl/FieldHelper.java

  Log Message:
  -----------
  HSEARCH-2260 Made FieldHelper publicly accesible to enable further refactoring

FieldHelper is still in an impl package, though, so it should not be used outside of this maven artifact.

  Commit: 5d695b201b908a4ee8f585b1b7b0d5b4be44826e
      https://github.com/hibernate/hibernate-search/commit/5d695b201b908a4ee8f585b1b7b0d5b4be44826e
  Author: Yoann Rodière <yrodiere at redhat.com>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/cfg/ElasticsearchIndexStatus.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaCreator.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaDropper.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaMigrator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaAccessor.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaCreator.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaDropper.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaMigrator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaValidator.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ExecutionOptions.java
    A elasticsearch/src/main/resources/META-INF/services/org.hibernate.search.elasticsearch.schema.impl.ElasticsearchSchemaAccessor
    A elasticsearch/src/main/resources/META-INF/services/org.hibernate.search.elasticsearch.schema.impl.ElasticsearchSchemaCreator
    A elasticsearch/src/main/resources/META-INF/services/org.hibernate.search.elasticsearch.schema.impl.ElasticsearchSchemaDropper
    A elasticsearch/src/main/resources/META-INF/services/org.hibernate.search.elasticsearch.schema.impl.ElasticsearchSchemaMigrator
    A elasticsearch/src/main/resources/META-INF/services/org.hibernate.search.elasticsearch.schema.impl.ElasticsearchSchemaValidator

  Log Message:
  -----------
  HSEARCH-2260 Moved all schema management code out of ESIndexManager

This cleans up the code and lays the groundwork for (later) introducing the schema export tools.

  Commit: 4c3b2263fe166bc6e09955107c403b604f9ec44e
      https://github.com/hibernate/hibernate-search/commit/4c3b2263fe166bc6e09955107c403b604f9ec44e
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    R elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticSearchIndexNullAsHelper.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java
    R elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchMappingBuilder.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/JsonAccessorBuilder.java
    R elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/PathComponentExtractor.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaTranslator.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticSearchIndexNullAsHelper.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchMappingBuilder.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaTranslator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ExecutionOptions.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/util/impl/PathComponentExtractor.java
    A elasticsearch/src/main/resources/META-INF/services/org.hibernate.search.elasticsearch.schema.impl.ElasticsearchSchemaTranslator

  Log Message:
  -----------
  HSEARCH-2260 Moved schema translation code outside of IndexManager

This cleans up the code and lays the groundwork for (later) introducing the schema export tools.

  Commit: ee2d84b8a6e1e57e443d12488726b1a0e86734c9
      https://github.com/hibernate/hibernate-search/commit/ee2d84b8a6e1e57e443d12488726b1a0e86734c9
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaAccessor.java

  Log Message:
  -----------
  HSEARCH-2260 Optimized Elasticsearch mappings retrieval

... by only retrieving the mappings for the one index we're interested in.

  Commit: 37c838f7797481e38774f404577bc7ec5ad41d7d
      https://github.com/hibernate/hibernate-search/commit/37c838f7797481e38774f404577bc7ec5ad41d7d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaMigrator.java
    A elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaMigrationIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/testutil/TestElasticsearchClient.java

  Log Message:
  -----------
  HSEARCH-2260 Added tests for the MERGE index schema management strategy

  Commit: 8b12b57bbdf92d294064c52de63fe094fc904d0a
      https://github.com/hibernate/hibernate-search/commit/8b12b57bbdf92d294064c52de63fe094fc904d0a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M documentation/src/main/asciidoc/elasticsearch-integration.asciidoc
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaAccessor.java

  Log Message:
  -----------
  HSEARCH-2260 Documented MERGE and VALIDATE

... Elasticsearch index schema management strategies.

  Commit: d3ec828a4bead8c2e76725c4988cdb6c4a025932
      https://github.com/hibernate/hibernate-search/commit/d3ec828a4bead8c2e76725c4988cdb6c4a025932
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaAccessor.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchValidationMessages.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationContext.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationErrorCollector.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaMigrationIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java
    M pom.xml

  Log Message:
  -----------
  HSEARCH-2260 Show all known errors when ES mapping validation fails

  Commit: 4f1d9392d303facc391e136f446138a29d5864d2
      https://github.com/hibernate/hibernate-search/commit/4f1d9392d303facc391e136f446138a29d5864d2
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-17 (Thu, 17 Nov 2016)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java
    M engine/src/main/java/org/hibernate/search/indexes/impl/IndexManagerHolder.java
    M engine/src/test/java/org/hibernate/search/test/util/impl/ExceptionMatcherBuilder.java

  Log Message:
  -----------
  HSEARCH-2260 Make sure to include all failing IndexManagers in the resulting exception

We continue to initialize other IndexManagers even if the first one
fails, adding the possible other exceptions to the first one using
Throwable.addSuppressed.

That way, once the exception is printed, every failing index manager
will show up.

Compare: https://github.com/hibernate/hibernate-search/compare/bb45e32d351c...4f1d9392d303