[hibernate-commits] [hibernate/hibernate-search] 0c32e8: HSEARCH-2457 Renamed getFieldName/getName to getAb...

GitHub noreply at github.com
Wed Nov 23 08:57:26 EST 2016


  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 0c32e80e5490657006ec25983f4b022a7355aecd
      https://github.com/hibernate/hibernate-search/commit/0c32e80e5490657006ec25983f4b022a7355aecd
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaTranslator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/util/impl/FieldHelper.java
    M engine/src/main/java/org/hibernate/search/engine/impl/DocumentBuilderHelper.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/BridgeDefinedField.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/DocumentFieldMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/FacetMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/FieldMetadataBuilderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/PropertyMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/SortableFieldMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/TypeMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/spi/DocumentBuilderIndexedEntity.java
    M engine/src/main/java/org/hibernate/search/metadata/impl/FieldDescriptorImpl.java
    M engine/src/main/java/org/hibernate/search/query/dsl/impl/ConnectedMoreLikeThisQueryBuilder.java
    M engine/src/main/java/org/hibernate/search/query/engine/impl/SortConfigurations.java
    M engine/src/test/java/org/hibernate/search/test/configuration/TypeMetadataTest.java
    M engine/src/test/java/org/hibernate/search/test/metadata/DocumentFieldMetadataTest.java

  Log Message:
  -----------
  HSEARCH-2457 Renamed getFieldName/getName to getAbsoluteName

... in internal metadata, so as to prevent confusions between relative
field name, absolute field name and property name.

We could have used the term "path", but it would have made less clear
that those strings are used as field names in Lucene "Fields", and would
have created weird pieces of code about everywhere, where we would do
something like "String fieldName = metadata.getPath()".

So this should prevent most confusions in the future while still making
sense in existing code.


  Commit: 3c679183d7bfba0c02a10fb6a24ae693a631c4e4
      https://github.com/hibernate/hibernate-search/commit/3c679183d7bfba0c02a10fb6a24ae693a631c4e4
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java
    M engine/src/main/java/org/hibernate/search/backend/impl/lucene/works/ByTermDeleteWorkExecutor.java
    M engine/src/main/java/org/hibernate/search/backend/impl/lucene/works/ByTermUpdateWorkExecutor.java
    M engine/src/main/java/org/hibernate/search/backend/impl/lucene/works/DeleteExtWorkExecutor.java
    M engine/src/main/java/org/hibernate/search/backend/impl/lucene/works/DeleteWorkExecutor.java
    M engine/src/main/java/org/hibernate/search/backend/impl/lucene/works/UpdateExtWorkExecutor.java
    M engine/src/main/java/org/hibernate/search/engine/impl/DocumentBuilderHelper.java
    M engine/src/main/java/org/hibernate/search/engine/spi/DocumentBuilderIndexedEntity.java
    M engine/src/main/java/org/hibernate/search/indexes/serialization/impl/LuceneWorkHydrator.java
    M engine/src/main/java/org/hibernate/search/query/dsl/impl/FieldContext.java
    M engine/src/main/java/org/hibernate/search/query/dsl/impl/MoreLikeThisBuilder.java
    M engine/src/main/java/org/hibernate/search/query/engine/impl/LuceneHSQuery.java
    M orm/src/main/java/org/hibernate/search/batchindexing/impl/BatchIndexingWorkspace.java
    M orm/src/main/java/org/hibernate/search/batchindexing/impl/IdentifierConsumerDocumentProducer.java
    M orm/src/main/java/org/hibernate/search/query/hibernate/impl/CriteriaObjectInitializer.java

  Log Message:
  -----------
  HSEARCH-2457 Clarified ID-related getters in DocumentBuilderIndexedEntity


  Commit: 277072167f111327b0bf6ebd4ec6f1b9068447e3
      https://github.com/hibernate/hibernate-search/commit/277072167f111327b0bf6ebd4ec6f1b9068447e3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/FieldMetadataBuilderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/TypeMetadata.java

  Log Message:
  -----------
  HSEARCH-2457 Clarified FieldMetadataBuilderImpl getters


  Commit: 242712f4f2d233d546d3e85a393366c801d31bfd
      https://github.com/hibernate/hibernate-search/commit/242712f4f2d233d546d3e85a393366c801d31bfd
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/bridge/spi/ConversionContext.java
    M engine/src/main/java/org/hibernate/search/bridge/util/impl/ContextualExceptionBridgeHelper.java
    M engine/src/main/java/org/hibernate/search/engine/impl/DocumentBuilderHelper.java
    M engine/src/main/java/org/hibernate/search/engine/spi/DocumentBuilderIndexedEntity.java
    M orm/src/main/java/org/hibernate/search/batchindexing/impl/IdentifierConsumerDocumentProducer.java
    M orm/src/test/java/org/hibernate/search/test/bridge/BridgeConversionErrorTest.java

  Log Message:
  -----------
  HSEARCH-2457 Fixed confusions between property name and absolute/relative field name


  Commit: 73ca2cabb422c4eb4617f7e9caf20787b4b5d8a0
      https://github.com/hibernate/hibernate-search/commit/73ca2cabb422c4eb4617f7e9caf20787b4b5d8a0
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/bridge/util/impl/ContextualExceptionBridgeHelper.java
    M orm/src/test/java/org/hibernate/search/test/bridge/BridgeConversionErrorTest.java

  Log Message:
  -----------
  HSEARCH-2457 Make sure ContextualExceptionBridgeHelper provides as much information as possible in exception messages

We must do with whatever info we already have in this class, and can't
add externally provided information, because the implemented interface,
ConversionContext, is SPI, and we don't want to break that.


  Commit: 415a2c3028b81964f1f0832bccf1988a4489aadf
      https://github.com/hibernate/hibernate-search/commit/415a2c3028b81964f1f0832bccf1988a4489aadf
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/SortableFieldMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/TypeMetadata.java
    M engine/src/test/java/org/hibernate/search/test/sorting/ManagedMultiReaderTest.java

  Log Message:
  -----------
  HSEARCH-2457 Made SortableFieldMetadata.Builder consistent with other builders

... by passing all the required data through constructor parameters.

It makes it obvious that a builder wasn't really necessary, but it was
probably added for consistency with other metadata.


  Commit: dd6632636efc093f9fdf1aa1920c65bd7e6f0ec7
      https://github.com/hibernate/hibernate-search/commit/dd6632636efc093f9fdf1aa1920c65bd7e6f0ec7
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java

  Log Message:
  -----------
  HSEARCH-2457 Fixed a case sensitivity issue introduced in 3b2927a8cdbfb07945d25313c1b9dedc95482d6c


  Commit: aaa9e6b5507dbd5f6aa5c07d4b736c6982588535
      https://github.com/hibernate/hibernate-search/commit/aaa9e6b5507dbd5f6aa5c07d4b736c6982588535
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/TypeMetadata.java

  Log Message:
  -----------
  Typo (missing word in a comment)


  Commit: cce869fa13264e954b15a9a0bac79d17d96e60a1
      https://github.com/hibernate/hibernate-search/commit/cce869fa13264e954b15a9a0bac79d17d96e60a1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/DocumentFieldMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/FacetMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/spi/DocumentBuilderIndexedEntity.java
    M engine/src/test/java/org/hibernate/search/test/bridge/builtin/TikaBridgeTest.java

  Log Message:
  -----------
  HSEARCH-2451 Add relative field names to the internal metadata

Preliminary work for HSEARCH-2451.


  Commit: 34e093d14d70aa323fd0d6eb5358694562a86954
      https://github.com/hibernate/hibernate-search/commit/34e093d14d70aa323fd0d6eb5358694562a86954
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/impl/nullencoding/NumericNullEncodersHelper.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/BridgeDefinedField.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/DocumentFieldMetadata.java
    A engine/src/main/java/org/hibernate/search/engine/metadata/impl/DocumentFieldPath.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/FacetMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/NumericFieldsConfiguration.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/ParseContext.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/PathsContext.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/SortableFieldMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/TypeMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/spi/DocumentBuilderIndexedEntity.java
    M engine/src/test/java/org/hibernate/search/test/bridge/builtin/TikaBridgeTest.java

  Log Message:
  -----------
  HSEARCH-2451 Introduced DocumentFieldPath

This class encloses all field path related data: the prefix, the
relative name, and the absolute name.


  Commit: 862bacea2ac26f3995f978f25ec814354f42d6db
      https://github.com/hibernate/hibernate-search/commit/862bacea2ac26f3995f978f25ec814354f42d6db
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/FacetMetadata.java

  Log Message:
  -----------
  HSEARCH-2451 Added the "source" field to FacetMetadata

Preliminary work for HSEARCH-2451.


  Commit: 2e6f0fb5ae21ed614144f9fb6eb231e82be3cc55
      https://github.com/hibernate/hibernate-search/commit/2e6f0fb5ae21ed614144f9fb6eb231e82be3cc55
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/TypeMetadata.java

  Log Message:
  -----------
  HSEARCH-2451 Added getters for FacetMetadata to TypeMetadata

Preliminary work for HSEARCH-2451.


  Commit: f82dd6294cebb6a115d6c4e465c9f809b632ddbf
      https://github.com/hibernate/hibernate-search/commit/f82dd6294cebb6a115d6c4e465c9f809b632ddbf
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexWorkVisitor.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ToElasticsearch.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaTranslator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchValidationMessages.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationContext.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationErrorCollector.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/model/PropertyMapping.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java
    M orm/src/test/java/org/hibernate/search/test/query/facet/StringFacetingTest.java

  Log Message:
  -----------
  HSEARCH-2451 Use Elasticsearch "fields" feature to implement faceting


  Commit: 76f4d3efb8e30e9b48cd236261e735df5c5cb744
      https://github.com/hibernate/hibernate-search/commit/76f4d3efb8e30e9b48cd236261e735df5c5cb744
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaTranslator.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/FacetMetadata.java

  Log Message:
  -----------
  HSEARCH-2451 ES: Use the same datatype for facet fields as for source field when asked for automatic encoding resolution


Compare: https://github.com/hibernate/hibernate-search/compare/516a89523a0e...76f4d3efb8e3


More information about the hibernate-commits mailing list