[hibernate-commits] [hibernate/hibernate-search] 77524d: HSEARCH-2360 Use source filtering in Elasticsearch...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 77524de4a5b57df860a8a8c25ef8f9dfb539092c
      https://github.com/hibernate/hibernate-search/commit/77524de4a5b57df860a8a8c25ef8f9dfb539092c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java

  Log Message:
  -----------
  HSEARCH-2360 Use source filtering in Elasticsearch queries

To achieve that, we need to inspect the metadata for each projected
field before querying. Since the code was very similar to the one
executed when extracting query results, I chose to build a "projection
metamodel" during the preliminary inspection projected field metadata.
That removes the need of inspecting metadata when extracting query hits.


  Commit: ce61560ad6ff3c9f1f964a4626bc6e2895b77182
      https://github.com/hibernate/hibernate-search/commit/ce61560ad6ff3c9f1f964a4626bc6e2895b77182
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java
    M engine/src/main/java/org/hibernate/search/query/engine/impl/AbstractHSQuery.java

  Log Message:
  -----------
  HSEARCH-2360 In HSQuery impls, make sure to clear cached results when the projection changes.


  Commit: 26dd4c8ecd51e777424b248b68b254d78cbaca1c
      https://github.com/hibernate/hibernate-search/commit/26dd4c8ecd51e777424b248b68b254d78cbaca1c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java

  Log Message:
  -----------
  HSEARCH-2360 Don't use an exact copy of the Elasticsearch search payload when calling the explain API


  Commit: b8494018203ffb9b9ba13aef1de6a6ed51599b5a
      https://github.com/hibernate/hibernate-search/commit/b8494018203ffb9b9ba13aef1de6a6ed51599b5a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java

  Log Message:
  -----------
  HSEARCH-2360 Renamed the "completeQuery" in ElasticsearchHSQueryImpl to "payload" to avoid confusion with the actual query


  Commit: 73a8d51be7d3655419b2bef745b84e71f1cdd2fc
      https://github.com/hibernate/hibernate-search/commit/73a8d51be7d3655419b2bef745b84e71f1cdd2fc
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchClassBridgeIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/testutil/TestElasticsearchClient.java

  Log Message:
  -----------
  HSEARCH-2471 Added support for projections on unmapped fields with Elasticsearch

That's probably what was originally intended with the current code
handling projections of one-way bridged fields.


  Commit: ff2a9d49dc0c964e52a899583fcfc59952ec66de
      https://github.com/hibernate/hibernate-search/commit/ff2a9d49dc0c964e52a899583fcfc59952ec66de
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/impl/DocumentBuilderHelper.java
    M engine/src/main/java/org/hibernate/search/util/logging/impl/Log.java
    M engine/src/test/java/org/hibernate/search/test/projection/ProjectionConversionTest.java

  Log Message:
  -----------
  HSEARCH-2470 Test the lack of support for projection on one-way field bridges


  Commit: 2cd2a454f8bd0a4257ca3a5f9191543d3b5ea9a1
      https://github.com/hibernate/hibernate-search/commit/2cd2a454f8bd0a4257ca3a5f9191543d3b5ea9a1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchHSQueryImpl.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/AgeBridge.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchClassBridgeIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchIndexMappingIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/NameConcatenationBridge.java

  Log Message:
  -----------
  HSEARCH-2470 Dropped support for projection on fields with a one-way bridge in Elasticsearch


  Commit: 86636e0776431b8194fc3d6709ea0c97096152d4
      https://github.com/hibernate/hibernate-search/commit/86636e0776431b8194fc3d6709ea0c97096152d4
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/util/impl/FieldHelper.java

  Log Message:
  -----------
  HSEARCH-2470 Made sure overriding the default field type in MetadataProvidingFieldBridge works with projections.

Follow-up on 3278599c0ae43b801897f96f1e1c2b3d30ca43ac, which was
incomplete.

Projections used to work in existing tests, but only because we
leveraged the "one-way field bridge" projections. Those are not
supported anymore, thus
org.hibernate.search.elasticsearch.test.ElasticsearchClassBridgeIT.testProjectionOfClassBridgeField()
started failing. Turning AgeBridge into a MetadataProvidingFieldBridge
and overriding the field type didn't work, though, and this commit aims
at fixing just that.


Compare: https://github.com/hibernate/hibernate-search/compare/523505a16517...86636e077643