[hibernate-commits] [hibernate/hibernate-search] eb89dd: HSEARCH-2392 Enable BridgeProviderTest for Elastic...

Mon Nov 28 12:04:07 EST 2016

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: eb89ddde1115db488c6865e5597faf5c058b2d7c
      https://github.com/hibernate/hibernate-search/commit/eb89ddde1115db488c6865e5597faf5c058b2d7c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M pom.xml

  Log Message:
  -----------
  HSEARCH-2392 Enable BridgeProviderTest for Elasticsearch

This requires altering slightly the way we build test-jars. We used to
exclude everything in META-INF following HSEARCH-1946: there seemingly
was an issue with persistence.xml. Since we need to include
META-INF/services for some tests to work, we now only exclude
META-INF/persistence.xml.

  Commit: edc812c6147e2fa8a5ef8c85f604d0ac0085c097
      https://github.com/hibernate/hibernate-search/commit/edc812c6147e2fa8a5ef8c85f604d0ac0085c097
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    A elasticsearch/src/test/java/org/hibernate/search/elasticsearch/testutil/ImportedTestRunner.java
    R elasticsearch/src/test/java/org/hibernate/search/elasticsearch/testutil/OrmTestRunner.java

  Log Message:
  -----------
  HSEARCH-2406 Run -engine tests when building the Elasticsearch module

  Commit: 8706f675538484726d666424a14747d746bc186b
      https://github.com/hibernate/hibernate-search/commit/8706f675538484726d666424a14747d746bc186b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchImplicitProvidedIdIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchMultitenancyIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchScrollingIT.java
    M elasticsearch/src/test/resources/hibernate.properties
    A elasticsearch/src/test/resources/test-defaults.properties
    M engine/src/test/java/org/hibernate/search/testsupport/junit/SearchFactoryHolder.java
    M engine/src/test/java/org/hibernate/search/testsupport/setup/SearchConfigurationForTest.java
    A engine/src/test/java/org/hibernate/search/testsupport/setup/TestDefaults.java
    A engine/src/test/resources/test-defaults.properties

  Log Message:
  -----------
  HSEARCH-2406 Use the ES index manager by default in SearchFactoryHolder for tests run in the Elasticsearch module

  Commit: 42d4ec83d8460a979956cd3b1e703c9372b8537f
      https://github.com/hibernate/hibernate-search/commit/42d4ec83d8460a979956cd3b1e703c9372b8537f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/ResourcesClosedInOrderTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/indexedembedded/IndexedEmbeddedWithAbstractClassTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/sharding/ShardingConfigurationTest.java
    M engine/src/test/java/org/hibernate/search/testsupport/BytemanHelper.java
    R engine/src/test/java/org/hibernate/search/testsupport/BytemanHelperStateCleanup.java
    M orm/src/test/java/org/hibernate/search/test/configuration/field/TokenizationTest.java
    M orm/src/test/java/org/hibernate/search/test/configuration/integration/HibernateSearchSessionFactoryObserverTest.java
    M orm/src/test/java/org/hibernate/search/test/query/initandlookup/CriteriaObjectInitializerAndHierarchyInheritanceTest.java
    M orm/src/test/java/org/hibernate/search/test/query/initandlookup/ObjectLookupAndDatabaseRetrievalConfigurationTest.java
    M orm/src/test/java/org/hibernate/search/test/query/objectloading/ObjectLoaderHelperTest.java

  Log Message:
  -----------
  HSEARCH-2406 Made sure tests using byteman won't leak context again

Tests requiring access to byteman-set data are now forced to use a JUnit
rule that will cleanup the context.
Previously, using that rule wasn't mandatory.

  Commit: 10a90711d8624734d8d241872a0670b660d71cc8
      https://github.com/hibernate/hibernate-search/commit/10a90711d8624734d8d241872a0670b660d71cc8
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M elasticsearch/elasticsearchconfiguration/elasticsearch.yml
    M engine/src/test/java/org/hibernate/search/test/sorting/SortingTest.java

  Log Message:
  -----------
  HSEARCH-2406 Fixed analyzer issues when running -engine tests in the -elasticsearch module

  Commit: 010c5aab3398bca3e470d0c16333bb53eae0c4f9
      https://github.com/hibernate/hibernate-search/commit/010c5aab3398bca3e470d0c16333bb53eae0c4f9
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/testsupport/concurrency/ConcurrentRunner.java

  Log Message:
  -----------
  HSEARCH-2406 Improved the stack trace when ConcurrentRunner fails

This was needed to diagnose an issue with ProjectionConversionTest.

  Commit: 746c974f2ce5d38906a2ae082ba085895059ac13
      https://github.com/hibernate/hibernate-search/commit/746c974f2ce5d38906a2ae082ba085895059ac13
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/AsyncBackendFlushTest.java
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/ResourcesClosedInOrderTest.java
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/SharedReleasesLocksTest.java
    M engine/src/test/java/org/hibernate/search/test/backend/lucene/SyncWorkProcessorShutDownTest.java
    M engine/src/test/java/org/hibernate/search/test/bridge/TwoWayFieldBridgeTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/DeleteByTermEnforcementTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/IndexManagerFactoryCustomizationTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/IndexMetadataCompleteConfiguredTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/IndexWriterTuningAppliedTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/OptimizerStrategyLoadTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/commitpolicy/CommitPolicyConfigurationTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/sharding/ShardingConfigurationTest.java
    M engine/src/test/java/org/hibernate/search/test/dsl/EmptyQueryExceptionTest.java
    M engine/src/test/java/org/hibernate/search/test/fileleaks/AllFilesClosedTest.java
    M engine/src/test/java/org/hibernate/search/test/filters/FreshReadersProvidedTest.java
    M engine/src/test/java/org/hibernate/search/test/id/providedId/ProvidedIdTest.java
    A engine/src/test/java/org/hibernate/search/test/indexmanager/DirectoryBasedIndexManagerTest.java
    R engine/src/test/java/org/hibernate/search/test/indexmanager/IndexManagerTest.java
    M engine/src/test/java/org/hibernate/search/test/sorting/ManagedMultiReaderTest.java
    M engine/src/test/java/org/hibernate/search/test/sorting/SortingTest.java

  Log Message:
  -----------
  HSEARCH-2406 Disabled lucene-specific -engine tests in the -elasticsearch module

  Commit: 2c20b7c9af2b5ea928f12ffef56356c23e95fba7
      https://github.com/hibernate/hibernate-search/commit/2c20b7c9af2b5ea928f12ffef56356c23e95fba7
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M elasticsearch/pom.xml
    M engine/src/test/java/org/hibernate/search/test/bridge/PropertiesExampleBridgeTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/mutablefactory/MutableFactoryTest.java
    M engine/src/test/java/org/hibernate/search/test/dsl/SortDSLTest.java
    M engine/src/test/java/org/hibernate/search/test/projection/ProjectionConversionTest.java
    M engine/src/test/java/org/hibernate/search/test/query/serialization/QuerySerializationTest.java
    M engine/src/test/java/org/hibernate/search/test/sharding/LogRotationExampleTest.java

  Log Message:
  -----------
  HSEARCH-2406 Ignore tests that fail due to bugs for now

  Commit: a6aed6206ee296a4ffb489e1e3363f487d3c1c35
      https://github.com/hibernate/hibernate-search/commit/a6aed6206ee296a4ffb489e1e3363f487d3c1c35
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/util/impl/ExpectedLog4jLog.java

  Log Message:
  -----------
  HSEARCH-2406 Added a way to check for the absence of logs to ExpectedLog4jLog.

  Commit: b1867179159fa2784344d922cf142524c180ac61
      https://github.com/hibernate/hibernate-search/commit/b1867179159fa2784344d922cf142524c180ac61
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/util/impl/ExpectedLog4jLog.java

  Log Message:
  -----------
  HSEARCH-2406 Don't execute the ExpectedLog4jLog rule when it's not necessary

  Commit: a351a296d8cbcbb6339f4798ab76687bf16558bf
      https://github.com/hibernate/hibernate-search/commit/a351a296d8cbcbb6339f4798ab76687bf16558bf
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/configuration/indexedembedded/IndexedEmbeddedWithAbstractClassTest.java
    M engine/src/test/java/org/hibernate/search/test/configuration/sharding/ShardingConfigurationTest.java
    M orm/src/test/java/org/hibernate/search/test/configuration/field/TokenizationTest.java

  Log Message:
  -----------
  HSEARCH-2406 Fixed tests relying on ByteMan rules in the -elasticsearch module

The ByteMan rules don't seem to work when run from the -elasticsearch
module for some reason. I didn't investigate, since there was a solution
that didn't involve ByteMan.

  Commit: 22adc0570807f302b97ddf248611fb8338c40803
      https://github.com/hibernate/hibernate-search/commit/22adc0570807f302b97ddf248611fb8338c40803
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/dsl/NumericTypeGuessedTest.java

  Log Message:
  -----------
  HSEARCH-2406 Fixed -engine tests using custom field bridges for Elasticsearch

Those bridges should implement MetadataProvidingFieldBridge to work
properly.

  Commit: 5a344bc48768ef80cc034014dfa31a997e12320f
      https://github.com/hibernate/hibernate-search/commit/5a344bc48768ef80cc034014dfa31a997e12320f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/configuration/mutablefactory/MutableFactoryTest.java

  Log Message:
  -----------
  HSEARCH-2406 Made sure MutableFactoryTest reports errors as originally intended

It seems the fix from af1cb0e95198985593f9b5411393da0a7f80ecd4 didn't
to address the issue of failing threads: it bypassed the code
responsible for detecting thread failures (by initializing the runnable's
"failure" attribute to a non-null value) and left that code in place.

  Commit: a862a7fe423687352480add853669528add1c226
      https://github.com/hibernate/hibernate-search/commit/a862a7fe423687352480add853669528add1c226
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/configuration/mutablefactory/MutableFactoryTest.java

  Log Message:
  -----------
  HSEARCH-2406 Removed dependencies to Lucene in MutableFactoryTest

  Commit: e71392a750ba553a0c1e37acc9c8e0bf3c1d330a
      https://github.com/hibernate/hibernate-search/commit/e71392a750ba553a0c1e37acc9c8e0bf3c1d330a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/configuration/mutablefactory/MutableFactoryTest.java

  Log Message:
  -----------
  HSEARCH-2406 Improved error reporting in MutableFactoryTest#testMultiThreadedAddClasses

  Commit: 2bfa87227e3cea83452aae354f2d2f95408ad4b6
      https://github.com/hibernate/hibernate-search/commit/2bfa87227e3cea83452aae354f2d2f95408ad4b6
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/configuration/mutablefactory/MutableFactoryTest.java

  Log Message:
  -----------
  HSEARCH-2406 Made sure MutableFactoryTest.testMultiThreadedAddClasses() doesn't time out with an Elasticsearch index manager

  Commit: fdb2d3f0a2c862fc59ae5cd6adb3baab1da8ba08
      https://github.com/hibernate/hibernate-search/commit/fdb2d3f0a2c862fc59ae5cd6adb3baab1da8ba08
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/bridge/builtin/TikaBridgeTest.java

  Log Message:
  -----------
  HSEARCH-2406 Made sure TikaBridgeTest will work when run in a test-jar

  Commit: 8e157e1b389af1bab6efb7a5ea3a611ef42f2433
      https://github.com/hibernate/hibernate-search/commit/8e157e1b389af1bab6efb7a5ea3a611ef42f2433
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/dsl/NumericTypeGuessedTest.java
    M engine/src/test/java/org/hibernate/search/test/query/serialization/QuerySerializationTest.java

  Log Message:
  -----------
  HSEARCH-2406 Fixed incorrect test names that probably resulted from copy-paste

  Commit: 6eb55eb3a43c32e50c0729cbc54158dba233e79c
      https://github.com/hibernate/hibernate-search/commit/6eb55eb3a43c32e50c0729cbc54158dba233e79c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/query/facet/FacetIndexingFailureTest.java

  Log Message:
  -----------
  HSEARCH-2406 Made FacetIndexingFailureTest work with the Elasticsearch indexing service

  Commit: 9b65853fc362ce77a54e2be24f59a500eaf306b9
      https://github.com/hibernate/hibernate-search/commit/9b65853fc362ce77a54e2be24f59a500eaf306b9
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/filters/FreshReadersProvidedTest.java

  Log Message:
  -----------
  HSEARCH-2406 Fixed an infinite recursion in FreshReadersProvidedTest.RecordingFilter#toString(String)

  Commit: 0cdc82d5b4192848f8b61dfe280c8b340ead3885
      https://github.com/hibernate/hibernate-search/commit/0cdc82d5b4192848f8b61dfe280c8b340ead3885
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/configuration/mutablefactory/DefinitionsOnHotRebootTest.java

  Log Message:
  -----------
  HSEARCH-2406 Made DefinitionsOnHotRebootTest work with the Elasticsearch indexing service

  Commit: 9c8b40455733306592df4debc1fd30bc1306a271
      https://github.com/hibernate/hibernate-search/commit/9c8b40455733306592df4debc1fd30bc1306a271
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/batchindexing/MassIndexerErrorReportingTest.java
    M orm/src/test/java/org/hibernate/search/test/configuration/integration/HibernateSearchSessionFactoryObserverTest.java
    M orm/src/test/java/org/hibernate/search/test/errorhandling/ErrorHandlingDuringDocumentCreationTest.java
    M orm/src/test/java/org/hibernate/search/test/query/facet/FacetIndexingFailureTest.java
    M orm/src/test/java/org/hibernate/search/test/query/initandlookup/CriteriaObjectInitializerAndHierarchyInheritanceTest.java
    M orm/src/test/java/org/hibernate/search/test/query/initandlookup/ObjectLookupAndDatabaseRetrievalConfigurationTest.java
    M orm/src/test/java/org/hibernate/search/test/query/objectloading/ObjectLoaderHelperTest.java

  Log Message:
  -----------
  HSEARCH-2406 Disabled -orm and -engine tests relying on Byteman in Elasticsearch due to HSEARCH-2481

Compare: https://github.com/hibernate/hibernate-search/compare/c101695f3921...9c8b40455733