[hibernate-commits] [hibernate/hibernate-search] 1f3c35: HSEARCH-2448 Fix an inconsistency in how tenant ID...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 1f3c35d3c6c383a86acfb3fa723ecd0d5baeada9
      https://github.com/hibernate/hibernate-search/commit/1f3c35d3c6c383a86acfb3fa723ecd0d5baeada9
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaTranslator.java

  Log Message:
  -----------
  HSEARCH-2448 Fix an inconsistency in how tenant ID fields are added to the mapping


  Commit: 133c54294cd6cc0c07101ca357478cbb39f8781f
      https://github.com/hibernate/hibernate-search/commit/133c54294cd6cc0c07101ca357478cbb39f8781f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/DocumentFieldMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/FieldMetadataBuilderImpl.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/NumericFieldsConfiguration.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/ParseContext.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/PathsContext.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/PropertyMetadata.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/TypeMetadata.java

  Log Message:
  -----------
  HSEARCH-2448 Make metadata order as stable as possible

It helps when debugging and writing tests.

By using LinkedHashSet/LinkedHashMap instead of HashSet/HashMap, we have
at least the guarantee that the metadata order will match the order in
which they were processed by the annotation processor. It does not mean
the order is fully predictable, since we process class fields/methods in
the same order they are returned by the JVM (which is undefined), but at
least we can rely on some properties of the annotation processor, such
as the fact that methods are handled before fields.


  Commit: 04be292d57ef483be5ccbb49eac6d8f1134128f1
      https://github.com/hibernate/hibernate-search/commit/04be292d57ef483be5ccbb49eac6d8f1134128f1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/test/java/org/hibernate/search/test/util/impl/ExceptionMatcherBuilder.java

  Log Message:
  -----------
  HSEARCH-2448 Solve issues with generic type bounds within ExceptionMatcherBuilder

The bounds made it difficult to make build() return Matcher<? super Throwable>,
which made it difficult to pass created matchers to CoreMatchers.hasItem.

Thus I removed the bounds: they serve no purpose anyway, since Matcher<T>
has no method that uses T. The type T is simply used internally for
reflection magic in TypeSafeMatcher.


  Commit: 36cee0230910c124192c983b5e68e4215bb71ffd
      https://github.com/hibernate/hibernate-search/commit/36cee0230910c124192c983b5e68e4215bb71ffd
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java
    A elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaNamingConflictIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/testutil/TestElasticsearchClient.java
    M orm/src/test/java/org/hibernate/search/test/SearchInitializationTestBase.java

  Log Message:
  -----------
  HSEARCH-2448 Test behavior for field naming conflicts in mapping generation when one field is composite and the other isn't


  Commit: 9a70f2577b8c40701ca06141d04da27da088ba1b
      https://github.com/hibernate/hibernate-search/commit/9a70f2577b8c40701ca06141d04da27da088ba1b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchMappingBuilder.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/model/DataType.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/util/impl/PathComponentExtractor.java

  Log Message:
  -----------
  HSEARCH-2448 Detect structural field naming conflicts in Elasticsearch mapping generation

I.e. detect when one of the conflicting fields is composite and the other isn't.


  Commit: e5382aaced0d9d9e4ba0361e3473a58428f88936
      https://github.com/hibernate/hibernate-search/commit/e5382aaced0d9d9e4ba0361e3473a58428f88936
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexWorkVisitor.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/JsonAccessor.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/JsonElementType.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/UnexpectedJsonElementTypeException.java

  Log Message:
  -----------
  HSEARCH-2448 Detect structural field naming conflicts during Elasticsearch indexation

I.e. detect when one of the conflicting fields is composite and the other isn't.


  Commit: c051bfe2ed8981482275ff63fbec3a5ea99d4cb3
      https://github.com/hibernate/hibernate-search/commit/c051bfe2ed8981482275ff63fbec3a5ea99d4cb3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    A orm/src/test/java/org/hibernate/search/test/bridge/ArrayBridgeNullEmbeddedTest.java
    A orm/src/test/java/org/hibernate/search/test/bridge/ArrayBridgeNullEmbeddedTestEntity.java
    M orm/src/test/java/org/hibernate/search/test/bridge/ArrayBridgeTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/ArrayBridgeTestEntity.java
    A orm/src/test/java/org/hibernate/search/test/bridge/IterableBridgeNullEmbeddedTest.java
    A orm/src/test/java/org/hibernate/search/test/bridge/IterableBridgeNullEmbeddedTestEntity.java
    M orm/src/test/java/org/hibernate/search/test/bridge/IterableBridgeTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/IterableBridgeTestEntity.java
    A orm/src/test/java/org/hibernate/search/test/bridge/MapBridgeNullEmbeddedTest.java
    A orm/src/test/java/org/hibernate/search/test/bridge/MapBridgeNullEmbeddedTestEntity.java
    M orm/src/test/java/org/hibernate/search/test/bridge/MapBridgeTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/MapBridgeTestEntity.java

  Log Message:
  -----------
  HSEARCH-2419 Split container bridges tests to test null-embedded naming conflicts separately

This is necessary because such conflicts trigger a totally different
behavior with Elasticsearch (following HSEARCH-2448), preventing the
search factory to build.


  Commit: f916ca94afc261eba62bfb310f7034f7fb0dca3c
      https://github.com/hibernate/hibernate-search/commit/f916ca94afc261eba62bfb310f7034f7fb0dca3c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/GolfPlayer.java
    M orm/src/test/java/org/hibernate/search/test/event/autoindexembeddable/EmbeddableCategories.java

  Log Message:
  -----------
  HSEARCH-2419 Fix occurrences of properties with both @Field and @IndexedeEmbedded in tests


  Commit: 8d7597ae23a5d146feabfd1af29e7b0da8dce114
      https://github.com/hibernate/hibernate-search/commit/8d7597ae23a5d146feabfd1af29e7b0da8dce114
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-11-28 (Mon, 28 Nov 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/bridge/impl/BridgeFactory.java

  Log Message:
  -----------
  HSEARCH-2419 Do not require @IndexedEmbedded to make use of built-in container bridges


Compare: https://github.com/hibernate/hibernate-search/compare/1598454311af...8d7597ae23a5