[hibernate-commits] [hibernate/hibernate-search] 25795f: HSEARCH-2433 Test case for providedId being interp...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 25795fc6cee3ff84ae046947cadc67d9bda1f873
      https://github.com/hibernate/hibernate-search/commit/25795fc6cee3ff84ae046947cadc67d9bda1f873
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-10-31 (Mon, 31 Oct 2016)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchImplicitProvidedIdIT.java

  Log Message:
  -----------
  HSEARCH-2433 Test case for providedId being interpreted as part of an embedded


  Commit: 6d8e833bdb7ecf73b32f602cfdf4b08939ffef1c
      https://github.com/hibernate/hibernate-search/commit/6d8e833bdb7ecf73b32f602cfdf4b08939ffef1c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-10-31 (Mon, 31 Oct 2016)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java

  Log Message:
  -----------
  HSEARCH-2433 Fix how provided IDs on IndexedEmbeddeds are handled

There were three issues:

 * The prefix was not used on the providedId field, potentially
   resulting in root type provided ID being erased by embeddeds' provided
   IDs
 * The providedId was being added unconditionally for embeddeds, not
   respecting settings like @IndexedEmbedded.includeEmbeddedObjectIds
 * The field bridge was not ignored as required when creating metadata
   for containedIn


  Commit: f8519919ecb33ce9d2fa405a611d71fbf34d975b
      https://github.com/hibernate/hibernate-search/commit/f8519919ecb33ce9d2fa405a611d71fbf34d975b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-10-31 (Mon, 31 Oct 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/embedded/Address.java
    M orm/src/test/java/org/hibernate/search/test/embedded/EmbeddedTest.java
    M orm/src/test/java/org/hibernate/search/test/embedded/nullindexed/NullEmbeddedTest.java
    M orm/src/test/java/org/hibernate/search/test/embedded/nullindexed/Pet.java
    A orm/src/test/java/org/hibernate/search/test/embedded/nullindexed/Trick.java

  Log Message:
  -----------
  HSEARCH-2408 Added advanced test for embedded @ElementCollections

In particular, we now expect prefix and indexNullAs to work.


  Commit: acf3856f2808816d2a26f007f8caff39d8e3c1c1
      https://github.com/hibernate/hibernate-search/commit/acf3856f2808816d2a26f007f8caff39d8e3c1c1
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-10-31 (Mon, 31 Oct 2016)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/bridge/ArrayBridgeTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/ArrayBridgeTestEntity.java
    M orm/src/test/java/org/hibernate/search/test/bridge/IterableBridgeTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/IterableBridgeTestEntity.java
    M orm/src/test/java/org/hibernate/search/test/bridge/MapBridgeTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/MapBridgeTestEntity.java

  Log Message:
  -----------
  HSEARCH-2408 Ignore null embedded tests in container bridge tests with ES

They used to pass because of some mix-up between the container bridges
field names and the embedded null field names. There really is some work
to be done to get them working properly, though (HSEARCH-2389).


  Commit: 57e0af82b8f79d3dab3111dc6a47583da8385fdc
      https://github.com/hibernate/hibernate-search/commit/57e0af82b8f79d3dab3111dc6a47583da8385fdc
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2016-10-31 (Mon, 31 Oct 2016)

  Changed paths:
    M documentation/src/main/asciidoc/mapping.asciidoc
    M engine/src/main/java/org/hibernate/search/annotations/IndexedEmbedded.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M engine/src/main/java/org/hibernate/search/util/logging/impl/Log.java

  Log Message:
  -----------
  HSEARCH-2408 Fixed and documented @IndexedEmbedded.indexNullAs

The behavior was previously inconsistent for @ElementCollection
embeddeds, in particular, and the name of the field carrying the null
token was undocumented.


Compare: https://github.com/hibernate/hibernate-search/compare/7fc4ecb7ffa3...57e0af82b8f7