[hibernate-commits] [hibernate/hibernate-search] 86c8b4: HSEARCH-2656 Fix an inconsistency in MapBridgeNull...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 86c8b40f96055bb98e121388bdcff68e06c3f6b3
      https://github.com/hibernate/hibernate-search/commit/86c8b40f96055bb98e121388bdcff68e06c3f6b3
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-04-04 (Tue, 04 Apr 2017)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/bridge/MapBridgeNullEmbeddedTest.java
    M orm/src/test/java/org/hibernate/search/test/bridge/MapBridgeTest.java

  Log Message:
  -----------
  HSEARCH-2656 Fix an inconsistency in MapBridgeNullEmbeddedTest

This test wasn't disabling field bridges when querying with a string
value on a numeric field, which should have failed, but didn't because
we used to rely on the field bridge to determine numericness, and
container bridges aren't numeric.


  Commit: 61f61ab6ee741b2fa3037274d94f94318543c182
      https://github.com/hibernate/hibernate-search/commit/61f61ab6ee741b2fa3037274d94f94318543c182
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-04-04 (Tue, 04 Apr 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/AnnotationMetadataProvider.java
    M engine/src/main/java/org/hibernate/search/engine/metadata/impl/DocumentFieldMetadata.java
    M engine/src/test/java/org/hibernate/search/test/metadata/FieldDescriptorTest.java

  Log Message:
  -----------
  HSEARCH-2656 Take MetadataProvidingFieldBridges into account when determining whether a field is numeric


  Commit: 3509ab764c019f2e7688191a1999b1cfe261d36f
      https://github.com/hibernate/hibernate-search/commit/3509ab764c019f2e7688191a1999b1cfe261d36f
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-04-04 (Tue, 04 Apr 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/query/dsl/impl/ConnectedMultiFieldsRangeQueryBuilder.java
    M engine/src/main/java/org/hibernate/search/query/dsl/impl/ConnectedMultiFieldsTermQueryBuilder.java
    M engine/src/main/java/org/hibernate/search/query/dsl/impl/Helper.java

  Log Message:
  -----------
  HSEARCH-2656 Take metadata into account when determining whether a field is numeric in keyword() queries

We used to only take the field bridge into account, but some metadata
may have been contributed by this field bridge.

This does not address the case of non-default fields declared in
MetadataProvidingFieldBridge. Such fields would require more changes,
and in my opinion we should delay their support to 6.0.


  Commit: 3d51057a684a9b4308e9702266486ec0f5ec5eef
      https://github.com/hibernate/hibernate-search/commit/3d51057a684a9b4308e9702266486ec0f5ec5eef
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-04-04 (Tue, 04 Apr 2017)

  Changed paths:
    M orm/src/test/java/org/hibernate/search/test/query/dsl/DSLTest.java
    M orm/src/test/java/org/hibernate/search/test/query/dsl/Month.java
    A orm/src/test/java/org/hibernate/search/test/query/dsl/MonthBase0FieldBridge.java

  Log Message:
  -----------
  HSEARCH-2656 Test detection of numeric fields when querying on fields with custom MetadataProvidingFieldBridges


Compare: https://github.com/hibernate/hibernate-search/compare/50c08852196b...3d51057a684a