[hibernate-commits] [hibernate/hibernate-validator] ce1a5e: HV-1458 Group the reflection and the setAccessible...

GitHub noreply at github.com
Fri Aug 4 01:10:49 EDT 2017


  Branch: refs/heads/6.0.0-build-branch
  Home:   https://github.com/hibernate/hibernate-validator
  Commit: ce1a5ef729a9e88a241391268d2559e914f2d156
      https://github.com/hibernate/hibernate-validator/commit/ce1a5ef729a9e88a241391268d2559e914f2d156
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/FieldConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/location/GetterConstraintLocation.java
    M engine/src/main/java/org/hibernate/validator/internal/util/privilegedactions/GetDeclaredField.java
    M engine/src/main/java/org/hibernate/validator/internal/util/privilegedactions/GetDeclaredMethod.java
    M engine/src/main/java/org/hibernate/validator/internal/util/privilegedactions/SetAccessibility.java

  Log Message:
  -----------
  HV-1458 Group the reflection and the setAccessible privileged actions


  Commit: 8e98ab6579caa29bc7b03e03f8b3cd6e105a4945
      https://github.com/hibernate/hibernate-validator/commit/8e98ab6579caa29bc7b03e03f8b3cd6e105a4945
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java

  Log Message:
  -----------
  HV-1438 Use Set consistently while manipulating value extractor
descriptors


  Commit: b2c07cd8b1682f6d3d43ddf079a2cd62101f1f7a
      https://github.com/hibernate/hibernate-validator/commit/b2c07cd8b1682f6d3d43ddf079a2cd62101f1f7a
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedExecutableBuilder.java
    M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedFieldBuilder.java
    M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedGetterBuilder.java
    M engine/src/main/java/org/hibernate/validator/internal/xml/ConstrainedParameterBuilder.java

  Log Message:
  -----------
  HV-1438 Fix XML cascading metadata for arrays

It was fixed for the annotations as part of HV-1384 but it was forgotten
for the XML part. The issue was hidden by how cascading was
implemented but some tests will fail once the follow up changes will be
incorporated.


  Commit: 4cbedfe823c999b27f64cff61242205e2cdf6238
      https://github.com/hibernate/hibernate-validator/commit/4cbedfe823c999b27f64cff61242205e2cdf6238
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/metadata/core/MetaConstraints.java

  Log Message:
  -----------
  HV-1438 Use the right method to throw the exception

This issue was previously hidden but it was an oversight.


  Commit: 27c183af9bd38d5528b67f1348c68c70ab5272cf
      https://github.com/hibernate/hibernate-validator/commit/27c183af9bd38d5528b67f1348c68c70ab5272cf
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorDescriptor.java
    M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java

  Log Message:
  -----------
  HV-1438 Improve a log message


  Commit: 27770a2044430c8a1356c38f2d2f681ba48c91fa
      https://github.com/hibernate/hibernate-validator/commit/27770a2044430c8a1356c38f2d2f681ba48c91fa
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
    R engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ObjectValueExtractor.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java

  Log Message:
  -----------
  HV-1438 Remove the ObjectValueExtractor

It's one more value extractor to test and it's always a valid candidate.

Moreover, it hid some unexpected behaviors.


  Commit: bf4ff2b96404ff4f86a59cb5eb350be5c91ee34c
      https://github.com/hibernate/hibernate-validator/commit/bf4ff2b96404ff4f86a59cb5eb350be5c91ee34c
  Author: Guillaume Smet <guillaume.smet at gmail.com>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java
    M engine/src/main/java/org/hibernate/validator/internal/engine/valueextraction/ValueExtractorManager.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ExecutableMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/FieldCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/GetterCascadable.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ParameterMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/PropertyMetaData.java
    M engine/src/main/java/org/hibernate/validator/internal/util/Contracts.java
    M engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java

  Log Message:
  -----------
  HV-1438 Narrow down the possible value extractors to the ones compatible
with the declared type when dealing with cascaded validation


Compare: https://github.com/hibernate/hibernate-validator/compare/c848e3ce4efc...bf4ff2b96404


More information about the hibernate-commits mailing list