[hibernate-commits] [hibernate/hibernate-search] 3bffe5: HSEARCH-2519 Add missing parameters in the javadoc...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 3bffe5c23e089385753483f7c0a76060bfee22ab
      https://github.com/hibernate/hibernate-search/commit/3bffe5c23e089385753483f7c0a76060bfee22ab
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaCreator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaDropper.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaMigrator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaValidator.java

  Log Message:
  -----------
  HSEARCH-2519 Add missing parameters in the javadoc of elasticsearch schema helpers


  Commit: 1bd874cf93ebcdcb55a90a784dbc4d00e4c8920c
      https://github.com/hibernate/hibernate-search/commit/1bd874cf93ebcdcb55a90a784dbc4d00e4c8920c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M documentation/src/main/asciidoc/elasticsearch-integration.asciidoc
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/cfg/IndexSchemaManagementStrategy.java

  Log Message:
  -----------
  HSEARCH-2519 Make it clearer in the doc that schema management strategies may affect analyzer definitions.


  Commit: 386b17b59c4f5d961c3234123ae03f9b9f43de7c
      https://github.com/hibernate/hibernate-search/commit/386b17b59c4f5d961c3234123ae03f9b9f43de7c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/util/impl/gson/AbstractExtraPropertiesJsonAdapter.java

  Log Message:
  -----------
  HSEARCH-2519 Fix AbstractExtraPropertiesJsonAdapter.read (used to return null)


  Commit: 70a7ecc41c41674461f3dd4f0749e6206abfc594
      https://github.com/hibernate/hibernate-search/commit/70a7ecc41c41674461f3dd4f0749e6206abfc594
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/settings/impl/model/IndexSettings.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/settings/impl/model/TokenFilterDefinition.java

  Log Message:
  -----------
  HSEARCH-2519 Add some missing toString implementations in ES index metadata types


  Commit: 2b924a3bb261c83351d5a7aa0ff7262819d34228
      https://github.com/hibernate/hibernate-search/commit/2b924a3bb261c83351d5a7aa0ff7262819d34228
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/ElasticsearchCharFilterFactory.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/analyzer/ElasticsearchTokenizerFactory.java

  Log Message:
  -----------
  HSEARCH-2519 Fix copy/paste errors in the javadoc


  Commit: c694fe8e1d96b958f7a10fc5ad0efde091ee8c16
      https://github.com/hibernate/hibernate-search/commit/c694fe8e1d96b958f7a10fc5ad0efde091ee8c16
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/logging/impl/Log.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaAccessor.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchSchemaValidator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchValidationMessages.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationContext.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationErrorCollector.java

  Log Message:
  -----------
  HSEARCH-2519 Validate analyzer definitions in ES's VALIDATE schema management strategy

Limitations:

 * definition parameters are compared quite strictly; for instance
   arrays are always considered ordered, while order actually doesn't
   matter for some parameters. This could be avoided with a metamodel
   that would mention the few unordered array parameters.
 * default values are not handled, i.e. a definition setting a parameter
   to its default value will be deemed invalid if the expected
   definition doesn't mention this parameter. This could be avoided,
   but would require a massive metamodel of all Elasticsearch analysis
   types.


  Commit: 2be40546fd151646b4f8218457606fb3cf1983ce
      https://github.com/hibernate/hibernate-search/commit/2be40546fd151646b4f8218457606fb3cf1983ce
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/testutil/TestElasticsearchClient.java

  Log Message:
  -----------
  HSEARCH-2519 Test ES's VALIDATE schema management strategy with analyzer definitions


  Commit: 7ddf3d217a0874db9e8465c6d4683976d4838c33
      https://github.com/hibernate/hibernate-search/commit/7ddf3d217a0874db9e8465c6d4683976d4838c33
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/settings/impl/CjkBigramIgnoredScriptsParametersTransformer.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/DefaultElasticsearchAnalyzerDefinitionTranslatorTest.java

  Log Message:
  -----------
  HSEARCH-2519 When translating analysis factories for ES, make sure the order of elements in array parameters is stable

This will avoid issues when validating the schema.


  Commit: d101947d7ae630eece5624293d2eb2a5cd490a8a
      https://github.com/hibernate/hibernate-search/commit/d101947d7ae630eece5624293d2eb2a5cd490a8a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/json/AnalysisJsonElementEquivalence.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/json/AnalysisJsonElementUnorderedArrayEquivalence.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/json/AnalysisParameterEquivalenceRegistry.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java

  Log Message:
  -----------
  HSEARCH-2519 Add support for unordered arrays when validating ES analyzer definitions

Mapping arrays are still considered ordered just to be safe, because
some mappings are applied recursively, which means the order may make a
difference.


  Commit: 5b6b3d09dad8c1d203f6efb603d9fb1ab4d00c76
      https://github.com/hibernate/hibernate-search/commit/5b6b3d09dad8c1d203f6efb603d9fb1ab4d00c76
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/DefaultElasticsearchSchemaValidator.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ElasticsearchValidationMessages.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationContext.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationContextElement.java
    A elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationContextType.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/schema/impl/ValidationErrorCollector.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchSchemaValidationIT.java

  Log Message:
  -----------
  HSEARCH-2519 Reduce code duplication in DefaultElasticsearchSchemaValidator

The volume of code does not change much, but it feels a bit cleaner.
This commit can be removed without impacting features.


  Commit: 2a6c7ac811c000ec32bcd81eede2e3199138ae6d
      https://github.com/hibernate/hibernate-search/commit/2a6c7ac811c000ec32bcd81eede2e3199138ae6d
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-01-20 (Fri, 20 Jan 2017)

  Changed paths:
    M documentation/src/main/asciidoc/elasticsearch-integration.asciidoc
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/cfg/IndexSchemaManagementStrategy.java

  Log Message:
  -----------
  HSEARCH-2519 Document that the VALIDATE strategy now validates analyzer definitions


Compare: https://github.com/hibernate/hibernate-search/compare/6ffa153e9f61...2a6c7ac811c0