[hibernate-commits] [hibernate/hibernate-search] 109093: HSEARCH-2652 Move Elasticsearch error handling tes...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/hibernate/hibernate-search
  Commit: 109093d0fe212c66af77bef4118ee14022589e34
      https://github.com/hibernate/hibernate-search/commit/109093d0fe212c66af77bef4118ee14022589e34
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    R elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchExceptionHandlingIT.java
    A elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchIndexWorkProcessorErrorHandlingTest.java
    M orm/src/test/java/org/hibernate/search/test/errorhandling/LuceneErrorHandlingTest.java

  Log Message:
  -----------
  HSEARCH-2652 Move Elasticsearch error handling tests to a unit test

This should make testing the "multiple non-bulkable works" case easier;
we could test it in an integration test, but it would require creating
250+ works so that we reach the bulk size limit and at least two bulk
works are created...


  Commit: 23044ae18c660d340ad3b7d86936322b05e575e7
      https://github.com/hibernate/hibernate-search/commit/23044ae18c660d340ad3b7d86936322b05e575e7
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/processor/impl/ElasticsearchWorkProcessor.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchIndexWorkProcessorErrorHandlingTest.java

  Log Message:
  -----------
  HSEARCH-2652 Use one error context per set of works with Elasticsearch in sync mode

... instead of one error context per (potentially bulk) work.

This is approximately the same behavior as Lucene. The Lucene backend is
a bit different, since it groups synchronous works further and
potentially executes multiple sets of works in one pass, with a single
error context, whereas with Elasticsearch we just execute each set of
works separately.


  Commit: 99d293432b46fa3016cfe247259b3ff72482955c
      https://github.com/hibernate/hibernate-search/commit/99d293432b46fa3016cfe247259b3ff72482955c
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M engine/src/main/java/org/hibernate/search/backend/impl/lucene/Changeset.java
    R engine/src/main/java/org/hibernate/search/backend/impl/lucene/ChangesetList.java
    M engine/src/main/java/org/hibernate/search/backend/impl/lucene/SyncWorkProcessor.java
    M engine/src/main/java/org/hibernate/search/util/impl/CollectionHelper.java
    R engine/src/test/java/org/hibernate/search/test/backend/lucene/ChangeSetIteratorTest.java
    A engine/src/test/java/org/hibernate/search/test/util/impl/IterableFlatteningTest.java

  Log Message:
  -----------
  HSEARCH-2652 Move Lucene changeset flattening code to CollectionHelper


  Commit: 0ad3bab4450da36005dc801f4a046bb27fc1d57a
      https://github.com/hibernate/hibernate-search/commit/0ad3bab4450da36005dc801f4a046bb27fc1d57a
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/processor/impl/ElasticsearchWorkProcessor.java
    M elasticsearch/src/test/java/org/hibernate/search/elasticsearch/test/ElasticsearchIndexWorkProcessorErrorHandlingTest.java

  Log Message:
  -----------
  HSEARCH-2652 Use one error context per set of works with Elasticsearch in async, non-stream mode


  Commit: 981195f731c7942097c5865df61bba9e3341c04b
      https://github.com/hibernate/hibernate-search/commit/981195f731c7942097c5865df61bba9e3341c04b
  Author: Yoann Rodière <yoann at hibernate.org>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/impl/ElasticsearchIndexManager.java
    M elasticsearch/src/main/java/org/hibernate/search/elasticsearch/processor/impl/ElasticsearchWorkProcessor.java

  Log Message:
  -----------
  HSEARCH-2652 Simplify work execution code in ElasticsearchIndexManager

The boolean may have served a purpose initially, but it doesn't anymore.

Note that we don't need to check for null, as works returned by the
visitor are never null.


Compare: https://github.com/hibernate/hibernate-search/compare/cd9e1a120bf3...981195f731c7